From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Include register polling in reg_rw traces Date: Tue, 5 Feb 2019 20:58:16 +0200 Message-ID: <20190205185816.GX20097@intel.com> References: <20190204211644.21967-1-ville.syrjala@linux.intel.com> <154931597816.16726.17106483715116050662@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ECF46E13D for ; Tue, 5 Feb 2019 18:58:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <154931597816.16726.17106483715116050662@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMDQsIDIwMTkgYXQgMDk6MzM6MDhQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wMi0wNCAyMToxNjo0NCkKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IFdlIGdlbmVyYWxseSBvbWl0IHJlZ2lzdGVyIHBvbGxpbmcgZnJvbSB0aGUgaTkxNV9yZWdf cncgdHJhY2Vwb2ludC4KPiA+IFVuZGVyc3RhbmRhYmxlIHNpbmNlIHBvbGxpbmcgY291bGQgZ2Vu ZXJhdGUgYSBsb3Qgb2Ygbm9pc2UgaW4gdGhlCj4gPiB0cmFjZS4gVGhlIGRvd25zaWRlIGlzIHRo YXQgdGhlIHRyYWNlIGlzIGluY29tcGxldGUuIEFzIGEgY29tcHJvbWlzZQo+ID4gbGV0J3MgdHJh Y2UgdGhlIGZpbmFsIHJlZ2lzdGVyIHZhbHVlIG9ic2VydmVkIHdoaWxlIHBvbGxpbmcuIFRoYXQK PiA+IHNob3VsZCBiZSBnZW5lcmFsbHkgc3VmZmljaWVudCB0byBvYnNlcnZlIHdoYXQgdGhlIGNv ZGUgc2hvdWxkIGJlCj4gPiBkb2luZyBuZXh0Lgo+IAo+IEZhaXIgY29tcHJvbWlzZTsgSSBhZG1p dCB0aGUgc3ViamVjdCBsaW5lIGhhZCBtZSBmcmVha2luZyBvdXQuCj4gIAo+ID4gSSBzdXBwb3Nl IGluIHNvbWUgY2FzZXMgaXQgbWlnaHQgbWFrZSBzZW5zZSB0byBhbHNvIHRyYWNlIHRoZSBpbml0 aWFsCj4gPiByZWdpc3RlciB2YWx1ZSwgYW5kIG1heWJlIHRoZSBudW1iZXIgb2YgdGltZXMgd2Ug cG9sbGVkLiBCdXQgdGhhdAo+ID4gd291bGQgcmVxdWlyZSBhIHNlcGFyYXRlIHRyYWNlcG9pbnQg c28gbGV0J3MgbGVhdmUgaXQgZm9yIHRoZSBmdXR1cmUuCj4gCj4gSSBwb3N0dWxhdGUgd2hlbiB5 b3UgZ2V0IGRvd24gdG8gd2FudGluZyB0aGF0IGFtb3VudCBvZiBkZXRhaWwsIHlvdQo+IHRocm93 IGluIGRlZGljYXRlZCBkZWJ1Zy4KPiAgCj4gPiBUaGUgb3RoZXIgdXNlcnMgb2YgX05PVFJBQ0Uo KSBhcmUgaTkxNV9wbXUgYW5kIGkyYyBiaXRiYW5naW5nLAo+ID4gd2hpY2ggSSBkZWNpZGVkIHRv IGxlYXZlIGFsb25lLgo+ID4gCj4gPiBOZXh0IHdlIHNob3VsZCBkbyBzb21ldGhpbmcgdG8gY2xh dyBiYWNrIHRoZSB0cmFjZXBvaW50cyBmb3IKPiA+IHBsYW5lcyBhbmQgd2hhdG5vdCB3aGljaCB3 ZXJlIHN3aXRjaGVkIHRvIF9GVygpIGEgd2hpbGUgYmFjay4KPiA+IEkgZ3Vlc3MganVzdCBuZXcg bWFjcm9zIGZvciByYXdfcncrdHJhY2UuIFRoZSBxdWVzdGlvbiBpcwo+ID4gd2hhdCB0byBjYWxs IGl0Pwo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuYyAgICAgfCAxMiArKysrKysrKysrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jICAgICB8ICA2ICsrKysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3VuY29yZS5jIHwgIDMgKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiA+IGluZGV4 IGE3YWFhMWFjNGM5OS4uN2RlOTA3MDFmNmYxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYwo+ID4gQEAgLTI1NDMsNiArMjU0MywxMCBAQCBzdGF0aWMgdm9pZCB2bHZfcmVzdG9yZV9n dW5pdF9zMGl4X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICBz dGF0aWMgaW50IHZsdl93YWl0X2Zvcl9wd19zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBtYXNr LCB1MzIgdmFsKQo+ID4gIHsKPiA+ICsgICAgICAgaTkxNV9yZWdfdCByZWcgPSBWTFZfR1RMQ19Q V19TVEFUVVM7Cj4gPiArICAgICAgIHUzMiByZWdfdmFsdWU7Cj4gPiArICAgICAgIGludCByZXQ7 Cj4gPiArCj4gPiAgICAgICAgIC8qIFRoZSBIVyBkb2VzIG5vdCBsaWtlIHVzIHBvbGxpbmcgZm9y IFBXX1NUQVRVUyBmcmVxdWVudGx5LCBzbwo+ID4gICAgICAgICAgKiB1c2UgdGhlIHNsZWVwaW5n IGxvb3AgcmF0aGVyIHRoYW4gcmlzayB0aGUgYnVzeSBzcGluIHdpdGhpbgo+ID4gICAgICAgICAg KiBpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcigpLgo+ID4gQEAgLTI1NTAsOCArMjU1NCwxMiBAQCBz dGF0aWMgaW50IHZsdl93YWl0X2Zvcl9wd19zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gICAgICAgICAgKiBUcmFuc2l0aW9uaW5nIGJldHdlZW4gUkM2IHN0YXRl cyBzaG91bGQgYmUgYXQgbW9zdCAybXMgKHNlZQo+ID4gICAgICAgICAgKiB2YWxsZXl2aWV3X2Vu YWJsZV9ycHMpIHNvIHVzZSBhIDNtcyB0aW1lb3V0Lgo+ID4gICAgICAgICAgKi8KPiA+IC0gICAg ICAgcmV0dXJuIHdhaXRfZm9yKChJOTE1X1JFQURfTk9UUkFDRShWTFZfR1RMQ19QV19TVEFUVVMp ICYgbWFzaykgPT0gdmFsLAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgMyk7Cj4gPiArICAg ICAgIHJldCA9IHdhaXRfZm9yKCgocmVnX3ZhbHVlID0gSTkxNV9SRUFEX05PVFJBQ0UocmVnKSkg JiBtYXNrKSA9PSB2YWwsIDMpOwo+ID4gKwo+ID4gKyAgICAgICAvKiBqdXN0IHRyYWNlIHRoZSBm aW5hbCB2YWx1ZSAqLwo+ID4gKyAgICAgICB0cmFjZV9pOTE1X3JlZ19ydyhmYWxzZSwgcmVnLCBy ZWdfdmFsdWUsIHNpemVvZihyZWdfdmFsdWUpLCB0cnVlKTsKPiAKPiBJIGZlZWwgbGlrZSB0aGVy ZSdzIGEgcGF0dGVybiBoZXJlIHRoYXQgY291bGQgYmVuZWZpdCBmcm9tIGEgY29udmVuaWVudAo+ IG1hY3JvLgoKRW50aXJlbHkgcG9zc2libGUuIEkndmUgbm90IHlldCBsb29rZWQgYXQgdGhlIGN1 cnJlbnQgX0ZXKCkgdXNlcnMKdG8gc2VlIGlmIHRoZXkgc2hhcmUgdGhlIHNhbWUgcGF0dGVybiBp biBhbnkgc2lnbmlkaWNhbnQgbnVtYmVycy4KV2hpY2ggYnJpbmdzIG1lIGJhY2sgdG8gdGhlIHRv cGljIG9mIHdoYXQgdG8gZG8gd2l0aCBfRlcoKS4uLgoKTWF5YmUgSSBzaG91bGQganVzdCBzcGxp dCBfRlcoKSBpbnRvIF9GVygpIGFuZCBGV19OT1RSQUNFKCk/Ck9yIGlmIHdlIGdvIHRoZSBvdGhl ciB3YXksIG1heWJlIGFkZCBfRldfVFJBQ0UoKT8gQnVyIGFsbCB0aGUKcGxhbmUgcmVncyB3b3Vs ZCB3YW50IF9GV19UUkFDRSgpIHdoaWNoIGlzIGEgYml0IG9mIGFuIGV5ZXNvcmUKaWYgdXNlZCBl eHRlbnNpdmVseSwgc28gYSBiZXR0ZXIgbmFtZSB3b3VsZCBiZSBuaWNlLiBBbGFzLApJJ3ZlIG5v dCB5ZXQgdGhvdWdodCBvZiBvbmUuCgpJIGd1ZXNzIEkgc2hvdWxkIGZpcnN0IGZpZ3VyZSBvdXQg aG93IG1hbnkgaW5zdGFuY2VzIG9mIGVhY2gKdHlwZSB0aGVyZSBhcmUuCgo+IE5ldmVydGhlbGVz cywKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ CgpUYS4gUHVzaGVkLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK