From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Push clear_intel_crtc_state()
 onto the heap
Date: Tue, 5 Feb 2019 21:10:39 +0200
Message-ID: <20190205191039.GY20097@intel.com>
References: <20190205091552.15750-1-chris@chris-wilson.co.uk>
 <20190205092759.16018-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0E6F16E148
 for <intel-gfx@lists.freedesktop.org>; Tue,  5 Feb 2019 19:10:44 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190205092759.16018-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBGZWIgMDUsIDIwMTkgYXQgMDk6Mjc6NTlBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IGNsZWFyX2ludGVsX2NydGNfc3RhdGUoKSB1c2VzIHRoZSBzdGFjayBmb3Igc2F2aW5n
IGEgdGVtcG9yYXJ5IGNvcHkgb2YKPiBjZXJ0YWluIGJpdHMgb2YgdGhlIGluaGVyaXRlZCBjcnRj
X3N0YXRlIGJlZm9yZSBjbGVhcmluZyB0aGUgdW53YW50ZWQKPiBiaXRzLiBUaGlzIHB1c2hlcyBp
dCBvdmVyIHRoZSBzdGFjayBsaW1pdCBmb3IgbXkgbGl0dGxlIDMyYiBQaW5ldmlldywKPiBzbyBt
b3ZlIHRoZSB0ZW1wb3JhcnkgYWxsb2NhdGlvbiB0byB0aGUgaGVhcCBpbnN0ZWFkLiBBcyB3ZSBu
b3cgdXNlIGEKPiB6ZXJvZWQgc3RydWN0LCB3ZSBjYW4gY29weSB0aGUgd2hvbGUgZXh0ZW5kZWQg
c3RhdGUgYmFjayB0byBib3RoCj4gcHJlc2VydmUgd2hhdCBiaXRzIG5lZWQgdG8gYmUgcHJlc2Vy
dmVkIGFuZCB6ZXJvIHRoZSByZXN0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8
Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kaXNwbGF5LmMgfCA0MCArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmls
ZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNjM2YjcwM2UwMmNiLi42ZWUwY2QyN2U4
NzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g
KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTExNDY4LDQ0
ICsxMTQ2OCwzOCBAQCBzdGF0aWMgYm9vbCBjaGVja19kaWdpdGFsX3BvcnRfY29uZmxpY3RzKHN0
cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4g
LXN0YXRpYyB2b2lkCj4gK3N0YXRpYyBpbnQKPiAgY2xlYXJfaW50ZWxfY3J0Y19zdGF0ZShzdHJ1
Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2ID0KPiAgCQl0b19pOTE1KGNydGNfc3RhdGUtPmJhc2UuY3J0Yy0+
ZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3NjYWxlcl9zdGF0ZSBzY2FsZXJfc3RhdGU7Cj4g
LQlzdHJ1Y3QgaW50ZWxfZHBsbF9od19zdGF0ZSBkcGxsX2h3X3N0YXRlOwo+IC0Jc3RydWN0IGlu
dGVsX3NoYXJlZF9kcGxsICpzaGFyZWRfZHBsbDsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjX3dtX3N0
YXRlIHdtX3N0YXRlOwo+IC0JYm9vbCBmb3JjZV90aHJ1LCBpcHNfZm9yY2VfZGlzYWJsZTsKPiAr
CXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpzYXZlZF9zdGF0ZTsKPiArCj4gKwlzYXZlZF9zdGF0
ZSA9IGt6YWxsb2Moc2l6ZW9mKCpzYXZlZF9zdGF0ZSksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFz
YXZlZF9zdGF0ZSkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gIAkvKiBGSVhNRTogYmVmb3Jl
IHRoZSBzd2l0Y2ggdG8gYXRvbWljIHN0YXJ0ZWQsIGEgbmV3IHBpcGVfY29uZmlnIHdhcwo+ICAJ
ICoga3phbGxvYydkLiBDb2RlIHRoYXQgZGVwZW5kcyBvbiBhbnkgZmllbGQgYmVpbmcgemVybyBz
aG91bGQgYmUKPiAgCSAqIGZpeGVkLCBzbyB0aGF0IHRoZSBjcnRjX3N0YXRlIGNhbiBiZSBzYWZl
bHkgZHVwbGljYXRlZC4gRm9yIG5vdywKPiAgCSAqIG9ubHkgZmllbGRzIHRoYXQgYXJlIGtub3cg
dG8gbm90IGNhdXNlIHByb2JsZW1zIGFyZSBwcmVzZXJ2ZWQuICovCj4gIAo+IC0Jc2NhbGVyX3N0
YXRlID0gY3J0Y19zdGF0ZS0+c2NhbGVyX3N0YXRlOwo+IC0Jc2hhcmVkX2RwbGwgPSBjcnRjX3N0
YXRlLT5zaGFyZWRfZHBsbDsKPiAtCWRwbGxfaHdfc3RhdGUgPSBjcnRjX3N0YXRlLT5kcGxsX2h3
X3N0YXRlOwo+IC0JZm9yY2VfdGhydSA9IGNydGNfc3RhdGUtPnBjaF9wZml0LmZvcmNlX3RocnU7
Cj4gLQlpcHNfZm9yY2VfZGlzYWJsZSA9IGNydGNfc3RhdGUtPmlwc19mb3JjZV9kaXNhYmxlOwo+
ICsJc2F2ZWRfc3RhdGUtPnNjYWxlcl9zdGF0ZSA9IGNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZTsK
PiArCXNhdmVkX3N0YXRlLT5zaGFyZWRfZHBsbCA9IGNydGNfc3RhdGUtPnNoYXJlZF9kcGxsOwo+
ICsJc2F2ZWRfc3RhdGUtPmRwbGxfaHdfc3RhdGUgPSBjcnRjX3N0YXRlLT5kcGxsX2h3X3N0YXRl
Owo+ICsJc2F2ZWRfc3RhdGUtPnBjaF9wZml0LmZvcmNlX3RocnUgPSBjcnRjX3N0YXRlLT5wY2hf
cGZpdC5mb3JjZV90aHJ1Owo+ICsJc2F2ZWRfc3RhdGUtPmlwc19mb3JjZV9kaXNhYmxlID0gY3J0
Y19zdGF0ZS0+aXBzX2ZvcmNlX2Rpc2FibGU7Cj4gIAlpZiAoSVNfRzRYKGRldl9wcml2KSB8fAo+
ICAJICAgIElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYp
KQo+IC0JCXdtX3N0YXRlID0gY3J0Y19zdGF0ZS0+d207Cj4gKwkJc2F2ZWRfc3RhdGUtPndtID0g
Y3J0Y19zdGF0ZS0+d207Cj4gIAo+ICAJLyogS2VlcCBiYXNlIGRybV9jcnRjX3N0YXRlIGludGFj
dCwgb25seSBjbGVhciBvdXIgZXh0ZW5kZWQgc3RydWN0ICovCj4gIAlCVUlMRF9CVUdfT04ob2Zm
c2V0b2Yoc3RydWN0IGludGVsX2NydGNfc3RhdGUsIGJhc2UpKTsKPiAtCW1lbXNldCgmY3J0Y19z
dGF0ZS0+YmFzZSArIDEsIDAsCj4gKwltZW1jcHkoJmNydGNfc3RhdGUtPmJhc2UgKyAxLCAmc2F2
ZWRfc3RhdGUtPmJhc2UgKyAxLAo+ICAJICAgICAgIHNpemVvZigqY3J0Y19zdGF0ZSkgLSBzaXpl
b2YoY3J0Y19zdGF0ZS0+YmFzZSkpOwo+ICAKPiAtCWNydGNfc3RhdGUtPnNjYWxlcl9zdGF0ZSA9
IHNjYWxlcl9zdGF0ZTsKPiAtCWNydGNfc3RhdGUtPnNoYXJlZF9kcGxsID0gc2hhcmVkX2RwbGw7
Cj4gLQljcnRjX3N0YXRlLT5kcGxsX2h3X3N0YXRlID0gZHBsbF9od19zdGF0ZTsKPiAtCWNydGNf
c3RhdGUtPnBjaF9wZml0LmZvcmNlX3RocnUgPSBmb3JjZV90aHJ1Owo+IC0JY3J0Y19zdGF0ZS0+
aXBzX2ZvcmNlX2Rpc2FibGUgPSBpcHNfZm9yY2VfZGlzYWJsZTsKPiAtCWlmIChJU19HNFgoZGV2
X3ByaXYpIHx8Cj4gLQkgICAgSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklF
VyhkZXZfcHJpdikpCj4gLQkJY3J0Y19zdGF0ZS0+d20gPSB3bV9zdGF0ZTsKCk5pY2UuIExlc3Mg
cmlzayBvZiBzb21lb25lIG1lc3NpbmcgdXAgdGhlIHNhdmUgdnMuIHJlc3RvcmUuCgpSZXZpZXdl
ZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4g
KwlrZnJlZShzYXZlZF9zdGF0ZSk7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGlu
dAo+IEBAIC0xMTUyMCw3ICsxMTUxNCw5IEBAIGludGVsX21vZGVzZXRfcGlwZV9jb25maWcoc3Ry
dWN0IGRybV9jcnRjICpjcnRjLAo+ICAJaW50IGk7Cj4gIAlib29sIHJldHJ5ID0gdHJ1ZTsKPiAg
Cj4gLQljbGVhcl9pbnRlbF9jcnRjX3N0YXRlKHBpcGVfY29uZmlnKTsKPiArCXJldCA9IGNsZWFy
X2ludGVsX2NydGNfc3RhdGUocGlwZV9jb25maWcpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4g
cmV0Owo+ICAKPiAgCXBpcGVfY29uZmlnLT5jcHVfdHJhbnNjb2RlciA9Cj4gIAkJKGVudW0gdHJh
bnNjb2RlcikgdG9faW50ZWxfY3J0YyhjcnRjKS0+cGlwZTsKPiAtLSAKPiAyLjIwLjEKCi0tIApW
aWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v
aW50ZWwtZ2Z4Cg==