From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Cfxk=QM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 89774C282CB
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 19:54:50 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4FA212080F
	for <netdev@archiver.kernel.org>; Tue,  5 Feb 2019 19:54:50 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AbN65+Ll"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729995AbfBETyt (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 5 Feb 2019 14:54:49 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:40010 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727280AbfBETyt (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 5 Feb 2019 14:54:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=jPCPH1wm4QdUCSigxLAnqliVUE1Hdoji0+tEgQAzlik=; b=AbN65+LlZOv4kmcaNF4rkRY+le
        mjKGOc8EgyH1Ljq9pwQiCIpOGBxrh8zbc89LpFFnBd5pNLsnPoFpnwc1h+QvJOyJnwT6PbVwY8Q12
        aUSSapx5c3KSXLo7AWFf7dV7rpi27QHlK/B0Pymy01xBcm8EFN5BpFaiWqIthlsU1XEg=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gr6nm-0002gM-Lv; Tue, 05 Feb 2019 20:54:38 +0100
Date:   Tue, 5 Feb 2019 20:54:38 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     John David Anglin <dave.anglin@bell.net>
Cc:     Russell King <linux@arm.linux.org.uk>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: Revise irq setup ordering
Message-ID: <20190205195438.GD3243@lunn.ch>
References: <2ea9fd81-f92d-9505-dd0b-bdd0f67d8ce7@bell.net>
 <20190130223846.GB30115@lunn.ch>
 <9415d82e-965b-7777-0ad0-f23d6c9f177e@bell.net>
 <a89d5296-88f3-4dde-74b3-25ad1791d5b6@bell.net>
 <53b49df8-53ed-704f-9197-230b18d83090@bell.net>
 <824d011b-3692-69c3-5e2c-58e950a80abf@bell.net>
 <20190204231410.GG3397@lunn.ch>
 <8d8123cc-60f0-e236-e496-0aacf735fceb@bell.net>
 <20190205022149.GA10838@lunn.ch>
 <964a7e63-82b5-1b21-830e-ec5c7f1eb917@bell.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <964a7e63-82b5-1b21-830e-ec5c7f1eb917@bell.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> My hunch is the second hunk of the original patch will fix this.

O.K.

But please fully explain how the race happens and how the fix fully
fixes it. I don't really want to add code which just makes the race
window smaller, but the race still happens. That helps nobody.

In the end, i think you will end up polling. If so, feel free to
submit a patch which makes the poll interval build time configurable.

       Andrew