From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857E6C282CB for ; Tue, 5 Feb 2019 21:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 505A8217D6 for ; Tue, 5 Feb 2019 21:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4Xp+hbgs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728131AbfBEV3g (ORCPT ); Tue, 5 Feb 2019 16:29:36 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40125 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfBEV3f (ORCPT ); Tue, 5 Feb 2019 16:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eLyj7HjtgzyBrVvOGEJtRaLQBr8uMoa1jrbSKoNcLpc=; b=4Xp+hbgsaYGwOd9/mvfhXAgm3l WcbCmSr8JFJ5jXihsDqk8UxJ1ajfskeODMZjKASUp/5lyvQmQcGiHZr9kV1vEn+W3KhVZ7IdBlqWs NNAKRKD5q2CENkOZO0BLkjQzCACup8t+GqEwS210xiy98qJkn/wWN0y7ZbQqlkwAniIg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gr8He-0003y6-BZ; Tue, 05 Feb 2019 22:29:34 +0100 Date: Tue, 5 Feb 2019 22:29:34 +0100 From: Andrew Lunn To: Christian Lamparter Cc: netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation Message-ID: <20190205212934.GF3243@lunn.ch> References: <20190204213555.26054-1-chunkeey@gmail.com> <24213401.HFHtFJUkrt@debian64> <20190205130935.GB28397@lunn.ch> <2630352.e1UqcK5yIU@debian64> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2630352.e1UqcK5yIU@debian64> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > For now, I added the DT binding update to the patch as well. > But if this is indeed the way to go, it'll get a separate patch. Hi Christian You need to be careful with the DT binding. You need to keep backwards compatible with it. An old DT blob needs to keep working. I don't think this is true with this change. Andrew