diff for duplicates of <20190206101211.253cfbd9.cohuck@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 475726c..c40a49a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,14 +9,14 @@ Sean Christopherson <sean.j.christopherson@intel.com> wrote: > possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that > the generation has changed so that it can invalidate all MMIO sptes in > case the effective MMIO generation has wrapped so as to avoid using a -> stale spte, e.g. a (very) old spte that was created with generation=0. +> stale spte, e.g. a (very) old spte that was created with generation==0. > > Given that the purpose of kvm_arch_memslots_updated() is to prevent > consuming stale entries, it needs to be called before the new generation > is propagated to memslots. Invalidating the MMIO sptes after updating > memslots means that there is a window where a vCPU could dereference > the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO -> spte that was created with (pre-wrap) generation=0. +> spte that was created with (pre-wrap) generation==0. > > Fixes: e59dbe09f8e6 ("KVM: Introduce kvm_arch_memslots_updated()") > Cc: <stable@vger.kernel.org> diff --git a/a/content_digest b/N1/content_digest index 02c2b6f..256c05f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020190205205443.1059-2-sean.j.christopherson@intel.com\0" "From\0Cornelia Huck <cohuck@redhat.com>\0" "Subject\0Re: [PATCH v2 01/27] KVM: Call kvm_arch_memslots_updated() before updating memslots\0" - "Date\0Wed, 06 Feb 2019 09:12:11 +0000\0" + "Date\0Wed, 6 Feb 2019 10:12:11 +0100\0" "To\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Cc\0linux-s390@vger.kernel.org" Janosch Frank <frankja@linux.ibm.com> @@ -31,14 +31,14 @@ "> possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that\n" "> the generation has changed so that it can invalidate all MMIO sptes in\n" "> case the effective MMIO generation has wrapped so as to avoid using a\n" - "> stale spte, e.g. a (very) old spte that was created with generation=0.\n" + "> stale spte, e.g. a (very) old spte that was created with generation==0.\n" "> \n" "> Given that the purpose of kvm_arch_memslots_updated() is to prevent\n" "> consuming stale entries, it needs to be called before the new generation\n" "> is propagated to memslots. Invalidating the MMIO sptes after updating\n" "> memslots means that there is a window where a vCPU could dereference\n" "> the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO\n" - "> spte that was created with (pre-wrap) generation=0.\n" + "> spte that was created with (pre-wrap) generation==0.\n" "> \n" "> Fixes: e59dbe09f8e6 (\"KVM: Introduce kvm_arch_memslots_updated()\")\n" "> Cc: <stable@vger.kernel.org>\n" @@ -59,4 +59,4 @@ "\n" Reviewed-by: Cornelia Huck <cohuck@redhat.com> -51bbb722c591a8e211c5d6061a54a4931606255bd9c9437faf85e6b5fb2783d1 +97913e05ce984e5980f6321efe0573d7936485f3378c13e33f18dc68fc2f6a18
diff --git a/a/1.txt b/N2/1.txt index 475726c..c40a49a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -9,14 +9,14 @@ Sean Christopherson <sean.j.christopherson@intel.com> wrote: > possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that > the generation has changed so that it can invalidate all MMIO sptes in > case the effective MMIO generation has wrapped so as to avoid using a -> stale spte, e.g. a (very) old spte that was created with generation=0. +> stale spte, e.g. a (very) old spte that was created with generation==0. > > Given that the purpose of kvm_arch_memslots_updated() is to prevent > consuming stale entries, it needs to be called before the new generation > is propagated to memslots. Invalidating the MMIO sptes after updating > memslots means that there is a window where a vCPU could dereference > the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO -> spte that was created with (pre-wrap) generation=0. +> spte that was created with (pre-wrap) generation==0. > > Fixes: e59dbe09f8e6 ("KVM: Introduce kvm_arch_memslots_updated()") > Cc: <stable@vger.kernel.org> diff --git a/a/content_digest b/N2/content_digest index 02c2b6f..d6e2330 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,22 +2,24 @@ "ref\020190205205443.1059-2-sean.j.christopherson@intel.com\0" "From\0Cornelia Huck <cohuck@redhat.com>\0" "Subject\0Re: [PATCH v2 01/27] KVM: Call kvm_arch_memslots_updated() before updating memslots\0" - "Date\0Wed, 06 Feb 2019 09:12:11 +0000\0" + "Date\0Wed, 6 Feb 2019 10:12:11 +0100\0" "To\0Sean Christopherson <sean.j.christopherson@intel.com>\0" - "Cc\0linux-s390@vger.kernel.org" + "Cc\0Paolo Bonzini <pbonzini@redhat.com>" + " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" + James Hogan <jhogan@kernel.org> + Paul Mackerras <paulus@ozlabs.org> + Christian Borntraeger <borntraeger@de.ibm.com> Janosch Frank <frankja@linux.ibm.com> - kvm@vger.kernel.org + Christoffer Dall <christoffer.dall@arm.com> Marc Zyngier <marc.zyngier@arm.com> - James Hogan <jhogan@kernel.org> David Hildenbrand <david@redhat.com> - kvm-ppc@vger.kernel.org + kvm@vger.kernel.org linux-mips@vger.kernel.org - Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> - Xiao Guangrong <guangrong.xiao@gmail.com> - Paolo Bonzini <pbonzini@redhat.com> + kvm-ppc@vger.kernel.org + linux-s390@vger.kernel.org + linux-arm-kernel@lists.infradead.org kvmarm@lists.cs.columbia.edu - " linux-arm-kernel@lists.infradead.org\0" + " Xiao Guangrong <guangrong.xiao@gmail.com>\0" "\00:1\0" "b\0" "On Tue, 5 Feb 2019 12:54:17 -0800\n" @@ -31,14 +33,14 @@ "> possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that\n" "> the generation has changed so that it can invalidate all MMIO sptes in\n" "> case the effective MMIO generation has wrapped so as to avoid using a\n" - "> stale spte, e.g. a (very) old spte that was created with generation=0.\n" + "> stale spte, e.g. a (very) old spte that was created with generation==0.\n" "> \n" "> Given that the purpose of kvm_arch_memslots_updated() is to prevent\n" "> consuming stale entries, it needs to be called before the new generation\n" "> is propagated to memslots. Invalidating the MMIO sptes after updating\n" "> memslots means that there is a window where a vCPU could dereference\n" "> the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO\n" - "> spte that was created with (pre-wrap) generation=0.\n" + "> spte that was created with (pre-wrap) generation==0.\n" "> \n" "> Fixes: e59dbe09f8e6 (\"KVM: Introduce kvm_arch_memslots_updated()\")\n" "> Cc: <stable@vger.kernel.org>\n" @@ -59,4 +61,4 @@ "\n" Reviewed-by: Cornelia Huck <cohuck@redhat.com> -51bbb722c591a8e211c5d6061a54a4931606255bd9c9437faf85e6b5fb2783d1 +15f66a4e6df7595a6b27d8b443e6a324d90846b1aefa25170d5d79de7cf91660
diff --git a/a/1.txt b/N3/1.txt index 475726c..9f39e30 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -9,14 +9,14 @@ Sean Christopherson <sean.j.christopherson@intel.com> wrote: > possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that > the generation has changed so that it can invalidate all MMIO sptes in > case the effective MMIO generation has wrapped so as to avoid using a -> stale spte, e.g. a (very) old spte that was created with generation=0. +> stale spte, e.g. a (very) old spte that was created with generation==0. > > Given that the purpose of kvm_arch_memslots_updated() is to prevent > consuming stale entries, it needs to be called before the new generation > is propagated to memslots. Invalidating the MMIO sptes after updating > memslots means that there is a window where a vCPU could dereference > the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO -> spte that was created with (pre-wrap) generation=0. +> spte that was created with (pre-wrap) generation==0. > > Fixes: e59dbe09f8e6 ("KVM: Introduce kvm_arch_memslots_updated()") > Cc: <stable@vger.kernel.org> @@ -36,3 +36,8 @@ Sean Christopherson <sean.j.christopherson@intel.com> wrote: Not an x86 person, but I think that makes sense. Reviewed-by: Cornelia Huck <cohuck@redhat.com> + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 02c2b6f..6ad4736 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,14 +2,16 @@ "ref\020190205205443.1059-2-sean.j.christopherson@intel.com\0" "From\0Cornelia Huck <cohuck@redhat.com>\0" "Subject\0Re: [PATCH v2 01/27] KVM: Call kvm_arch_memslots_updated() before updating memslots\0" - "Date\0Wed, 06 Feb 2019 09:12:11 +0000\0" + "Date\0Wed, 6 Feb 2019 10:12:11 +0100\0" "To\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Cc\0linux-s390@vger.kernel.org" Janosch Frank <frankja@linux.ibm.com> kvm@vger.kernel.org + " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" Marc Zyngier <marc.zyngier@arm.com> James Hogan <jhogan@kernel.org> David Hildenbrand <david@redhat.com> + Christoffer Dall <christoffer.dall@arm.com> kvm-ppc@vger.kernel.org linux-mips@vger.kernel.org Paul Mackerras <paulus@ozlabs.org> @@ -31,14 +33,14 @@ "> possible, if unlikely. kvm_arch_memslots_updated() alerts x86 that\n" "> the generation has changed so that it can invalidate all MMIO sptes in\n" "> case the effective MMIO generation has wrapped so as to avoid using a\n" - "> stale spte, e.g. a (very) old spte that was created with generation=0.\n" + "> stale spte, e.g. a (very) old spte that was created with generation==0.\n" "> \n" "> Given that the purpose of kvm_arch_memslots_updated() is to prevent\n" "> consuming stale entries, it needs to be called before the new generation\n" "> is propagated to memslots. Invalidating the MMIO sptes after updating\n" "> memslots means that there is a window where a vCPU could dereference\n" "> the new memslots generation, e.g. 0, and incorrectly reuse an old MMIO\n" - "> spte that was created with (pre-wrap) generation=0.\n" + "> spte that was created with (pre-wrap) generation==0.\n" "> \n" "> Fixes: e59dbe09f8e6 (\"KVM: Introduce kvm_arch_memslots_updated()\")\n" "> Cc: <stable@vger.kernel.org>\n" @@ -57,6 +59,11 @@ "\n" "Not an x86 person, but I think that makes sense.\n" "\n" - Reviewed-by: Cornelia Huck <cohuck@redhat.com> + "Reviewed-by: Cornelia Huck <cohuck@redhat.com>\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -51bbb722c591a8e211c5d6061a54a4931606255bd9c9437faf85e6b5fb2783d1 +3a9229f46f429cf9c534cdd48d0ebfc1d2a909b174aa417d35d560bcaf3178bd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.