From: Stephen Hemminger <stephen@networkplumber.org>
To: Marcos Antonio Moraes <marcos.antonio@digirati.com.br>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Using rates in bits when limits are specified in %
Date: Wed, 6 Feb 2019 10:51:26 -0800 [thread overview]
Message-ID: <20190206105126.0d147d72@hermes.lan> (raw)
In-Reply-To: <20190206180913.19381-1-marcos.antonio@digirati.com.br>
On Wed, 6 Feb 2019 16:09:13 -0200
Marcos Antonio Moraes <marcos.antonio@digirati.com.br> wrote:
> As /sys/class/net/<iface>/speed indicates a value in Mbits/sec, the
> transformation is necessary to create the correct limitations.
Not sure, if this is correct or not could you give an example?
This patch needs a signed-off-by and a a Fixes tag.
Also please put iproute2 in subject line:
[PATCH iproute2] tc: use bits not mbits/sec in rate percent.
Also, please rebase since I just found a memory leak in this function.
next prev parent reply other threads:[~2019-02-06 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 18:09 [PATCH] Using rates in bits when limits are specified in % Marcos Antonio Moraes
2019-02-06 18:51 ` Stephen Hemminger [this message]
2019-02-07 12:46 ` Marcos Antonio
-- strict thread matches above, loose matches on Subject: below --
2019-02-06 17:14 Marcos Antonio Moraes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206105126.0d147d72@hermes.lan \
--to=stephen@networkplumber.org \
--cc=marcos.antonio@digirati.com.br \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.