All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	David Ahern <dsahern@gmail.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Phil Sutter <phil@nwl.cc>, Eric Garver <egarver@redhat.com>,
	Tomas Dolezal <todoleza@redhat.com>,
	Lennert Buytenhek <buytenh@gnu.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script
Date: Wed, 6 Feb 2019 11:55:22 +0100	[thread overview]
Message-ID: <20190206115522.3843a125@redhat.com> (raw)
In-Reply-To: <20190205145033.5d90dc42@hermes.lan>

On Tue, 5 Feb 2019 14:50:33 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> Providing brctl or ifconfig scripts is possible, but it really should
> be put in a sample or demo directory and not installed by default.
> It would just cause too much pain to distributions.

On one hand, I did it this way exactly to make it easy for
distributions (after all, I work for a distributor). The rationale is
that it's easier to get rid of things from package scripts rather than
add them. Also implementing a Debian package diversion looked more
elegant this way. No idea about other ones though.

On the other hand, I didn't even think of adding that to examples/.
Maybe that would alleviate David's concern about having to maintain it
forever (if it breaks temporarily, or if we need to remove it for some
reason, it's not a drama).

> I love concise human readable output and hate long winded VMS style
> commands.

That's exactly where I feel the current tools included in iproute2 fall
rather short. Compare "brctl show" to the closest equivalent "IFS='
'
for b in $(ip -br link show type bridge); do ip -br link show type
bridge_slave master ${b%% *}; done".

Sure, as Roopa said, we could and should improve 'bridge', and by now
I'm even almost convinced it's doable without breaking the existing
syntax, but it's not something we're doing overnight.

-- 
Stefano

  reply	other threads:[~2019-02-06 10:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 17:00 [PATCH iproute2-next] Introduce ip-brctl shell script Stefano Brivio
2019-01-23 15:09 ` Nikolay Aleksandrov
2019-01-23 16:33   ` Roopa Prabhu
2019-01-25 10:05     ` Stefano Brivio
2019-01-28  5:08       ` Roopa Prabhu
2019-01-28  7:57         ` Stefano Brivio
2019-01-30 22:30           ` Roopa Prabhu
2019-01-31 12:46             ` Stefano Brivio
2019-01-31 16:28               ` Roopa Prabhu
2019-02-05 22:50                 ` Stephen Hemminger
2019-02-06 10:55                   ` Stefano Brivio [this message]
2019-01-25 10:04   ` Stefano Brivio
2019-01-30  4:51 ` David Ahern
2019-01-30 10:55   ` Stefano Brivio
2019-01-31  5:12     ` David Ahern
2019-01-31 12:46       ` Stefano Brivio
2019-01-31 12:49 ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206115522.3843a125@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=buytenh@gnu.org \
    --cc=dsahern@gmail.com \
    --cc=egarver@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=phil@nwl.cc \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=todoleza@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.