From: Jiri Pirko <jiri@resnulli.us>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@mellanox.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:MELLANOX MLX5 core VPI driver"
<linux-rdma@vger.kernel.org>,
"open list:NETRONOME ETHERNET DRIVERS"
<oss-drivers@netronome.com>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next v3 02/12] bnxt: Implement ndo_get_port_parent_id()
Date: Wed, 6 Feb 2019 13:59:44 +0100 [thread overview]
Message-ID: <20190206125944.GC2189@nanopsycho> (raw)
In-Reply-To: <20190205235326.14600-3-f.fainelli@gmail.com>
Wed, Feb 06, 2019 at 12:53:16AM CET, f.fainelli@gmail.com wrote:
>BNXT only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a
>great candidate to be converted to use the ndo_get_port_parent_id() NDO
>instead of implementing switchdev_port_attr_get(). The conversion is
>straight forward here since the PF and VF code use the same getter.
>
>Since bnxt makes uses of switchdev_port_same_parent_id() convert it to
>use netdev_port_same_parent_id().
>
>Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
[...]
>diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
>index c683b5e96b1d..170d2fbbb91b 100644
>--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
>+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
>@@ -12,6 +12,7 @@
> #include <linux/if_vlan.h>
> #include <net/flow_dissector.h>
> #include <net/pkt_cls.h>
>+#include <net/switchdev.h>
You don't need this. Looks like a leftover.
Otherwise, looks fine.
Acked-by: Jiri Pirko <jiri@mellanox.com>
> #include <net/tc_act/tc_gact.h>
> #include <net/tc_act/tc_skbedit.h>
> #include <net/tc_act/tc_mirred.h>
[...]
next prev parent reply other threads:[~2019-02-06 12:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 23:53 [Bridge] [PATCH net-next v3 00/12] net: Introduce ndo_get_port_parent_id() Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 01/12] " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 12:54 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 02/12] bnxt: Implement ndo_get_port_parent_id() Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 12:59 ` Jiri Pirko [this message]
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 03/12] liquidio: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:10 ` Jiri Pirko
2019-02-06 13:10 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 04/12] net/mlx5e: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:12 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 05/12] mlxsw: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:14 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 06/12] mscc: ocelot: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:16 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 07/12] nfp: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:23 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 08/12] rocker: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:23 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 09/12] netdevsim: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:24 ` Jiri Pirko
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 10/12] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 11/12] net: dsa: " Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:27 ` Jiri Pirko
2019-02-06 18:21 ` [Bridge] " Vivien Didelot
2019-02-06 18:21 ` Vivien Didelot
2019-02-06 18:21 ` Vivien Didelot
2019-02-05 23:53 ` [Bridge] [PATCH net-next v3 12/12] net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-05 23:53 ` Florian Fainelli
2019-02-06 13:34 ` Jiri Pirko
2019-02-06 7:51 ` [Bridge] [PATCH net-next v3 00/12] net: Introduce ndo_get_port_parent_id() Ido Schimmel
2019-02-06 7:51 ` Ido Schimmel
2019-02-06 14:24 ` [Bridge] " Ido Schimmel
2019-02-06 14:24 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206125944.GC2189@nanopsycho \
--to=jiri@resnulli.us \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.