From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
dev@dpdk.org
Subject: Re: [PATCH] net/mlx: support firmware version query
Date: Wed, 6 Feb 2019 14:27:26 -0800 [thread overview]
Message-ID: <20190206142726.7f5395cc@hermes.lan> (raw)
In-Reply-To: <1561267.IqWJBFvPPj@xps>
On Wed, 06 Feb 2019 23:23:07 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 06/02/2019 23:16, Stephen Hemminger:
> > On Wed, 6 Feb 2019 22:59:09 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > > The API function rte_eth_dev_fw_version_get() is querying drivers
> > > via the operation callback fw_version_get().
> > > The implementation of this operation is added for mlx4 and mlx5.
> > > Both functions are copying the same ibverbs field fw_ver
> > > which is retrieved when calling ibv_query_device[_ex]()
> > > during the port probing.
> > >
> > > It is tested with command "drvinfo" of examples/ethtool/.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Looks good, but hard to test because:
> > * testpmd doesn't report it
>
> Yes, good idea, we should do this query somewhere in testpmd.
> Can be a separate command or part of some other infos.
>
> > * with netvsc (and failsafe) the device is owned and not visible
> >
> > Fixing testpmd is not hard, but what is best way to handle
> > the nested device situation.
>
> I am not sure we want to expose such info via failsafe or bonding.
> If we are interested to know the underlying hardware, we should
> access directly to the nested device.
The nested devices are not visible in testpmd (or other
applications that iterate over ports).
next prev parent reply other threads:[~2019-02-06 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 21:59 [PATCH] net/mlx: support firmware version query Thomas Monjalon
2019-02-06 22:16 ` Stephen Hemminger
2019-02-06 22:23 ` Thomas Monjalon
2019-02-06 22:27 ` Stephen Hemminger [this message]
2019-02-06 22:25 ` [PATCH v2] " Thomas Monjalon
2019-02-10 15:11 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206142726.7f5395cc@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.