All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] ALSA: firewire: Remove superfluous snd_info_register() calls
Date: Wed, 6 Feb 2019 23:33:22 +0900	[thread overview]
Message-ID: <20190206143322.GA4337@workstation> (raw)
In-Reply-To: <20190205160527.8815-2-tiwai@suse.de>

Hi,

On Tue, Feb 05, 2019 at 05:05:25PM +0100, Takashi Iwai wrote:
> The calls of snd_info_register() are superfluous and should be avoided
> at the procfs creation time.  They are called at the end of the whole
> initialization via snd_card_register().  This patch drops such
> superfluous calls.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/firewire/bebob/bebob_proc.c         | 12 ++----------
>  sound/firewire/dice/dice-proc.c           | 12 ++----------
>  sound/firewire/digi00x/digi00x-proc.c     | 16 ++--------------
>  sound/firewire/fireface/ff-proc.c         | 12 ++----------
>  sound/firewire/fireworks/fireworks_proc.c | 12 ++----------
>  sound/firewire/motu/motu-proc.c           | 12 ++----------
>  sound/firewire/oxfw/oxfw-proc.c           | 12 ++----------
>  sound/firewire/tascam/tascam-proc.c       | 12 ++----------
>  8 files changed, 16 insertions(+), 84 deletions(-)

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
 

By the way, would I request you to sync alsa-utils repo in
git.alsa-project.org to the one in github.com? 9 patches
were applied to the latter, but never to the former.


Thanks

Takashi Sakamoto

  reply	other threads:[~2019-02-06 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 16:05 [PATCH 0/3] ALSA: Remove superfluous snd_info_register() calls Takashi Iwai
2019-02-05 16:05 ` [PATCH 1/3] ALSA: firewire: " Takashi Iwai
2019-02-06 14:33   ` Takashi Sakamoto [this message]
2019-02-06 15:38     ` Jaroslav Kysela
2019-02-06 17:13     ` Takashi Iwai
2019-02-05 16:05 ` [PATCH 2/3] ALSA: opl4: " Takashi Iwai
2019-02-05 16:05 ` [PATCH 3/3] ALSA: emux: " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206143322.GA4337@workstation \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.