From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Julien Freche <jfreche@vmware.com>
Subject: Re: [PATCH 1/6] vmw_balloon: bump version number
Date: Wed, 6 Feb 2019 17:42:45 +0100 [thread overview]
Message-ID: <20190206164245.GA8466@kroah.com> (raw)
In-Reply-To: <20190206051336.2425-2-namit@vmware.com>
On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
> Following recent changes.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> drivers/misc/vmw_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index f8240b87df22..7294f305753f 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -34,7 +34,7 @@
>
> MODULE_AUTHOR("VMware, Inc.");
> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> -MODULE_VERSION("1.5.0.0-k");
> +MODULE_VERSION("1.6.0.0-k");
Please just drop this pointless line, it means nothing and is always out
of date. It's been removed from many other drivers, and I really don't
want to see it come back.
Your driver "version" is the kernel version, full stop. That's all you
need to ever worry about.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-06 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 5:13 [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker Nadav Amit
2019-02-06 5:13 ` [PATCH 1/6] vmw_balloon: bump version number Nadav Amit
2019-02-06 16:42 ` Greg Kroah-Hartman [this message]
2019-02-06 20:39 ` Nadav Amit
2019-02-06 21:06 ` Greg Kroah-Hartman
2019-02-06 22:17 ` Nadav Amit
2019-02-06 17:52 ` [PATCH 0/6] vmw_balloon: 64-bit limit support, compaction, shrinker Michael S. Tsirkin
2019-02-06 18:05 ` Nadav Amit
2019-02-06 17:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206164245.GA8466@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jfreche@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.