From: Julien Gomes <julien@arista.com>
To: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, marcelo.leitner@gmail.com,
nhorman@tuxdriver.com, vyasevich@gmail.com, lucien.xin@gmail.com,
Julien Gomes <julien@arista.com>
Subject: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length
Date: Wed, 06 Feb 2019 20:14:30 +0000 [thread overview]
Message-ID: <20190206201430.18830-1-julien@arista.com> (raw)
Make sctp_setsockopt_events() able to accept sctp_event_subscribe
structures longer than the current definitions.
This should prevent unjustified setsockopt() failures due to struct
sctp_event_subscribe extensions (as in 4.11 and 4.12) when using
binaries that should be compatible, but were built with later kernel
uapi headers.
Signed-off-by: Julien Gomes <julien@arista.com>
---
net/sctp/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 9644bdc8e85c..f9717e2789da 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -2311,7 +2311,7 @@ static int sctp_setsockopt_events(struct sock *sk, char __user *optval,
int i;
if (optlen > sizeof(struct sctp_event_subscribe))
- return -EINVAL;
+ optlen = sizeof(struct sctp_event_subscribe);
if (copy_from_user(&subscribe, optval, optlen))
return -EFAULT;
--
2.20.1
next reply other threads:[~2019-02-06 20:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 20:14 Julien Gomes [this message]
2019-02-06 20:37 ` [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length Marcelo Ricardo Leitner
2019-02-06 20:48 ` Julien Gomes
2019-02-06 21:07 ` Marcelo Ricardo Leitner
2019-02-06 21:23 ` Neil Horman
2019-02-06 21:48 ` Julien Gomes
2019-02-07 14:44 ` Neil Horman
2019-02-06 21:26 ` Julien Gomes
2019-02-06 21:39 ` Neil Horman
2019-02-06 21:48 ` Julien Gomes
2019-02-06 21:53 ` Julien Gomes
2019-02-07 14:48 ` Neil Horman
2019-02-07 17:33 ` David Laight
2019-02-07 17:47 ` 'Marcelo Ricardo Leitner'
2019-02-08 9:53 ` David Laight
2019-02-08 12:36 ` Neil Horman
2019-02-06 21:08 ` Neil Horman
2019-02-06 21:18 ` Marcelo Ricardo Leitner
2019-02-09 23:12 ` David Miller
2019-02-10 12:46 ` Marcelo Ricardo Leitner
2019-02-10 20:15 ` Marcelo Ricardo Leitner
2019-02-13 16:17 ` David Laight
2019-02-13 17:23 ` 'Marcelo Ricardo Leitner'
2019-02-11 15:04 ` Neil Horman
2019-02-11 17:05 ` Marcelo Ricardo Leitner
2019-02-06 20:49 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206201430.18830-1-julien@arista.com \
--to=julien@arista.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.