From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c From: mdf@kernel.org Message-Id: <20190206223846.GA22321@archbook> Date: Wed, 6 Feb 2019 14:38:46 -0800 To: Andrew Lunn Cc: Moritz Fischer , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, colin.king@canonical.com, linus.walleij@linaro.org, yuehaibing@huawei.com, mcgrof@kernel.org, frowand.list@gmail.com, robh+dt@kernel.org, UNGLinuxDriver@microchip.com, woojung.huh@microchip.com, hkallweit1@gmail.com, davem@davemloft.net, f.fainelli@gmail.com, vivien.didelot@gmail.com, moritz@ettus.com, alex.williams@ni.com List-ID: SGkgQW5kcmV3LAoKdGhhbmtzIGZvciB5b3VyIGZlZWRiYWNrLgoKT24gV2VkLCBGZWIgMDYsIDIw MTkgYXQgMTA6NTM6MjJQTSArMDEwMCwgQW5kcmV3IEx1bm4gd3JvdGU6Cj4gT24gV2VkLCBGZWIg MDYsIDIwMTkgYXQgMTI6NTE6MDZQTSAtMDgwMCwgTW9yaXR6IEZpc2NoZXIgd3JvdGU6Cj4gPiBN b3ZlIHRoZSBEVCBiYXNlZCBsaW5rIEdQSU8gcGFyc2luZyB0byBvZl9tZGlvIGFuZCBsZXQgdGhl IHBsYWNlcwo+ID4gdGhhdCByZWdpc3RlciBhIGZpeGVkX3BoeSBwYXNzIGluIGEgR1BJTyBkZXNj cmlwdG9yIG9yIE5VTEwuCj4gPiAKPiA+IFRoaXMgYWxsb3dzIGZpeGVkX3BoeSBvbiBub24tRFQg cGxhdGZvcm1zIHRvIGhhdmUgbGluayBHUElPcywgdG9vLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5 OiBNb3JpdHogRmlzY2hlciA8bWRmQGtlcm5lbC5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL25l dC9kc2EvZHNhX2xvb3AuYyAgICAgICAgICAgICAgICAgICB8ICAyICstCj4gPiAgZHJpdmVycy9u ZXQvZXRoZXJuZXQvYnJvYWRjb20vYmdtYWMuYyAgICAgICAgfCAgMiArLQo+ID4gIGRyaXZlcnMv bmV0L2V0aGVybmV0L2Jyb2FkY29tL2dlbmV0L2JjbW1paS5jIHwgIDIgKy0KPiA+ICBkcml2ZXJz L25ldC9waHkvZml4ZWRfcGh5LmMgICAgICAgICAgICAgICAgICB8IDQ4ICsrLS0tLS0tLS0tLS0t LS0tLS0tCj4gPiAgZHJpdmVycy9uZXQvdXNiL2xhbjc4eHguYyAgICAgICAgICAgICAgICAgICAg fCAgMiArLQo+ID4gIGRyaXZlcnMvb2Yvb2ZfbWRpby5jICAgICAgICAgICAgICAgICAgICAgICAg IHwgMTUgKysrKystCj4gPiAgaW5jbHVkZS9saW51eC9waHlfZml4ZWQuaCAgICAgICAgICAgICAg ICAgICAgfCAgMyArLQo+ID4gIDcgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgNTEg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9kc2EvZHNhX2xv b3AuYyBiL2RyaXZlcnMvbmV0L2RzYS9kc2FfbG9vcC5jCj4gPiBpbmRleCAxNzQ4MmFlMDlhYTUu LjdmMTI0YzYyMDA5MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbmV0L2RzYS9kc2FfbG9vcC5j Cj4gPiArKysgYi9kcml2ZXJzL25ldC9kc2EvZHNhX2xvb3AuYwo+ID4gQEAgLTM0Myw3ICszNDMs NyBAQCBzdGF0aWMgaW50IF9faW5pdCBkc2FfbG9vcF9pbml0KHZvaWQpCj4gPiAgCXVuc2lnbmVk IGludCBpOwo+ID4gIAo+ID4gIAlmb3IgKGkgPSAwOyBpIDwgTlVNX0ZJWEVEX1BIWVM7IGkrKykK PiA+IC0JCXBoeWRldnNbaV0gPSBmaXhlZF9waHlfcmVnaXN0ZXIoUEhZX1BPTEwsICZzdGF0dXMs IE5VTEwpOwo+ID4gKwkJcGh5ZGV2c1tpXSA9IGZpeGVkX3BoeV9yZWdpc3RlcihQSFlfUE9MTCwg JnN0YXR1cywgTlVMTCwgTlVMTCk7Cj4gPiAgCj4gPiAgCXJldHVybiBtZGlvX2RyaXZlcl9yZWdp c3RlcigmZHNhX2xvb3BfZHJ2KTsKPiA+ICB9Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQv ZXRoZXJuZXQvYnJvYWRjb20vYmdtYWMuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2Jyb2FkY29t L2JnbWFjLmMKPiA+IGluZGV4IDQ2MzJkZDVkYmFkMS4uYmNlNjQ0ZGVjNWMyIDEwMDY0NAo+ID4g LS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvYnJvYWRjb20vYmdtYWMuYwo+ID4gKysrIGIvZHJp dmVycy9uZXQvZXRoZXJuZXQvYnJvYWRjb20vYmdtYWMuYwo+ID4gQEAgLTE0NDYsNyArMTQ0Niw3 IEBAIGludCBiZ21hY19waHlfY29ubmVjdF9kaXJlY3Qoc3RydWN0IGJnbWFjICpiZ21hYykKPiA+ ICAJc3RydWN0IHBoeV9kZXZpY2UgKnBoeV9kZXY7Cj4gPiAgCWludCBlcnI7Cj4gPiAgCj4gPiAt CXBoeV9kZXYgPSBmaXhlZF9waHlfcmVnaXN0ZXIoUEhZX1BPTEwsICZmcGh5X3N0YXR1cywgTlVM TCk7Cj4gPiArCXBoeV9kZXYgPSBmaXhlZF9waHlfcmVnaXN0ZXIoUEhZX1BPTEwsICZmcGh5X3N0 YXR1cywgTlVMTCwgTlVMTCk7Cj4gPiAgCWlmICghcGh5X2RldiB8fCBJU19FUlIocGh5X2Rldikp IHsKPiA+ICAJCWRldl9lcnIoYmdtYWMtPmRldiwgIkZhaWxlZCB0byByZWdpc3RlciBmaXhlZCBQ SFkgZGV2aWNlXG4iKTsKPiA+ICAJCXJldHVybiAtRU5PREVWOwo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L2V0aGVybmV0L2Jyb2FkY29tL2dlbmV0L2JjbW1paS5jIGIvZHJpdmVycy9uZXQv ZXRoZXJuZXQvYnJvYWRjb20vZ2VuZXQvYmNtbWlpLmMKPiA+IGluZGV4IDUxODgwZDgzMTMxYS4u N2NiZDczN2FiYTgwIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvYnJvYWRj b20vZ2VuZXQvYmNtbWlpLmMKPiA+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2Jyb2FkY29t L2dlbmV0L2JjbW1paS5jCj4gPiBAQCAtNTI1LDcgKzUyNSw3IEBAIHN0YXRpYyBpbnQgYmNtZ2Vu ZXRfbWlpX3BkX2luaXQoc3RydWN0IGJjbWdlbmV0X3ByaXYgKnByaXYpCj4gPiAgCQkJLmFzeW1f cGF1c2UgPSAwLAo+ID4gIAkJfTsKPiA+ICAKPiA+IC0JCXBoeWRldiA9IGZpeGVkX3BoeV9yZWdp c3RlcihQSFlfUE9MTCwgJmZwaHlfc3RhdHVzLCBOVUxMKTsKPiA+ICsJCXBoeWRldiA9IGZpeGVk X3BoeV9yZWdpc3RlcihQSFlfUE9MTCwgJmZwaHlfc3RhdHVzLCBOVUxMLCBOVUxMKTsKPiA+ICAJ CWlmICghcGh5ZGV2IHx8IElTX0VSUihwaHlkZXYpKSB7Cj4gPiAgCQkJZGV2X2VycihrZGV2LCAi ZmFpbGVkIHRvIHJlZ2lzdGVyIGZpeGVkIFBIWSBkZXZpY2VcbiIpOwo+ID4gIAkJCXJldHVybiAt RU5PREVWOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3BoeS9maXhlZF9waHkuYyBiL2Ry aXZlcnMvbmV0L3BoeS9maXhlZF9waHkuYwo+ID4gaW5kZXggZDgxMGY5MTRhYWE0Li44NDViZDdj MjA2NWEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL25ldC9waHkvZml4ZWRfcGh5LmMKPiA+ICsr KyBiL2RyaXZlcnMvbmV0L3BoeS9maXhlZF9waHkuYwo+ID4gQEAgLTE4LDYgKzE4LDcgQEAKPiA+ ICAjaW5jbHVkZSA8bGludXgvZXJyLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiA+ ICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvb2ZfbWRpby5oPgo+ ID4gICNpbmNsdWRlIDxsaW51eC9ncGlvL2NvbnN1bWVyLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4 L3NlcWxvY2suaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvaWRyLmg+Cj4gPiBAQCAtMTkxLDUwICsx OTIsMTIgQEAgc3RhdGljIHZvaWQgZml4ZWRfcGh5X2RlbChpbnQgcGh5X2FkZHIpCj4gPiAgCX0K PiA+ICB9Cj4gPiAgCj4gPiAtI2lmZGVmIENPTkZJR19PRl9HUElPCj4gPiAtc3RhdGljIHN0cnVj dCBncGlvX2Rlc2MgKmZpeGVkX3BoeV9nZXRfZ3Bpb2Qoc3RydWN0IGRldmljZV9ub2RlICpucCkK PiA+IC17Cj4gPiAtCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZml4ZWRfbGlua19ub2RlOwo+ID4gLQlz dHJ1Y3QgZ3Bpb19kZXNjICpncGlvZDsKPiA+IC0KPiA+IC0JaWYgKCFucCkKPiA+IC0JCXJldHVy biBOVUxMOwo+ID4gLQo+ID4gLQlmaXhlZF9saW5rX25vZGUgPSBvZl9nZXRfY2hpbGRfYnlfbmFt ZShucCwgImZpeGVkLWxpbmsiKTsKPiA+IC0JaWYgKCFmaXhlZF9saW5rX25vZGUpCj4gPiAtCQly ZXR1cm4gTlVMTDsKPiA+IC0KPiA+IC0JLyoKPiA+IC0JICogQXMgdGhlIGZpeGVkIGxpbmsgaXMg anVzdCBhIGRldmljZSB0cmVlIG5vZGUgd2l0aG91dCBhbnkKPiA+IC0JICogTGludXggZGV2aWNl IGFzc29jaWF0ZWQgd2l0aCBpdCwgd2Ugc2ltcGx5IGhhdmUgb2J0YWluCj4gPiAtCSAqIHRoZSBH UElPIGRlc2NyaXB0b3IgZnJvbSB0aGUgZGV2aWNlIHRyZWUgbGlrZSB0aGlzLgo+ID4gLQkgKi8K PiA+IC0JZ3Bpb2QgPSBncGlvZF9nZXRfZnJvbV9vZl9ub2RlKGZpeGVkX2xpbmtfbm9kZSwgImxp bmstZ3Bpb3MiLCAwLAo+ID4gLQkJCQkgICAgICAgR1BJT0RfSU4sICJtZGlvIik7Cj4gPiAtCW9m X25vZGVfcHV0KGZpeGVkX2xpbmtfbm9kZSk7Cj4gPiAtCWlmIChJU19FUlIoZ3Bpb2QpKSB7Cj4g PiAtCQlpZiAoUFRSX0VSUihncGlvZCkgPT0gLUVQUk9CRV9ERUZFUikKPiA+IC0JCQlyZXR1cm4g Z3Bpb2Q7Cj4gPiAtCQlwcl9lcnIoImVycm9yIGdldHRpbmcgR1BJTyBmb3IgZml4ZWQgbGluayAl cE9GLCBwcm9jZWVkIHdpdGhvdXRcbiIsCj4gPiAtCQkgICAgICAgZml4ZWRfbGlua19ub2RlKTsK PiA+IC0JCWdwaW9kID0gTlVMTDsKPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gZ3Bpb2Q7Cj4g PiAtfQo+ID4gLSNlbHNlCj4gPiAtc3RhdGljIHN0cnVjdCBncGlvX2Rlc2MgKmZpeGVkX3BoeV9n ZXRfZ3Bpb2Qoc3RydWN0IGRldmljZV9ub2RlICpucCkKPiA+IC17Cj4gPiAtCXJldHVybiBOVUxM Owo+ID4gLX0KPiA+IC0jZW5kaWYKPiA+IC0KPiA+ICBzdHJ1Y3QgcGh5X2RldmljZSAqZml4ZWRf cGh5X3JlZ2lzdGVyKHVuc2lnbmVkIGludCBpcnEsCj4gPiAgCQkJCSAgICAgIHN0cnVjdCBmaXhl ZF9waHlfc3RhdHVzICpzdGF0dXMsCj4gPiAtCQkJCSAgICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAq bnApCj4gPiArCQkJCSAgICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAsCj4gPiArCQkJCSAgICAg IHN0cnVjdCBncGlvX2Rlc2MgKmdwaW9kKQo+ID4gIHsKPiA+ICAJc3RydWN0IGZpeGVkX21kaW9f YnVzICpmbWIgPSAmcGxhdGZvcm1fZm1iOwo+ID4gLQlzdHJ1Y3QgZ3Bpb19kZXNjICpncGlvZCA9 IE5VTEw7Cj4gPiAgCXN0cnVjdCBwaHlfZGV2aWNlICpwaHk7Cj4gPiAgCWludCBwaHlfYWRkcjsK PiA+ICAJaW50IHJldDsKPiA+IEBAIC0yNDIsMTEgKzIwNSw2IEBAIHN0cnVjdCBwaHlfZGV2aWNl ICpmaXhlZF9waHlfcmVnaXN0ZXIodW5zaWduZWQgaW50IGlycSwKPiA+ICAJaWYgKCFmbWItPm1p aV9idXMgfHwgZm1iLT5taWlfYnVzLT5zdGF0ZSAhPSBNRElPQlVTX1JFR0lTVEVSRUQpCj4gPiAg CQlyZXR1cm4gRVJSX1BUUigtRVBST0JFX0RFRkVSKTsKPiA+ICAKPiA+IC0JLyogQ2hlY2sgaWYg d2UgaGF2ZSBhIEdQSU8gYXNzb2NpYXRlZCB3aXRoIHRoaXMgZml4ZWQgcGh5ICovCj4gPiAtCWdw aW9kID0gZml4ZWRfcGh5X2dldF9ncGlvZChucCk7Cj4gPiAtCWlmIChJU19FUlIoZ3Bpb2QpKQo+ ID4gLQkJcmV0dXJuIEVSUl9DQVNUKGdwaW9kKTsKPiA+IC0KPiA+ICAJLyogR2V0IHRoZSBuZXh0 IGF2YWlsYWJsZSBQSFkgYWRkcmVzcywgdXAgdG8gUEhZX01BWF9BRERSICovCj4gPiAgCXBoeV9h ZGRyID0gaWRhX3NpbXBsZV9nZXQoJnBoeV9maXhlZF9pZGEsIDAsIFBIWV9NQVhfQUREUiwgR0ZQ X0tFUk5FTCk7Cj4gPiAgCWlmIChwaHlfYWRkciA8IDApCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9uZXQvdXNiL2xhbjc4eHguYyBiL2RyaXZlcnMvbmV0L3VzYi9sYW43OHh4LmMKPiA+IGluZGV4 IDNkOTJlYTZmY2MwMi4uYmQ4OGYwYWVmMmZhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9uZXQv dXNiL2xhbjc4eHguYwo+ID4gKysrIGIvZHJpdmVycy9uZXQvdXNiL2xhbjc4eHguYwo+ID4gQEAg LTIwNTEsNyArMjA1MSw3IEBAIHN0YXRpYyBzdHJ1Y3QgcGh5X2RldmljZSAqbGFuNzgwMV9waHlf aW5pdChzdHJ1Y3QgbGFuNzh4eF9uZXQgKmRldikKPiA+ICAJcGh5ZGV2ID0gcGh5X2ZpbmRfZmly c3QoZGV2LT5tZGlvYnVzKTsKPiA+ICAJaWYgKCFwaHlkZXYpIHsKPiA+ICAJCW5ldGRldl9kYmco ZGV2LT5uZXQsICJQSFkgTm90IEZvdW5kISEgUmVnaXN0ZXJpbmcgRml4ZWQgUEhZXG4iKTsKPiA+ IC0JCXBoeWRldiA9IGZpeGVkX3BoeV9yZWdpc3RlcihQSFlfUE9MTCwgJmZwaHlfc3RhdHVzLCBO VUxMKTsKPiA+ICsJCXBoeWRldiA9IGZpeGVkX3BoeV9yZWdpc3RlcihQSFlfUE9MTCwgJmZwaHlf c3RhdHVzLCBOVUxMLCBOVUxMKTsKPiA+ICAJCWlmIChJU19FUlIocGh5ZGV2KSkgewo+ID4gIAkJ CW5ldGRldl9lcnIoZGV2LT5uZXQsICJObyBQSFkvZml4ZWRfUEhZIGZvdW5kXG4iKTsKPiA+ICAJ CQlyZXR1cm4gTlVMTDsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29mL29mX21kaW8uYyBiL2Ry aXZlcnMvb2Yvb2ZfbWRpby5jCj4gPiBpbmRleCBkZTYxNTczNTdlMjYuLjZiZTIxMjBiNWYwMyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvb2Yvb2ZfbWRpby5jCj4gPiArKysgYi9kcml2ZXJzL29m L29mX21kaW8uYwo+ID4gQEAgLTIwLDYgKzIwLDcgQEAKPiA+ICAjaW5jbHVkZSA8bGludXgvb2Zf bWRpby5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC9vZl9uZXQuaD4KPiA+ICAjaW5jbHVkZSA8bGlu dXgvbW9kdWxlLmg+Cj4gPiArI2luY2x1ZGUgPGxpbnV4L2dwaW8vY29uc3VtZXIuaD4KPiA+ICAK PiA+ICAjZGVmaW5lIERFRkFVTFRfR1BJT19SRVNFVF9ERUxBWQkxMAkvKiBpbiBtaWNyb3NlY29u ZHMgKi8KPiA+ICAKPiA+IEBAIC00NjAsNiArNDYxLDcgQEAgaW50IG9mX3BoeV9yZWdpc3Rlcl9m aXhlZF9saW5rKHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gPiAgewo+ID4gIAlzdHJ1Y3QgZml4 ZWRfcGh5X3N0YXR1cyBzdGF0dXMgPSB7fTsKPiA+ICAJc3RydWN0IGRldmljZV9ub2RlICpmaXhl ZF9saW5rX25vZGU7Cj4gPiArCXN0cnVjdCBncGlvX2Rlc2MgKmdwaW9kID0gTlVMTDsKPiA+ICAJ dTMyIGZpeGVkX2xpbmtfcHJvcFs1XTsKPiA+ICAJY29uc3QgY2hhciAqbWFuYWdlZDsKPiA+ICAK PiA+IEBAIC00ODMsNyArNDg1LDE3IEBAIGludCBvZl9waHlfcmVnaXN0ZXJfZml4ZWRfbGluayhz dHJ1Y3QgZGV2aWNlX25vZGUgKm5wKQo+ID4gIAkJc3RhdHVzLnBhdXNlID0gb2ZfcHJvcGVydHlf cmVhZF9ib29sKGZpeGVkX2xpbmtfbm9kZSwgInBhdXNlIik7Cj4gPiAgCQlzdGF0dXMuYXN5bV9w YXVzZSA9IG9mX3Byb3BlcnR5X3JlYWRfYm9vbChmaXhlZF9saW5rX25vZGUsCj4gPiAgCQkJCQkJ CSAgImFzeW0tcGF1c2UiKTsKPiA+ICsKPiA+ICsJCWdwaW9kID0gZ3Bpb2RfZ2V0X2Zyb21fb2Zf bm9kZShmaXhlZF9saW5rX25vZGUsICJsaW5rLWdwaW9zIiwgMCwKPiA+ICsJCQkJICAgICAgIEdQ SU9EX0lOLCAibWRpbyIpOwo+ID4gIAkJb2Zfbm9kZV9wdXQoZml4ZWRfbGlua19ub2RlKTsKPiA+ ICsJCWlmIChJU19FUlIoZ3Bpb2QpKSB7Cj4gPiArCQkJaWYgKFBUUl9FUlIoZ3Bpb2QpID09IC1F UFJPQkVfREVGRVIpCj4gPiArCQkJCXJldHVybiBQVFJfRVJSKGdwaW9kKTsKPiA+ICsJCQlwcl9l cnIoImVycm9yIGdldHRpbmcgR1BJTyBmb3IgZml4ZWQgbGluayAlcE9GLCBwcm9jZWVkIHdpdGhv dXRcbiIsCj4gPiArCQkJICAgICAgIGZpeGVkX2xpbmtfbm9kZSk7Cj4gPiArCQkJZ3Bpb2QgPSBO VUxMOwo+ID4gIGV4dGVybiBzdHJ1Y3QgcGh5X2RldmljZSAqZml4ZWRfcGh5X3JlZ2lzdGVyKHVu c2lnbmVkIGludCBpcnEsCj4gPiAgCQkJCQkgICAgIHN0cnVjdCBmaXhlZF9waHlfc3RhdHVzICpz dGF0dXMsCj4gPiAtCQkJCQkgICAgIHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApOwo+ID4gKwkJCQkJ ICAgICBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wLAo+ID4gKwkJCQkJICAgICBzdHJ1Y3QgZ3Bpb19k ZXNjICpncGlvZCk7Cj4gCj4gSGkgTW9yaXR6Cj4gCj4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0 ZXIgdG8gYWRkIGEgCj4gCj4gZXh0ZXJuIHN0cnVjdCBwaHlfZGV2aWNlICpmaXhlZF9waHlfcmVn aXN0ZXJfZ3Bpb2QodW5zaWduZWQgaW50IGlycSwKPiAgICAgIAkJCQkJICAgICBzdHJ1Y3QgZml4 ZWRfcGh5X3N0YXR1cyAqc3RhdHVzLAo+IAkJCQkJICAgICBzdHJ1Y3QgZ3Bpb19kZXNjICpncGlv ZCk7Cj4gCj4gSWYgeW91IGFyZSBub3QgdXNpbmcgRFQsIHRoZSBucCBpcyBwb2ludGxlc3MuIFNv IGxldHMga2VlcCB0aGUgQVBJCj4gc2ltcGxlLgoKVG8gY2xhcmlmeTogRG8geW91IGFncmVlIHdp dGggbW92aW5nIHRoZSBwYXJzaW5nIHRvIG9mX21kaW8sIG9yIGRvIHlvdQp3YW50IHRvIGtlZXAg dGhlIHBhcnNpbmcgYXMgaXQgd2FzIGFuZCBqdXN0IGFkZCBhbiBhZGRpdGlvbmFsIGZ1bmN0aW9u LgoKSW4gdGhlIGxhdHRlciBjYXNlIHlvdSdkIGhhdmUgYQpzdGF0aWMgc3RydWN0IHBoeV9kZXZp Y2UgKl9fZml4ZWRfcGh5X3JlZ2lzdGVyKHVuc2lnbmVkIGludCBpcnEsCgkJCQkJICAgICAgIHN0 cnVjdCBmaXhlZF9waHlfc3RhdHVzICpzdGF0dXMsCgkJCQkJICAgICAgIHN0cnVjdCBkZXZpY2Vf bm9kZSAqbnAsCgkJCQkJICAgICAgIHN0cnVjdCBncGlvX2Rlc2MgKmdwaW9kKQp7CmlmIChncGlv ZCkKICAgdXNlIHRoYXQKZWxzZQogICBvbGQgYmVoYXZpb3IgLyBzY2FuIGR0Pwp9CgpUaGF0IHdl IHRoZW4gY2FsbCBmcm9tIGZpeGVkX3BoeV9yZWdpc3Rlcl9ncGlvZCgpIHdpdGggYSBucCBvZiBO VUxMLAphbmQgZnJvbSBmaXhlZF9waHlfcmVnaXN0ZXIoKSB3aXRoIGEgZ3Bpb2Qgb2YgTlVMTD8K ClRoYW5rcywKCk1vcml0ego= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81E3C169C4 for ; Wed, 6 Feb 2019 22:38:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AE09218B0 for ; Wed, 6 Feb 2019 22:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549492730; bh=Y3uDLBjXA0Bs7TrZ/pCQV51xaf3LfGTiDfnCRwXHUf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RUJydfjbP+A0Oj//VilzdeCNlyT+AQJvTg38L/iOf8F9B42NsF/7T0nRsknZPtsbK 4WcY33NnQNZFH7vmURJw35fySZGanzuXU/JBfQ+Vx3cAsngHa7S2+m/zP3KD8GvvmF oWDMr1juoTIo48GZK0mheyu6DJ9kf4BFOXrGdu/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbfBFWit (ORCPT ); Wed, 6 Feb 2019 17:38:49 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:38778 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfBFWit (ORCPT ); Wed, 6 Feb 2019 17:38:49 -0500 Received: by mail-ot1-f68.google.com with SMTP id e12so14967147otl.5 for ; Wed, 06 Feb 2019 14:38:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KyhrdRvQwOtWPLNfIx/wwb2zcG6kJ+tUhgnWfDCG6d8=; b=D6Uiz7446P54R6zftoXWOh/qchohp6WFTKjrwnsFVp7qTVwRALA+2QtFhN3Otu1Lpe sOPbswUX+otbtM02HwWXSr3MOCxW6V6pBfmU6oOWwa7Y3sYKYrU9EAPBFcCzxCPszhPd Jnm9umvsHg0gVC1UJVjIO6GZzKNsDiG8tbiammtfz1Y8Do2h+DHECy5gAIAXcaz5RAk2 8MxAsieNCnGN64dr6oyTQz8eVkSO5J/pOf+9sZTl49ZPLYrRd1pEOzo8RoLbfXqybFuC KNjIC0loUh89bP0jyJbc2TtP84I+udw1+REQVdoWnxxOqR3mLPceU1G8hipnR6UMhdFg uYNA== X-Gm-Message-State: AHQUAuZxNN1L5201lTZPTTWWLqAH/Z/Cs/cw5288iUg5Rp3gsNDFxFsJ LHB/47bthsTay74eQ22urBUC4w== X-Google-Smtp-Source: AHgI3IauJePI+rLbGDalYOh3Dl636ZOUdkoQ39h+8kbQeEF7A5be/izEwq3O0I4DlNb1cD3CX7j30w== X-Received: by 2002:a9d:88d:: with SMTP id 13mr6503396otf.269.1549492727725; Wed, 06 Feb 2019 14:38:47 -0800 (PST) Received: from localhost ([2601:647:4700:93d:6db5:e35d:dacd:7872]) by smtp.gmail.com with ESMTPSA id g19sm9858195otl.26.2019.02.06.14.38.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 14:38:47 -0800 (PST) Date: Wed, 6 Feb 2019 14:38:46 -0800 From: Moritz Fischer To: Andrew Lunn Cc: Moritz Fischer , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, colin.king@canonical.com, linus.walleij@linaro.org, yuehaibing@huawei.com, mcgrof@kernel.org, frowand.list@gmail.com, robh+dt@kernel.org, UNGLinuxDriver@microchip.com, woojung.huh@microchip.com, hkallweit1@gmail.com, davem@davemloft.net, f.fainelli@gmail.com, vivien.didelot@gmail.com, moritz@ettus.com, alex.williams@ni.com Subject: Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c Message-ID: <20190206223846.GA22321@archbook> References: <20190206205106.11517-1-mdf@kernel.org> <20190206215322.GC32483@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206215322.GC32483@lunn.ch> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, thanks for your feedback. On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote: > On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: > > Move the DT based link GPIO parsing to of_mdio and let the places > > that register a fixed_phy pass in a GPIO descriptor or NULL. > > > > This allows fixed_phy on non-DT platforms to have link GPIOs, too. > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/net/dsa/dsa_loop.c | 2 +- > > drivers/net/ethernet/broadcom/bgmac.c | 2 +- > > drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +- > > drivers/net/phy/fixed_phy.c | 48 ++------------------ > > drivers/net/usb/lan78xx.c | 2 +- > > drivers/of/of_mdio.c | 15 +++++- > > include/linux/phy_fixed.h | 3 +- > > 7 files changed, 23 insertions(+), 51 deletions(-) > > > > diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c > > index 17482ae09aa5..7f124c620092 100644 > > --- a/drivers/net/dsa/dsa_loop.c > > +++ b/drivers/net/dsa/dsa_loop.c > > @@ -343,7 +343,7 @@ static int __init dsa_loop_init(void) > > unsigned int i; > > > > for (i = 0; i < NUM_FIXED_PHYS; i++) > > - phydevs[i] = fixed_phy_register(PHY_POLL, &status, NULL); > > + phydevs[i] = fixed_phy_register(PHY_POLL, &status, NULL, NULL); > > > > return mdio_driver_register(&dsa_loop_drv); > > } > > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c > > index 4632dd5dbad1..bce644dec5c2 100644 > > --- a/drivers/net/ethernet/broadcom/bgmac.c > > +++ b/drivers/net/ethernet/broadcom/bgmac.c > > @@ -1446,7 +1446,7 @@ int bgmac_phy_connect_direct(struct bgmac *bgmac) > > struct phy_device *phy_dev; > > int err; > > > > - phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); > > + phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL, NULL); > > if (!phy_dev || IS_ERR(phy_dev)) { > > dev_err(bgmac->dev, "Failed to register fixed PHY device\n"); > > return -ENODEV; > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c > > index 51880d83131a..7cbd737aba80 100644 > > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > > +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c > > @@ -525,7 +525,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) > > .asym_pause = 0, > > }; > > > > - phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); > > + phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL, NULL); > > if (!phydev || IS_ERR(phydev)) { > > dev_err(kdev, "failed to register fixed PHY device\n"); > > return -ENODEV; > > diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c > > index d810f914aaa4..845bd7c2065a 100644 > > --- a/drivers/net/phy/fixed_phy.c > > +++ b/drivers/net/phy/fixed_phy.c > > @@ -18,6 +18,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -191,50 +192,12 @@ static void fixed_phy_del(int phy_addr) > > } > > } > > > > -#ifdef CONFIG_OF_GPIO > > -static struct gpio_desc *fixed_phy_get_gpiod(struct device_node *np) > > -{ > > - struct device_node *fixed_link_node; > > - struct gpio_desc *gpiod; > > - > > - if (!np) > > - return NULL; > > - > > - fixed_link_node = of_get_child_by_name(np, "fixed-link"); > > - if (!fixed_link_node) > > - return NULL; > > - > > - /* > > - * As the fixed link is just a device tree node without any > > - * Linux device associated with it, we simply have obtain > > - * the GPIO descriptor from the device tree like this. > > - */ > > - gpiod = gpiod_get_from_of_node(fixed_link_node, "link-gpios", 0, > > - GPIOD_IN, "mdio"); > > - of_node_put(fixed_link_node); > > - if (IS_ERR(gpiod)) { > > - if (PTR_ERR(gpiod) == -EPROBE_DEFER) > > - return gpiod; > > - pr_err("error getting GPIO for fixed link %pOF, proceed without\n", > > - fixed_link_node); > > - gpiod = NULL; > > - } > > - > > - return gpiod; > > -} > > -#else > > -static struct gpio_desc *fixed_phy_get_gpiod(struct device_node *np) > > -{ > > - return NULL; > > -} > > -#endif > > - > > struct phy_device *fixed_phy_register(unsigned int irq, > > struct fixed_phy_status *status, > > - struct device_node *np) > > + struct device_node *np, > > + struct gpio_desc *gpiod) > > { > > struct fixed_mdio_bus *fmb = &platform_fmb; > > - struct gpio_desc *gpiod = NULL; > > struct phy_device *phy; > > int phy_addr; > > int ret; > > @@ -242,11 +205,6 @@ struct phy_device *fixed_phy_register(unsigned int irq, > > if (!fmb->mii_bus || fmb->mii_bus->state != MDIOBUS_REGISTERED) > > return ERR_PTR(-EPROBE_DEFER); > > > > - /* Check if we have a GPIO associated with this fixed phy */ > > - gpiod = fixed_phy_get_gpiod(np); > > - if (IS_ERR(gpiod)) > > - return ERR_CAST(gpiod); > > - > > /* Get the next available PHY address, up to PHY_MAX_ADDR */ > > phy_addr = ida_simple_get(&phy_fixed_ida, 0, PHY_MAX_ADDR, GFP_KERNEL); > > if (phy_addr < 0) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > > index 3d92ea6fcc02..bd88f0aef2fa 100644 > > --- a/drivers/net/usb/lan78xx.c > > +++ b/drivers/net/usb/lan78xx.c > > @@ -2051,7 +2051,7 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev) > > phydev = phy_find_first(dev->mdiobus); > > if (!phydev) { > > netdev_dbg(dev->net, "PHY Not Found!! Registering Fixed PHY\n"); > > - phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); > > + phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL, NULL); > > if (IS_ERR(phydev)) { > > netdev_err(dev->net, "No PHY/fixed_PHY found\n"); > > return NULL; > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > > index de6157357e26..6be2120b5f03 100644 > > --- a/drivers/of/of_mdio.c > > +++ b/drivers/of/of_mdio.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > > > #define DEFAULT_GPIO_RESET_DELAY 10 /* in microseconds */ > > > > @@ -460,6 +461,7 @@ int of_phy_register_fixed_link(struct device_node *np) > > { > > struct fixed_phy_status status = {}; > > struct device_node *fixed_link_node; > > + struct gpio_desc *gpiod = NULL; > > u32 fixed_link_prop[5]; > > const char *managed; > > > > @@ -483,7 +485,17 @@ int of_phy_register_fixed_link(struct device_node *np) > > status.pause = of_property_read_bool(fixed_link_node, "pause"); > > status.asym_pause = of_property_read_bool(fixed_link_node, > > "asym-pause"); > > + > > + gpiod = gpiod_get_from_of_node(fixed_link_node, "link-gpios", 0, > > + GPIOD_IN, "mdio"); > > of_node_put(fixed_link_node); > > + if (IS_ERR(gpiod)) { > > + if (PTR_ERR(gpiod) == -EPROBE_DEFER) > > + return PTR_ERR(gpiod); > > + pr_err("error getting GPIO for fixed link %pOF, proceed without\n", > > + fixed_link_node); > > + gpiod = NULL; > > extern struct phy_device *fixed_phy_register(unsigned int irq, > > struct fixed_phy_status *status, > > - struct device_node *np); > > + struct device_node *np, > > + struct gpio_desc *gpiod); > > Hi Moritz > > I think it would be better to add a > > extern struct phy_device *fixed_phy_register_gpiod(unsigned int irq, > struct fixed_phy_status *status, > struct gpio_desc *gpiod); > > If you are not using DT, the np is pointless. So lets keep the API > simple. To clarify: Do you agree with moving the parsing to of_mdio, or do you want to keep the parsing as it was and just add an additional function. In the latter case you'd have a static struct phy_device *__fixed_phy_register(unsigned int irq, struct fixed_phy_status *status, struct device_node *np, struct gpio_desc *gpiod) { if (gpiod) use that else old behavior / scan dt? } That we then call from fixed_phy_register_gpiod() with a np of NULL, and from fixed_phy_register() with a gpiod of NULL? Thanks, Moritz