All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: han.xu@nxp.com, martin.kepplinger@ginzinger.com,
	linux-mtd@lists.infradead.org, bbrezillon@kernel.org
Subject: Re: [PATCH] mtd: rawnand: gpmi: Introduce GPMI_IS_MXS() macro
Date: Thu, 7 Feb 2019 12:01:51 +0100	[thread overview]
Message-ID: <20190207120151.37b7bbd3@xps13> (raw)
In-Reply-To: <20190207105055.10860-1-festevam@gmail.com>

Hi Fabio,

Fabio Estevam <festevam@gmail.com> wrote on Thu,  7 Feb 2019 08:50:54
-0200:

> Introduce a GPMI_IS_MXS() macro to take into account the cases
> when mx23 or mx28 are used, which helps readability.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c  | 6 ++----
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 2 +-
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h | 1 +
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> index a4768df5083f..a8b26d2e793c 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> @@ -157,8 +157,7 @@ int gpmi_init(struct gpmi_nand_data *this)
>  	 * Reset BCH here, too. We got failures otherwise :(
>  	 * See later BCH reset for explanation of MX23 and MX28 handling
>  	 */
> -	ret = gpmi_reset_block(r->bch_regs,
> -			       GPMI_IS_MX23(this) || GPMI_IS_MX28(this));
> +	ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MXS(this));
>  	if (ret)
>  		goto err_out;
>  
> @@ -266,8 +265,7 @@ int bch_set_geometry(struct gpmi_nand_data *this)
>  	* chip, otherwise it will lock up. So we skip resetting BCH on the MX23.
>  	* and MX28.
>  	*/
> -	ret = gpmi_reset_block(r->bch_regs,
> -			       GPMI_IS_MX23(this) || GPMI_IS_MX28(this));
> +	ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MXS(this));
>  	if (ret)
>  		goto err_out;
>  
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index ed405c9434fe..bcf5328cf239 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -171,7 +171,7 @@ static inline bool gpmi_check_ecc(struct gpmi_nand_data *this)
>  	struct bch_geometry *geo = &this->bch_geometry;
>  
>  	/* Do the sanity check. */
> -	if (GPMI_IS_MX23(this) || GPMI_IS_MX28(this)) {
> +	if (GPMI_IS_MXS(this)) {
>  		/* The mx23/mx28 only support the GF13. */
>  		if (geo->gf_len == 14)
>  			return false;
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> index d0b79bac2728..a804a4a5bd46 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> @@ -207,4 +207,5 @@ void gpmi_copy_bits(u8 *dst, size_t dst_bit_off,
>  
>  #define GPMI_IS_MX6(x)		(GPMI_IS_MX6Q(x) || GPMI_IS_MX6SX(x) || \
>  				 GPMI_IS_MX7D(x))
> +#define GPMI_IS_MXS(x)		(GPMI_IS_MX23(x) || GPMI_IS_MX28(x))
>  #endif

I'm fine with the patch but as this depends on the fix Boris just took I
will apply it for 5.2.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-02-07 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 10:50 [PATCH] mtd: rawnand: gpmi: Introduce GPMI_IS_MXS() macro Fabio Estevam
2019-02-07 11:01 ` Miquel Raynal [this message]
2019-02-07 11:29   ` Fabio Estevam
2019-04-01 15:22 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207120151.37b7bbd3@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.kepplinger@ginzinger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.