From: Joel Fernandes <joel@joelfernandes.org>
To: Hugo Lefeuvre <hle@owl.eu.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Greg Hartman" <ghartman@google.com>,
"Alistair Strachan" <astrachan@google.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Christian Brauner" <christian@brauner.io>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] sched/wait: use freezable_schedule when possible
Date: Thu, 7 Feb 2019 10:05:37 -0500 [thread overview]
Message-ID: <20190207150537.GA180446@google.com> (raw)
In-Reply-To: <20190206233050.GB2092@behemoth.owl.eu.com.local>
On Thu, Feb 07, 2019 at 12:30:50AM +0100, Hugo Lefeuvre wrote:
> Hi Joel,
>
> > I'm curious did you try the freezing process and see if pointless wakeups are
> > reduced? That would be an added bonus if you did.
>
> I'm currently testing these changes. I hope to be able to come back with
> more concrete results soon.
>
> Also, I just noticed that the third patch removes a necessary #include
> <linux/freezer.h>. I will submit an updated version tomorrow.
>
> Thanks for the review!
Sure, add these test results to the patch as well showing reduced wakeups.
I would say submit the freezable_schedule as a single separate patch
independent of the vsoc series since it can go in separately, and also
benefits other things than vsoc.
Also CC Rafael (power maintainer) on it.
Thank you!
- Joel
next prev parent reply other threads:[~2019-02-07 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 5:37 [PATCH 0/3] sched/wait, staging/android: simplification and optimization of freeze related code Hugo Lefeuvre
2019-02-01 5:38 ` [PATCH 1/3] sched/wait: use freezable_schedule when possible Hugo Lefeuvre
2019-02-02 18:37 ` Joel Fernandes
2019-02-06 23:30 ` Hugo Lefeuvre
2019-02-07 15:05 ` Joel Fernandes [this message]
2019-02-07 21:40 ` Hugo Lefeuvre
2019-02-07 13:28 ` Hugo Lefeuvre
2019-02-05 16:37 ` Joel Fernandes
2019-02-01 5:38 ` [PATCH 2/3] sched/wait: introduce wait_event_freezable_hrtimeout Hugo Lefeuvre
2019-02-05 16:42 ` Joel Fernandes
2019-02-01 5:39 ` [PATCH 3/3] staging/android: simplify handle_vsoc_cond_wait Hugo Lefeuvre
2019-02-04 15:52 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207150537.GA180446@google.com \
--to=joel@joelfernandes.org \
--cc=arve@android.com \
--cc=astrachan@google.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=ghartman@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hle@owl.eu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.