From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "Kalakota, SushmaX" <sushmax.kalakota@intel.com>,
"scott.bauer@intel.com" <scott.bauer@intel.com>,
"Busch, Keith" <keith.busch@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: vmd: Free up IRQs on suspend path
Date: Thu, 7 Feb 2019 16:18:45 +0100 [thread overview]
Message-ID: <20190207151845.GA11823@kroah.com> (raw)
In-Reply-To: <1549552167.19557.3.camel@intel.com>
On Thu, Feb 07, 2019 at 03:10:09PM +0000, Derrick, Jonathan wrote:
> On Thu, 2019-02-07 at 12:07 +0100, Greg KH wrote:
> > On Wed, Feb 06, 2019 at 02:36:16PM -0700, Sushma Kalakota wrote:
> > > commit e2b1820bd5d09 upstream
> > >
> > > Free up the IRQs we request on the suspend path and reallocate them
> > > on the
> > > resume path.
> > >
> > > Fixes this error:
> > >
> > > CPU 111 disable failed: CPU has 9 vectors assigned and there are
> > > only 0 available.
> > > Error taking CPU111 down: -34
> > > Non-boot CPUs are not disabled
> > > Enabling non-boot CPUs ...
> > >
> > > For consistency, this patch also includes the VMD portion of:
> > > 3eefa790c9681: PCI: host: Mark PCIe/PCI (MSI) cascade ISR as
> > > IRQF_NO_THREAD
> > >
> > > CC: Scott Bauer <scott.bauer@intel.com>
> > > CC: Bjorn Helgaas <bhelgaas@google.com>
> > > CC: Keith Busch <keith.busch@intel.com>
> > > Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
> > > Signed-off-by: Sushma Kalakota <sushmax.kalakota@intel.com>
> > > ---
> > > drivers/pci/host/vmd.c | 18 +++++++++++++++++-
> > > 1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> >
> > What stable kernel tree(s) do you want this patch applied to? And
> > why?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> This is for 4.9.y and intended to increase reliability of
> suspend/resume not leading to a failure to suspend or failure to
> resume, either of which would be undesireable to users of the feature,
> and potentially make the overall feature unusable if suspend/resume
> were user requirement.
Ok, but who is still using this old kernel on these types of machines?
Why haven't they moved to 4.14 or newer by now? The normal systems that
use 4.9 or older should not need this, as they are the horrid SoC trees.
Who has reported this problem in their systems?
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-07 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 21:36 [PATCH] PCI: vmd: Free up IRQs on suspend path Sushma Kalakota
2019-02-07 11:07 ` Greg KH
2019-02-07 15:10 ` Derrick, Jonathan
2019-02-07 15:18 ` gregkh [this message]
2019-02-11 13:37 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-08-11 20:54 Scott Bauer
2017-08-14 18:06 ` Bjorn Helgaas
2017-08-14 18:15 ` Keith Busch
2017-08-14 20:30 ` Bjorn Helgaas
2017-07-20 20:28 Scott Bauer
2017-07-26 2:15 ` Jon Derrick
2017-07-20 21:34 ` Scott Bauer
2017-07-26 2:36 ` Jon Derrick
2017-07-20 21:56 ` Scott Bauer
2017-07-20 22:41 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207151845.GA11823@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=scott.bauer@intel.com \
--cc=stable@vger.kernel.org \
--cc=sushmax.kalakota@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.