All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
	Chas Williams <3chas3@gmail.com>
Subject: [v3,PATCH 2/2] build: fix option ordering
Date: Thu,  7 Feb 2019 10:53:18 -0500	[thread overview]
Message-ID: <20190207155318.12579-2-3chas3@gmail.com> (raw)
In-Reply-To: <20190207155318.12579-1-3chas3@gmail.com>

Sort the options alphabetically and make a note of the preferred
order at the top of the file.

Signed-off-by: Chas Williams <3chas3@gmail.com>
---
 meson_options.txt | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/meson_options.txt b/meson_options.txt
index 5bae08bb3..c6454fe29 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,15 +1,17 @@
+# Please keep these options sorted alphabetically.
+
 option('allow_invalid_socket_id', type: 'boolean', value: false,
 	description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly')
 option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
 	description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
-option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'shared',
-	description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')
-option('enable_kmods', type: 'boolean', value: true,
-	description: 'build kernel modules')
 option('enable_docs', type: 'boolean', value: false,
 	description: 'build documentation')
+option('enable_kmods', type: 'boolean', value: true,
+	description: 'build kernel modules')
 option('examples', type: 'string', value: '',
 	description: 'Comma-separated list of examples to build by default')
+option('ibverbs_link', type: 'combo', choices : ['shared', 'dlopen'], value: 'shared',
+	description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.')
 option('include_subdir_arch', type: 'string', value: '',
 	description: 'subdirectory where to install arch-dependent headers')
 option('kernel_dir', type: 'string', value: '',
@@ -26,7 +28,7 @@ option('max_numa_nodes', type: 'string', value: '4',
 	description: 'maximum number of NUMA nodes supported by EAL')
 option('per_library_versions', type: 'boolean', value: true,
 	description: 'true: each lib gets its own version number, false: DPDK version used for each lib')
-option('use_hpet', type: 'boolean', value: false,
-	description: 'use HPET timer in EAL')
 option('tests', type: 'boolean', value: true,
 	description: 'build unit tests')
+option('use_hpet', type: 'boolean', value: false,
+	description: 'use HPET timer in EAL')
-- 
2.17.2

  reply	other threads:[~2019-02-07 15:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-31  2:18 [PATCH] build: add option to override max ethports Chas Williams
2019-01-31  9:32 ` Bruce Richardson
2019-01-31 23:26   ` Chas Williams
2019-02-04  9:46     ` Bruce Richardson
2019-02-06 17:10   ` Luca Boccassi
2019-01-31 23:53 ` [PATCH 1/2 v2] " Chas Williams
2019-02-04  9:49   ` Bruce Richardson
2019-02-05 21:08     ` Chas Williams
2019-01-31 23:59 ` [PATCH 2/2,v2] build: fix option ordering Chas Williams
2019-02-04  9:56   ` Bruce Richardson
2019-02-07 15:53 ` [v3, PATCH 1/2] build: add option to override max ethports Chas Williams
2019-02-07 15:53   ` Chas Williams [this message]
2019-02-07 16:35     ` [v3,PATCH 2/2] build: fix option ordering Bruce Richardson
2019-02-26 20:31       ` Thomas Monjalon
2019-02-26 20:19   ` [v3, PATCH 1/2] build: add option to override max ethports Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207155318.12579-2-3chas3@gmail.com \
    --to=3chas3@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.