From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BE9C282C2 for ; Fri, 8 Feb 2019 00:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 658922085A for ; Fri, 8 Feb 2019 00:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="r6C4RHDy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbfBHAYx (ORCPT ); Thu, 7 Feb 2019 19:24:53 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46355 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbfBHAYx (ORCPT ); Thu, 7 Feb 2019 19:24:53 -0500 Received: by mail-pg1-f195.google.com with SMTP id w7so737184pgp.13 for ; Thu, 07 Feb 2019 16:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xv/4kdxMi4ynCE8VOzm+4gxGZnyEja01E56EH0sxobE=; b=r6C4RHDy06diPNblhSSk5cWX0oJ6uCm0qlkz3ZOYmW6kbSzdtYcIRFEZ+RjWtpsR8Y iO9JHlbxYLMVKuOJOJVlTT4wlteZDLzWP2wi+k5JWCv7DTVJocwWeAXW98XTq67NqjGL PEjEdkqK1DJGhVUipSB0/ZLVxrLr0Hki1sLMikjVJSUAGgOfKgga1Vt1H6JAB2Pg44mt JaedueNsCiywDrfBn+vYDDRXmTQmiGXmTZcUslSxFHITidqsO8LlyrY5nGyrkLTgKWjJ pR46qUrE6xIFu4llpu7PL2mLmHtx2Y71zhyh+RG3H4jK3+H6LPzOTGPenN0VYTbIEA3+ 08PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xv/4kdxMi4ynCE8VOzm+4gxGZnyEja01E56EH0sxobE=; b=rCz1Dg7J1qvLWQcAVIovvw7p5rxUQVuTG/k/7ck7WvapXzviiabc8u8nSJgMuGxM3n v+aAqH2XSe6A8ymn5rtvwnqXvc+Ztsj2LqGTZnH1gc8Ji0izTQ2EAo/xbwwgcer8NvAe I0jsmFTQaCFW7HkavAmyOkUWInaG0PEFZXRq5Zj66NLgmCzGn3NBMvJDE+990RPcMds/ LSb+7SYrmSPc605q3eEO1zAD2YIe2npDAqRNc+x3UZJDcyl0FXMZm4u51sE926omhI50 Wu+iPq36VqQ2gnigdVI+fPaApG8OnH+5VBwWBK7KPCc1jAifwER+tHCOLUVQSjvs0Vcb yBQg== X-Gm-Message-State: AHQUAubvgz/4s+DpybHWWccXik6c0YIF0YD/2CynSXayUerzgCIrO5AY WleCekfqzUt0IQmkNtTm6Vy0pQ== X-Google-Smtp-Source: AHgI3IZiJQrUk41fs/nVCa9vD5GQNAqEGXTEGzaI2KK0mZW7GAJ8MBiLHL1w6CAja4zOPlZWIMKNkw== X-Received: by 2002:a65:6151:: with SMTP id o17mr193235pgv.285.1549585492872; Thu, 07 Feb 2019 16:24:52 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i28sm400654pfi.171.2019.02.07.16.24.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 16:24:52 -0800 (PST) Date: Thu, 7 Feb 2019 16:24:36 -0800 From: Stephen Hemminger To: Phil Sutter Cc: netdev@vger.kernel.org, Roopa Prabhu Subject: Re: [iproute PATCH] ip-link: Fix listing of alias interfaces Message-ID: <20190207162436.4452f7ad@hermes.lan> In-Reply-To: <20190207130527.9439-1-phil@nwl.cc> References: <20190207130527.9439-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter wrote: > Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of > links in the old alias interface notation: > > | % ip link show eth0:1 > | RTNETLINK answers: No such device > | Cannot send link get request: No such device > > Prior to the above commit, link lookup was performed via ifindex > returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call > which on kernel side causes the colon-suffix to be dropped before doing > the interface lookup. Netlink API though doesn't care about that at all. > To keep things backward compatible, mimick ioctl API behaviour and drop > the colon-suffix prior to sending the RTM_GETLINK request. > > Fixes: 50b9950dd9011 ("link dump filter") > Signed-off-by: Phil Sutter What about mistaken usage where the text after the colon is not a number, or has additional colon?