All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rik van Riel <riel@surriel.com>
Subject: Re: [GIT PULL] x86/mm changes for v4.21
Date: Thu, 7 Feb 2019 10:40:21 -0800	[thread overview]
Message-ID: <20190207184021.GA17049@agluck-desk> (raw)
In-Reply-To: <20190207175720.GE32511@hirez.programming.kicks-ass.net>

On Thu, Feb 07, 2019 at 06:57:20PM +0100, Peter Zijlstra wrote:
> Something like so then? AFAICT CLFLUSH will also #GP if feed it crap.

Correct. CFLUSH will also #GP on a non-canonical address.

> -		__flush_tlb_one_kernel(__cpa_addr(cpa, i));
> +		__flush_tlb_one_kernel(fix_addr(__cpa_addr(cpa, i)));


> -			clflush_cache_range_opt((void *)addr, PAGE_SIZE);
> +			clflush_cache_range_opt((void *)fix_addr(addr), PAGE_SIZE);

Looks like as close as you can get without being crazy. Many/most
of the apparent function calls here are going to be inlined. So
likely safe.

Tried it out and it works!

So:

Tested-by: Tony Luck <tony.luck@intel.com>

Thanks

-Tony

  parent reply	other threads:[~2019-02-07 18:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 23:11 [GIT PULL] x86/mm changes for v4.21 Ingo Molnar
2018-12-27  2:45 ` pr-tracker-bot
2019-02-07  0:17 ` Luck, Tony
2019-02-07  0:33   ` Dave Hansen
2019-02-07  9:50     ` Peter Zijlstra
2019-02-07 10:18   ` Peter Zijlstra
2019-02-07 11:50     ` Linus Torvalds
2019-02-07 14:01       ` Peter Zijlstra
2019-02-07 17:36         ` Luck, Tony
2019-02-07 17:57           ` Peter Zijlstra
2019-02-07 18:07             ` Andy Lutomirski
2019-02-07 18:46               ` Luck, Tony
2019-02-07 20:24                 ` Andy Lutomirski
2019-02-07 22:53                   ` Linus Torvalds
2019-02-07 23:05                     ` Andy Lutomirski
2019-02-07 18:40             ` Luck, Tony [this message]
2019-02-08 12:08               ` [PATCH] x86/mm/cpa: Fix set_mce_nospec() Peter Zijlstra
2019-02-08 13:37                 ` [tip:x86/urgent] " tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207184021.GA17049@agluck-desk \
    --to=tony.luck@intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.