From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND] fs/read_write.c: make __vfs_write() static
Date: Thu, 7 Feb 2019 15:39:13 -0800 [thread overview]
Message-ID: <20190207233912.GF125156@gmail.com> (raw)
In-Reply-To: <20190110204153.120176-1-ebiggers@kernel.org>
On Thu, Jan 10, 2019 at 12:41:53PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> __vfs_write() is only used in fs/read_write.c, so make it static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/read_write.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/read_write.c b/fs/read_write.c
> index ff3c5e6f87cfa..4b328e45db366 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t
> return ret;
> }
>
> -ssize_t __vfs_write(struct file *file, const char __user *p, size_t count,
> - loff_t *pos)
> +static ssize_t __vfs_write(struct file *file, const char __user *p,
> + size_t count, loff_t *pos)
> {
> if (file->f_op->write)
> return file->f_op->write(file, p, count, pos);
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
prev parent reply other threads:[~2019-02-07 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:41 [PATCH RESEND] fs/read_write.c: make __vfs_write() static Eric Biggers
2019-02-07 23:39 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207233912.GF125156@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.