From: Eric Biggers <ebiggers@kernel.org>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND] fs/nsfs.c: include linux/proc_fs.h for open_related_ns()
Date: Thu, 7 Feb 2019 15:39:23 -0800 [thread overview]
Message-ID: <20190207233922.GG125156@gmail.com> (raw)
In-Reply-To: <20190110204150.120124-1-ebiggers@kernel.org>
On Thu, Jan 10, 2019 at 12:41:50PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> open_related_ns() is defined in fs/nsfs.c and declared in
> linux/proc_fs.h, but the declaration isn't included at the point of the
> definition. Include the header to enforce that the definition matches
> the declaration.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/nsfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index 60702d677bd4e..a7ff518400a10 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -2,6 +2,7 @@
> #include <linux/mount.h>
> #include <linux/file.h>
> #include <linux/fs.h>
> +#include <linux/proc_fs.h>
> #include <linux/proc_ns.h>
> #include <linux/magic.h>
> #include <linux/ktime.h>
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
prev parent reply other threads:[~2019-02-07 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 20:41 [PATCH RESEND] fs/nsfs.c: include linux/proc_fs.h for open_related_ns() Eric Biggers
2019-02-07 23:39 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207233922.GG125156@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.