From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF67C282C2 for ; Thu, 7 Feb 2019 23:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4A4B21721 for ; Thu, 7 Feb 2019 23:39:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582792; bh=gPVlQoew/E4R1UaIQAIIOEXXxUz7tN+F6WWIiaFtikk=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=brulSfq3XQrw6Lg//EE+JKuXucr8MGsmE5taRdCx85pAySjaXZ174Ixthcbn07+8D eiPUdWtA02/klcOzd7D6Gv4JhmnJ2ppleNOW9bGXjjWZaCp5HF6LjbxjRpZ3osnuj1 5EWIMyojSdlirtICSuFsv0p9AV33mKb/U0yJ55TU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbfBGXjw (ORCPT ); Thu, 7 Feb 2019 18:39:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:53374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfBGXjw (ORCPT ); Thu, 7 Feb 2019 18:39:52 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AE3C2085A; Thu, 7 Feb 2019 23:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582791; bh=gPVlQoew/E4R1UaIQAIIOEXXxUz7tN+F6WWIiaFtikk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=bbu50Qs4ojZOPkC3Osc7Yywl75sFIAAd13yozLHTWlNziP61UbgfVC/vYBALCuVzx BGPDn3GMZ2opixVhCmRRMEmaIHu8iI6CRQ1zQC4fIBfWqy4eiI5c/+mLgFsdI0xqZM w1avqANPN569RZ8Quxqo6JasqjPmy6Xvj5hr9k4M= Date: Thu, 7 Feb 2019 15:39:50 -0800 From: Eric Biggers To: linux-fsdevel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH RESEND] fs/direct-io.c: include fs/internal.h for sb_init_dio_done_wq() Message-ID: <20190207233949.GI125156@gmail.com> References: <20190110204143.120023-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110204143.120023-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 10, 2019 at 12:41:43PM -0800, Eric Biggers wrote: > From: Eric Biggers > > sb_init_dio_done_wq() is defined in fs/direct-io.c and declared in > fs/internal.h, but the declaration isn't included at the point of the > definition. Include the header to enforce that the definition matches > the declaration. > > This addresses a gcc warning when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers > --- > fs/direct-io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index dbc1a1f080ceb..42e497e3a39a9 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include "internal.h" > > /* > * How many user pages to map in one call to get_user_pages(). This determines > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric