From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Peter Huewe <PeterHuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm: Unify the send callback behaviour
Date: Fri, 8 Feb 2019 18:07:23 +0200 [thread overview]
Message-ID: <20190208160723.GA23755@linux.intel.com> (raw)
In-Reply-To: <89f94ccb-d63e-271c-a91b-cfe63e40f776@linux.ibm.com>
On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote:
> On 2/8/19 10:42 AM, Jarkko Sakkinen wrote:
> > On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote:
> > > At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) are also
> > > returning the number of bytes sent. I would consider tpm_crb the outlier
> > > that returns 0 and should return the length even though we don't need it...
> > That would be absolutely wrong way the fix the *actual* issue i.e.
> > callbacks returning garbage (sometimes just passing the length parameter
> > back as a return value).
>
> Then I guess you have to fixes those other two files as well...
That's still a better option.
/Jarkko
next prev parent reply other threads:[~2019-02-08 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 14:05 [PATCH 0/2] Unify send() callbacks Jarkko Sakkinen
2019-02-08 14:05 ` [PATCH 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-08 14:42 ` Stefan Berger
2019-02-08 15:42 ` Jarkko Sakkinen
2019-02-08 15:45 ` Stefan Berger
2019-02-08 16:07 ` Jarkko Sakkinen [this message]
2019-02-08 16:19 ` Stefan Berger
2019-02-08 16:26 ` Jarkko Sakkinen
2019-02-08 16:28 ` Jarkko Sakkinen
2019-02-08 14:06 ` [PATCH 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208160723.GA23755@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=PeterHuewe@gmx.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.