From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Peter Huewe <PeterHuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Alexander Steffen <Alexander.Steffen@infineon.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä
Date: Fri, 8 Feb 2019 22:23:53 +0200 [thread overview]
Message-ID: <20190208202353.GB1836@linux.intel.com> (raw)
In-Reply-To: <6a86e3e8-e311-7a0f-585d-3f0435b0143a@linux.ibm.com>
On Fri, Feb 08, 2019 at 02:27:31PM -0500, Stefan Berger wrote:
> On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:
> >
> > */
> > if (rc > 0) {
> > dev_warn(&chip->dev,
> > "%s: send(): invalid value %d\n", __func__, rc);
> > rc = 0;
> > }
> >
> > Should be fairly safe play now.
>
> Unfortuantely it isn't. You seemed to have lost the
> EXPORT_SYMBOL_GPL(tpm_chip_start/stop) and the tpm_chip_start/stop around
> the tpm2_shutdown()...
OK, now those fixes are back. In tpm_pm_shutdown() case you need also
take the lock.
/Jarkko
next prev parent reply other threads:[~2019-02-08 20:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 18:08 [PATCH v4 0/2] tpm: Unify send() callbacks Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-08 18:12 ` Stefan Berger
2019-02-08 19:00 ` Jarkko Sakkinen
2019-02-08 19:17 ` [PATCH v4 1/2] tpm: Unify the send callback behaviourä Jarkko Sakkinen
2019-02-08 19:27 ` Stefan Berger
2019-02-08 20:23 ` Jarkko Sakkinen [this message]
2019-02-08 20:32 ` Stefan Berger
2019-02-08 20:46 ` Jarkko Sakkinen
2019-02-08 21:18 ` Stefan Berger
2019-02-08 21:51 ` Jarkko Sakkinen
2019-02-08 20:38 ` Jarkko Sakkinen
2019-02-11 15:05 ` [PATCH v4 1/2] tpm: Unify the send callback behaviour Alexander Steffen
2019-02-13 7:44 ` Jarkko Sakkinen
2019-02-09 18:20 ` Jerry Snitselaar
2019-02-09 20:01 ` Jerry Snitselaar
2019-02-11 13:58 ` Jarkko Sakkinen
2019-02-08 18:08 ` [PATCH v4 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Jarkko Sakkinen
2019-02-09 20:08 ` [PATCH v4 0/2] tpm: Unify send() callbacks Jerry Snitselaar
2019-02-11 14:03 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208202353.GB1836@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=PeterHuewe@gmx.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.