All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3 7/7] support/download/{bzr, cvs, git, svn}: highlight unimplemented source-check
Date: Sat, 9 Feb 2019 23:13:37 +0100	[thread overview]
Message-ID: <20190209221337.GJ3079@scaer> (raw)
In-Reply-To: <20190209202350.4984-7-patrickdepinguin@gmail.com>

Thomas, All,

On 2019-02-09 21:23 +0100, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> 
> For bzr, cvs, git and svn, there is no method of checking whether the

Acutally, for svn this is realtively trivial:

    svn ls -r ${rev} ${remote}

We have two packages in Buildroot that use svn, fis and open2300, so you
cn use them to test:

    $ svn ls -r 2892 http://svn.chezphil.org/utils/trunk
    Redirecting to URL 'https://svn.chezphil.org/utils/trunk':
    Makefile
    apexctl.cc
    [...]

Regards,
Yann E. MORIN.

> revision exists remotely, without actually cloning the repository.
> Therefore, there is no actual implementation for '-C' (checkonly) for these
> download helpers. The script will fall back to the normal download logic,
> which would effectively fail if the revision does not exist.
> 
> For completeness, mention this unimplemented feature in the usage text.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
>  support/download/bzr | 2 ++
>  support/download/cvs | 2 ++
>  support/download/git | 2 ++
>  support/download/svn | 2 ++
>  4 files changed, 8 insertions(+)
> 
> v3: no changes
> 
> diff --git a/support/download/bzr b/support/download/bzr
> index 5289a421cd..278d8778af 100755
> --- a/support/download/bzr
> +++ b/support/download/bzr
> @@ -7,6 +7,8 @@ set -e
>  #
>  # Options:
>  #   -q          Be quiet
> +#   -C          (unimplemented) Only check that the revision exists in the
> +#               remote repository.
>  #   -o FILE     Generate archive in FILE.
>  #   -u URI      Clone from repository at URI.
>  #   -c CSET     Use changeset (or revision) CSET.
> diff --git a/support/download/cvs b/support/download/cvs
> index 9d0dc3cb3a..d9a586293a 100755
> --- a/support/download/cvs
> +++ b/support/download/cvs
> @@ -7,6 +7,8 @@ set -e
>  #
>  # Options:
>  #   -q          Be quiet
> +#   -C          (unimplemented) Only check that the revision exists in the
> +#               remote repository.
>  #   -o FILE     Generate archive in FILE.
>  #   -u URI      Checkout from repository at URI.
>  #   -c REV      Use revision REV.
> diff --git a/support/download/git b/support/download/git
> index 17ca04eb98..e9c02d6712 100755
> --- a/support/download/git
> +++ b/support/download/git
> @@ -7,6 +7,8 @@ set -E
>  #
>  # Options:
>  #   -q          Be quiet.
> +#   -C          (unimplemented) Only check that the revision exists in the
> +#               remote repository.
>  #   -r          Clone and archive sub-modules.
>  #   -o FILE     Generate archive in FILE.
>  #   -u URI      Clone from repository at URI.
> diff --git a/support/download/svn b/support/download/svn
> index 542b25c0a2..5fff064683 100755
> --- a/support/download/svn
> +++ b/support/download/svn
> @@ -7,6 +7,8 @@ set -e
>  #
>  # Options:
>  #   -q          Be quiet.
> +#   -C          (unimplemented) Only check that the revision exists in the
> +#               remote repository.
>  #   -o FILE     Generate archive in FILE.
>  #   -u URI      Checkout from repository at URI.
>  #   -c REV      Use revision REV.
> -- 
> 2.19.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-02-09 22:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 20:23 [Buildroot] [PATCHv3 1/7] support/download: reintroduce 'source-check' target Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 2/7] support/download/hg: implement source-check Thomas De Schampheleire
2019-02-09 21:53   ` Yann E. MORIN
2019-02-15 19:10     ` Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 3/7] support/download/wget: " Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 4/7] support/download/file: " Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 5/7] Config.in: reintroduce BR2_SSH Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 6/7] support/download/scp: implement source-check Thomas De Schampheleire
2019-02-09 22:09   ` Yann E. MORIN
2019-02-15 19:15     ` Thomas De Schampheleire
2019-02-15 21:00       ` Thomas De Schampheleire
2019-02-09 20:23 ` [Buildroot] [PATCHv3 7/7] support/download/{bzr, cvs, git, svn}: highlight unimplemented source-check Thomas De Schampheleire
2019-02-09 22:13   ` Yann E. MORIN [this message]
2019-02-15 19:15     ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190209221337.GJ3079@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.