From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Stanislaw Gruszka Message-Id: <20190210094123.GB2913@redhat.com> Date: Sun, 10 Feb 2019 10:41:24 +0100 To: Stefan Wahren Cc: Lorenzo Bianconi , Felix Fietkau , Doug Anderson , Minas Harutyunyan , linux-wireless , linux-usb@vger.kernel.org List-ID: T24gU2F0LCBGZWIgMDksIDIwMTkgYXQgMDk6Mjk6MDVQTSArMDEwMCwgU3RlZmFuIFdhaHJlbiB3 cm90ZToKPiA+IGNvdWxkIHlvdSBwbGVhc2UgdGVzdCB0aGUgZm9sbG93aW5nIHNlcmllczoKPiA+ IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvY292ZXIvMTA3NjQ0NTMvCj4gCj4geWVhaCB0 aGlzIGZpeGVkIHRoZSBwcm9iaW5nIHRpbWVvdXQgYW5kIHRoZSBkcml2ZXIgd2lsbCBwcm9iZSBz dWNjZXNzZnVsLiBBRkFJSyB0aGUgZHdjMiBob3N0IG1vZGUgZG9lc24ndCBzdXBwb3J0IHNjYXR0 ZXItZ2F0aGVyIHlldC4KClNvIHRoaXMgaXMgZWl0aGVyIGR3YzIgc2NhdHRlci1nYXRoZXIgcHJv YmxlbSB3aGljaCBzaG91bGQgYmUgYWRkcmVzc2VkIGluCnRoaXMgZHJpdmVyIG9yIG10NzZ4MHUg ZG9lcyBzb21ldGhpbmcgd3Jvbmcgd2hlbiBjb25maWd1cmluZyBTRy4KCkRpc2FibGluZyBTRyBp cyBqdXN0IHdvcmthcm91bmQsIHdoaWNoIGRvIG5vdCBhZGRyZXNzIGFjdHVhbCBwcm9ibGVtLgoK SSB0aGluayBJIGZvdW5kIG10NzZ4MHUgaXNzdWUgdGhhdCBjb3VsZCBjYXVzZSB0aGlzIFVTQiBw cm9iZSBlcnJvcgooYW5kIHBvc3NpYmx5IGFsc28gYWRkcmVzcyBBTUQgSU9NTVUgaXNzdWUpLiBX ZSBzZWVtcyBkbyBub3QgY29ycmVjdGx5CnNldCBVUkIgdHJhbnNmZXIgbGVuZ3RoIHNtYWxsZXIg dGhhbiBzZyBidWZmZXIgbGVuZ3RoLiBBdHRhY2hlZCAgcGF0Y2gKc2hvdWxkIGNvcnJlY3QgdGhh dC4KClN0YW5pc2xhdwpGcm9tIGJjMDliYzdmYTYwNDAxOWE1ZWY5MDE4NDM5MGU3YzJhMzg5OTg2 OWQgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IFN0YW5pc2xhdyBHcnVzemthIDxzZ3J1 c3prYUByZWRoYXQuY29tPgpEYXRlOiBTdW4sIDEwIEZlYiAyMDE5IDA4OjA5OjQ4ICswMTAwClN1 YmplY3Q6IFtQQVRDSF0gbXQ3NngwMjogdXNiX21jdTogbGltaXQgc2cgbGVuZ3RoCgpXaGVuIHNl bmRpbmcgZncgZGF0YSB3ZSBsaW10aW5nIHVyYiB0cmFuc2ZlciBsZW5ndGggYnkgY2hhbmdpbmcg YnVmLT5sZW4sCndoaWxlIGtlZXBpbmcgc2VnbWVudCBsZW5ndGggYXQgbWF4X3BheWxvYWQgdmFs dWUuIFRoYXQgbWF5IGNvbmZ1c2UKdW5kZXJseWluZyBkcml2ZXJzIHJlc3BvbnNpYmxlIGZvciBE TUEuCgpTaWduZWQtb2ZmLWJ5OiBTdGFuaXNsYXcgR3J1c3prYSA8c2dydXN6a2FAcmVkaGF0LmNv bT4KLS0tCiBkcml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L210NzZ4MDJfdXNiX21j dS5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9k cml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L210NzZ4MDJfdXNiX21jdS5jIGIvZHJp dmVycy9uZXQvd2lyZWxlc3MvbWVkaWF0ZWsvbXQ3Ni9tdDc2eDAyX3VzYl9tY3UuYwppbmRleCBk YTI5OWI4YTEzMzQuLmNmYTE0NTA2ZWNhNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQvd2lyZWxl c3MvbWVkaWF0ZWsvbXQ3Ni9tdDc2eDAyX3VzYl9tY3UuYworKysgYi9kcml2ZXJzL25ldC93aXJl bGVzcy9tZWRpYXRlay9tdDc2L210NzZ4MDJfdXNiX21jdS5jCkBAIC0yODcsNiArMjg3LDcgQEAg X19tdDc2eDAydV9tY3VfZndfc2VuZF9kYXRhKHN0cnVjdCBtdDc2eDAyX2RldiAqZGV2LCBzdHJ1 Y3QgbXQ3NnVfYnVmICpidWYsCiAJCQlNVF9GQ0VfRE1BX0xFTiwgbGVuIDw8IDE2KTsKIAogCWJ1 Zi0+bGVuID0gTVRfQ01EX0hEUl9MRU4gKyBsZW4gKyBzaXplb2YoaW5mbyk7CisJYnVmLT51cmIt PnNnWzBdLmxlbmd0aCA9IGJ1Zi0+bGVuOwogCWVyciA9IG10NzZ1X3N1Ym1pdF9idWYoJmRldi0+ bXQ3NiwgVVNCX0RJUl9PVVQsCiAJCQkgICAgICAgTVRfRVBfT1VUX0lOQkFORF9DTUQsCiAJCQkg ICAgICAgYnVmLCBHRlBfS0VSTkVMLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73A6C282C2 for ; Sun, 10 Feb 2019 09:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E23320863 for ; Sun, 10 Feb 2019 09:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfBJJla (ORCPT ); Sun, 10 Feb 2019 04:41:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41618 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfBJJla (ORCPT ); Sun, 10 Feb 2019 04:41:30 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E4878667B; Sun, 10 Feb 2019 09:41:30 +0000 (UTC) Received: from localhost (ovpn-204-24.brq.redhat.com [10.40.204.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A5C22D18A; Sun, 10 Feb 2019 09:41:25 +0000 (UTC) Date: Sun, 10 Feb 2019 10:41:24 +0100 From: Stanislaw Gruszka To: Stefan Wahren Cc: Lorenzo Bianconi , Felix Fietkau , Doug Anderson , Minas Harutyunyan , linux-wireless , linux-usb@vger.kernel.org Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190210094123.GB2913@redhat.com> References: <2003727085.234456.1549714119945@email.ionos.de> <165515185.283024.1549744145982@email.ionos.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <165515185.283024.1549744145982@email.ionos.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sun, 10 Feb 2019 09:41:30 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 09, 2019 at 09:29:05PM +0100, Stefan Wahren wrote: > > could you please test the following series: > > https://patchwork.kernel.org/cover/10764453/ > > yeah this fixed the probing timeout and the driver will probe successful. AFAIK the dwc2 host mode doesn't support scatter-gather yet. So this is either dwc2 scatter-gather problem which should be addressed in this driver or mt76x0u does something wrong when configuring SG. Disabling SG is just workaround, which do not address actual problem. I think I found mt76x0u issue that could cause this USB probe error (and possibly also address AMD IOMMU issue). We seems do not correctly set URB transfer length smaller than sg buffer length. Attached patch should correct that. Stanislaw --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-mt76x02-usb-mcu-limit-sg-length.patch" >From bc09bc7fa604019a5ef90184390e7c2a3899869d Mon Sep 17 00:00:00 2001 From: Stanislaw Gruszka Date: Sun, 10 Feb 2019 08:09:48 +0100 Subject: [PATCH] mt76x02: usb_mcu: limit sg length When sending fw data we limting urb transfer length by changing buf->len, while keeping segment length at max_payload value. That may confuse underlying drivers responsible for DMA. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c index da299b8a1334..cfa14506eca6 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c @@ -287,6 +287,7 @@ __mt76x02u_mcu_fw_send_data(struct mt76x02_dev *dev, struct mt76u_buf *buf, MT_FCE_DMA_LEN, len << 16); buf->len = MT_CMD_HDR_LEN + len + sizeof(info); + buf->urb->sg[0].length = buf->len; err = mt76u_submit_buf(&dev->mt76, USB_DIR_OUT, MT_EP_OUT_INBAND_CMD, buf, GFP_KERNEL, -- 2.19.2 --bp/iNruPH9dso1Pn--