From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH v2] rtc: isl1208: Add new style nvmem support to driver
Date: Sun, 10 Feb 2019 22:18:51 +0100 [thread overview]
Message-ID: <20190210211851.GI23062@piout.net> (raw)
In-Reply-To: <20190205174139.1383-1-tpiepho@impinj.com>
Hi,
On 05/02/2019 17:41:49+0000, Trent Piepho wrote:
> +static const struct nvmem_config isl1208_nvmem_config = {
> + .name = "isl1208_nvram",
> + .word_size = 1,
> + .stride = 1,
> + /* .size from chip specific config */
> + .reg_read = isl1208_nvmem_read,
> + .reg_write = isl1208_nvmem_write,
Can you also set .type here?
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-02-10 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 17:41 [PATCH v2] rtc: isl1208: Add new style nvmem support to driver Trent Piepho
2019-02-10 21:18 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210211851.GI23062@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-rtc@vger.kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.