From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 08/12] drm/tinydrm/repaper: Drop using tinydrm_device Date: Sun, 10 Feb 2019 22:25:36 +0100 Message-ID: <20190210212536.GD2983@ravnborg.org> References: <20190210131039.52664-1-noralf@tronnes.org> <20190210131039.52664-9-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FB5B6E10B for ; Sun, 10 Feb 2019 21:25:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190210131039.52664-9-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLgoKT25lIGRldGFpbCBiZWxvdy4gV2hlbiBhZGRyZXNzZWQgeW91IGNhbiBhZGQg bXk6ClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+CgoJU2FtCgpP biBTdW4sIEZlYiAxMCwgMjAxOSBhdCAwMjoxMDozNVBNICswMTAwLCBOb3JhbGYgVHLDuG5uZXMg d3JvdGU6Cj4gVXNlIGRldm1fZHJtX2Rldl9pbml0KCkgYW5kIGRyb3AgdXNpbmcgdGlueWRybV9k ZXZpY2UuCj4gCj4gdjI6IGRldm1fZHJtX2Rldl9yZWdpc3RlcigpIHdhcyBkcm9wcGVkIHNvIGFk ZCBhIGRyaXZlciByZWxlYXNlIGNhbGxiYWNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBU csO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdGlu eWRybS9yZXBhcGVyLmMgfCA4NCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVwYXBlci5jIGIvZHJpdmVycy9ncHUv ZHJtL3Rpbnlkcm0vcmVwYXBlci5jCj4gaW5kZXggYTMyZGRhMDk0NThhLi5iMWFjZjVhZWJlMzIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVwYXBlci5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vcmVwYXBlci5jCj4gQEAgLTMwLDExICszMCwxMiBAQAo+ ICAjaW5jbHVkZSA8ZHJtL2RybV9kYW1hZ2VfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X2Rydi5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9jbWFfaGVscGVyLmg+Cj4gKyNpbmNsdWRl IDxkcm0vZHJtX2ZiX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fY21hX2hlbHBl ci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gICNp bmNsdWRlIDxkcm0vZHJtX3JlY3QuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fdmJsYW5rLmg+Cj4g LSNpbmNsdWRlIDxkcm0vdGlueWRybS90aW55ZHJtLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX3Np bXBsZV9rbXNfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vdGlueWRybS90aW55ZHJtLWhlbHBl cnMuaD4KPiAgCj4gICNkZWZpbmUgUkVQQVBFUl9SSURfRzJfQ09HX0lECTB4MTIKPiBAQCAtNjAs NyArNjEsOCBAQCBlbnVtIHJlcGFwZXJfZXBkX2JvcmRlcl9ieXRlIHsKPiAgfTsKPiAgCj4gIHN0 cnVjdCByZXBhcGVyX2VwZCB7Cj4gLQlzdHJ1Y3QgdGlueWRybV9kZXZpY2UgdGlueWRybTsKPiAr CXN0cnVjdCBkcm1fZGV2aWNlIGRybTsKPiArCXN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlw ZSBwaXBlOwo+ICAJc3RydWN0IHNwaV9kZXZpY2UgKnNwaTsKPiAgCj4gIAlzdHJ1Y3QgZ3Bpb19k ZXNjICpwYW5lbF9vbjsKPiBAQCAtODksMTAgKzkxLDkgQEAgc3RydWN0IHJlcGFwZXJfZXBkIHsK PiAgCWJvb2wgcGFydGlhbDsKPiAgfTsKPiAgCj4gLXN0YXRpYyBpbmxpbmUgc3RydWN0IHJlcGFw ZXJfZXBkICoKPiAtZXBkX2Zyb21fdGlueWRybShzdHJ1Y3QgdGlueWRybV9kZXZpY2UgKnRkZXYp Cj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IHJlcGFwZXJfZXBkICpkcm1fdG9fZXBkKHN0cnVjdCBk cm1fZGV2aWNlICpkcm0pCj4gIHsKPiAtCXJldHVybiBjb250YWluZXJfb2YodGRldiwgc3RydWN0 IHJlcGFwZXJfZXBkLCB0aW55ZHJtKTsKPiArCXJldHVybiBjb250YWluZXJfb2YoZHJtLCBzdHJ1 Y3QgcmVwYXBlcl9lcGQsIGRybSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgcmVwYXBlcl9zcGlf dHJhbnNmZXIoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSwgdTggaGVhZGVyLAo+IEBAIC01MzAsOCAr NTMxLDcgQEAgc3RhdGljIGludCByZXBhcGVyX2ZiX2RpcnR5KHN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZiKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2dlbV9jbWFfb2JqZWN0ICpjbWFfb2JqID0gZHJt X2ZiX2NtYV9nZXRfZ2VtX29iaihmYiwgMCk7Cj4gIAlzdHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50 ICppbXBvcnRfYXR0YWNoID0gY21hX29iai0+YmFzZS5pbXBvcnRfYXR0YWNoOwo+IC0Jc3RydWN0 IHRpbnlkcm1fZGV2aWNlICp0ZGV2ID0gZmItPmRldi0+ZGV2X3ByaXZhdGU7Cj4gLQlzdHJ1Y3Qg cmVwYXBlcl9lcGQgKmVwZCA9IGVwZF9mcm9tX3Rpbnlkcm0odGRldik7Cj4gKwlzdHJ1Y3QgcmVw YXBlcl9lcGQgKmVwZCA9IGRybV90b19lcGQoZmItPmRldik7Cj4gIAlzdHJ1Y3QgZHJtX3JlY3Qg Y2xpcDsKPiAgCXU4ICpidWYgPSBOVUxMOwo+ICAJaW50IHJldCA9IDA7Cj4gQEAgLTY0Niw4ICs2 NDYsNyBAQCBzdGF0aWMgdm9pZCByZXBhcGVyX3BpcGVfZW5hYmxlKHN0cnVjdCBkcm1fc2ltcGxl X2Rpc3BsYXlfcGlwZSAqcGlwZSwKPiAgCQkJCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSwKPiAgCQkJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICB7Cj4g LQlzdHJ1Y3QgdGlueWRybV9kZXZpY2UgKnRkZXYgPSBwaXBlX3RvX3Rpbnlkcm0ocGlwZSk7Cj4g LQlzdHJ1Y3QgcmVwYXBlcl9lcGQgKmVwZCA9IGVwZF9mcm9tX3Rpbnlkcm0odGRldik7Cj4gKwlz dHJ1Y3QgcmVwYXBlcl9lcGQgKmVwZCA9IGRybV90b19lcGQocGlwZS0+Y3J0Yy5kZXYpOwo+ICAJ c3RydWN0IHNwaV9kZXZpY2UgKnNwaSA9IGVwZC0+c3BpOwo+ICAJc3RydWN0IGRldmljZSAqZGV2 ID0gJnNwaS0+ZGV2Owo+ICAJYm9vbCBkY19vayA9IGZhbHNlOwo+IEBAIC03ODEsOCArNzgwLDcg QEAgc3RhdGljIHZvaWQgcmVwYXBlcl9waXBlX2VuYWJsZShzdHJ1Y3QgZHJtX3NpbXBsZV9kaXNw bGF5X3BpcGUgKnBpcGUsCj4gIAo+ICBzdGF0aWMgdm9pZCByZXBhcGVyX3BpcGVfZGlzYWJsZShz dHJ1Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgKnBpcGUpCj4gIHsKPiAtCXN0cnVjdCB0aW55 ZHJtX2RldmljZSAqdGRldiA9IHBpcGVfdG9fdGlueWRybShwaXBlKTsKPiAtCXN0cnVjdCByZXBh cGVyX2VwZCAqZXBkID0gZXBkX2Zyb21fdGlueWRybSh0ZGV2KTsKPiArCXN0cnVjdCByZXBhcGVy X2VwZCAqZXBkID0gZHJtX3RvX2VwZChwaXBlLT5jcnRjLmRldik7Cj4gIAlzdHJ1Y3Qgc3BpX2Rl dmljZSAqc3BpID0gZXBkLT5zcGk7Cj4gIAl1bnNpZ25lZCBpbnQgbGluZTsKPiAgCj4gQEAgLTg1 Niw2ICs4NTQsMjMgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlw ZV9mdW5jcyByZXBhcGVyX3BpcGVfZnVuY3MgPSB7Cj4gIAkucHJlcGFyZV9mYiA9IGRybV9nZW1f ZmJfc2ltcGxlX2Rpc3BsYXlfcGlwZV9wcmVwYXJlX2ZiLAo+ICB9Owo+ICAKPiArc3RhdGljIGNv bnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgcmVwYXBlcl9tb2RlX2NvbmZpZ19mdW5j cyA9IHsKPiArCS5mYl9jcmVhdGUgPSBkcm1fZ2VtX2ZiX2NyZWF0ZV93aXRoX2RpcnR5LAo+ICsJ LmF0b21pY19jaGVjayA9IGRybV9hdG9taWNfaGVscGVyX2NoZWNrLAo+ICsJLmF0b21pY19jb21t aXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXQsCj4gK307Cj4gKwo+ICtzdGF0aWMgdm9pZCBy ZXBhcGVyX3JlbGVhc2Uoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiArewo+ICsJc3RydWN0IHJl cGFwZXJfZXBkICplcGQgPSBkcm1fdG9fZXBkKGRybSk7Cj4gKwo+ICsJRFJNX0RFQlVHX0RSSVZF UigiXG4iKTsKPiArCj4gKwlkcm1fbW9kZV9jb25maWdfY2xlYW51cChkcm0pOwo+ICsJZHJtX2Rl dl9maW5pKGRybSk7Cj4gKwlrZnJlZShlcGQpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgY29uc3QgdWlu dDMyX3QgcmVwYXBlcl9mb3JtYXRzW10gPSB7Cj4gIAlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ICB9 Owo+IEBAIC04OTQsNiArOTA5LDcgQEAgc3RhdGljIHN0cnVjdCBkcm1fZHJpdmVyIHJlcGFwZXJf ZHJpdmVyID0gewo+ICAJLmRyaXZlcl9mZWF0dXJlcwk9IERSSVZFUl9HRU0gfCBEUklWRVJfTU9E RVNFVCB8IERSSVZFUl9QUklNRSB8Cj4gIAkJCQkgIERSSVZFUl9BVE9NSUMsCj4gIAkuZm9wcwkJ CT0gJnJlcGFwZXJfZm9wcywKPiArCS5yZWxlYXNlCQk9IHJlcGFwZXJfcmVsZWFzZSwKPiAgCURS TV9HRU1fQ01BX1ZNQVBfRFJJVkVSX09QUywKPiAgCS5uYW1lCQkJPSAicmVwYXBlciIsCj4gIAku ZGVzYwkJCT0gIlBlcnZhc2l2ZSBEaXNwbGF5cyBSZVBhcGVyIGUtaW5rIHBhbmVscyIsCj4gQEAg LTkyNiwxMSArOTQyLDExIEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9wcm9iZShzdHJ1Y3Qgc3BpX2Rl dmljZSAqc3BpKQo+ICAJY29uc3Qgc3RydWN0IHNwaV9kZXZpY2VfaWQgKnNwaV9pZDsKPiAgCWNv bnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm1hdGNoOwo+ICAJc3RydWN0IGRldmljZSAqZGV2ID0g JnNwaS0+ZGV2Owo+IC0Jc3RydWN0IHRpbnlkcm1fZGV2aWNlICp0ZGV2Owo+ICAJZW51bSByZXBh cGVyX21vZGVsIG1vZGVsOwo+ICAJY29uc3QgY2hhciAqdGhlcm1hbF96b25lOwo+ICAJc3RydWN0 IHJlcGFwZXJfZXBkICplcGQ7Cj4gIAlzaXplX3QgbGluZV9idWZmZXJfc2l6ZTsKPiArCXN0cnVj dCBkcm1fZGV2aWNlICpkcm07Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCW1hdGNoID0gb2ZfbWF0Y2hf ZGV2aWNlKHJlcGFwZXJfb2ZfbWF0Y2gsIGRldik7Cj4gQEAgLTk1MCwxMCArOTY2LDIxIEBAIHN0 YXRpYyBpbnQgcmVwYXBlcl9wcm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICAJCX0KPiAg CX0KPiAgCj4gLQllcGQgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmVwZCksIEdGUF9LRVJO RUwpOwo+ICsJZXBkID0ga3phbGxvYyhzaXplb2YoKmVwZCksIEdGUF9LRVJORUwpOwo+ICAJaWYg KCFlcGQpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICsJZHJtID0gJmVwZC0+ZHJtOwo+ICsK PiArCXJldCA9IGRldm1fZHJtX2Rldl9pbml0KGRldiwgZHJtLCAmcmVwYXBlcl9kcml2ZXIpOwo+ ICsJaWYgKHJldCkgewo+ICsJCWtmcmVlKGVwZCk7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiAr Cj4gKwlkcm1fbW9kZV9jb25maWdfaW5pdChkcm0pOwo+ICsJZHJtLT5tb2RlX2NvbmZpZy5mdW5j cyA9ICZyZXBhcGVyX21vZGVfY29uZmlnX2Z1bmNzOwo+ICsKPiAgCWVwZC0+c3BpID0gc3BpOwo+ ICAKPiAgCWVwZC0+cGFuZWxfb24gPSBkZXZtX2dwaW9kX2dldChkZXYsICJwYW5lbC1vbiIsIEdQ SU9EX09VVF9MT1cpOwo+IEBAIC0xMDY0LDI2ICsxMDkxLDM2IEBAIHN0YXRpYyBpbnQgcmVwYXBl cl9wcm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICAJaWYgKCFlcGQtPmN1cnJlbnRfZnJh bWUpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JdGRldiA9ICZlcGQtPnRpbnlkcm07Cj4g LQo+IC0JcmV0ID0gZGV2bV90aW55ZHJtX2luaXQoZGV2LCB0ZGV2LCAmcmVwYXBlcl9kcml2ZXIp Owo+IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAtCXJldCA9IHRpbnlkcm1fZGlz cGxheV9waXBlX2luaXQodGRldi0+ZHJtLCAmdGRldi0+cGlwZSwgJnJlcGFwZXJfcGlwZV9mdW5j cywKPiArCXJldCA9IHRpbnlkcm1fZGlzcGxheV9waXBlX2luaXQoZHJtLCAmZXBkLT5waXBlLCAm cmVwYXBlcl9waXBlX2Z1bmNzLAo+ICAJCQkJCURSTV9NT0RFX0NPTk5FQ1RPUl9WSVJUVUFMLAo+ ICAJCQkJCXJlcGFwZXJfZm9ybWF0cywKPiAgCQkJCQlBUlJBWV9TSVpFKHJlcGFwZXJfZm9ybWF0 cyksIG1vZGUsIDApOwo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0OwpEbyB3ZSBsZWFrIGVw ZCBoZXJlPwooSSByZWNhbGwgd2UgYWxyZWFkeSBkaXNjdXNzZWQgdGhpcywgYnV0IEkgYW0gbm90 IHN1cmUuLi4pCgpJZiB0aGlzIGluIGhhbmRsZWQgYnkgZGV2bV9kcm1fZGV2X2luaXQoKSB0aGVu IG1heWJlIGFkZCAgY29tbWVudCBhYm91dAppdCBpbiB0aGUgZXhhbXBsZSBwcm92aWRlZCBpbiBw cmV2aW91cyBwYXRjaC4KCj4gIAo+IC0JZHJtX21vZGVfY29uZmlnX3Jlc2V0KHRkZXYtPmRybSk7 Cj4gKwlkcm1fbW9kZV9jb25maWdfcmVzZXQoZHJtKTsKPiAgCj4gLQlzcGlfc2V0X2RydmRhdGEo c3BpLCB0ZGV2LT5kcm0pOwo+ICsJcmV0ID0gZHJtX2Rldl9yZWdpc3Rlcihkcm0sIDApOwo+ICsJ aWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXNwaV9zZXRfZHJ2ZGF0YShzcGksIGRy bSk7Cj4gIAo+ICAJRFJNX0RFQlVHX0RSSVZFUigiU1BJIHNwZWVkOiAldU1IelxuIiwgc3BpLT5t YXhfc3BlZWRfaHogLyAxMDAwMDAwKTsKPiAgCj4gLQlyZXR1cm4gZGV2bV90aW55ZHJtX3JlZ2lz dGVyKHRkZXYpOwo+ICsJZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoZHJtLCAzMik7Cj4gKwo+ICsJ cmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcmVwYXBlcl9yZW1vdmUoc3RydWN0IHNw aV9kZXZpY2UgKnNwaSkKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IHNwaV9nZXRf ZHJ2ZGF0YShzcGkpOwo+ICsKPiArCWRybV9kZXZfdW5wbHVnKGRybSk7ClRoZSBzYW1wbGUgY29k ZSB1c2VzIGRybV9kZXZfdW5yZWdpc3RlcigpIGhlcmU/CgoKPiArCWRybV9hdG9taWNfaGVscGVy X3NodXRkb3duKGRybSk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lk IHJlcGFwZXJfc2h1dGRvd24oc3RydWN0IHNwaV9kZXZpY2UgKnNwaSkKPiBAQCAtMTA5OSw2ICsx MTM2LDcgQEAgc3RhdGljIHN0cnVjdCBzcGlfZHJpdmVyIHJlcGFwZXJfc3BpX2RyaXZlciA9IHsK PiAgCX0sCj4gIAkuaWRfdGFibGUgPSByZXBhcGVyX2lkLAo+ICAJLnByb2JlID0gcmVwYXBlcl9w cm9iZSwKPiArCS5yZW1vdmUgPSByZXBhcGVyX3JlbW92ZSwKPiAgCS5zaHV0ZG93biA9IHJlcGFw ZXJfc2h1dGRvd24sCj4gIH07Cj4gIG1vZHVsZV9zcGlfZHJpdmVyKHJlcGFwZXJfc3BpX2RyaXZl cik7Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=