From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 09/12] drm/tinydrm: Drop using tinydrm_device Date: Sun, 10 Feb 2019 22:27:56 +0100 Message-ID: <20190210212756.GE2983@ravnborg.org> References: <20190210131039.52664-1-noralf@tronnes.org> <20190210131039.52664-10-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14D556E10C for ; Sun, 10 Feb 2019 21:27:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190210131039.52664-10-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLgoKT24gU3VuLCBGZWIgMTAsIDIwMTkgYXQgMDI6MTA6MzZQTSArMDEwMCwgTm9y YWxmIFRyw7hubmVzIHdyb3RlOgo+IFVzZSBkZXZtX2RybV9kZXZfaW5pdCgpIGFuZCBkcm9wIHVz aW5nIHRpbnlkcm1fZGV2aWNlLgo+IAo+IHYyOiBkZXZtX2RybV9kZXZfcmVnaXN0ZXIoKSB3YXMg ZHJvcHBlZCBzbyBhZGQgZHJpdmVyIHJlbGVhc2UgY2FsbGJhY2tzLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vdGlueWRybS9oeDgzNTdkLmMgIHwgIDQwICsrKysrKysrKy0tCj4gIGRyaXZlcnMv Z3B1L2RybS90aW55ZHJtL2lsaTkyMjUuYyAgfCAgNDAgKysrKysrKysrLS0KPiAgZHJpdmVycy9n cHUvZHJtL3Rpbnlkcm0vaWxpOTM0MS5jICB8ICA0MCArKysrKysrKystLQo+ICBkcml2ZXJzL2dw dS9kcm0vdGlueWRybS9taTAyODNxdC5jIHwgIDQwICsrKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1 L2RybS90aW55ZHJtL21pcGktZGJpLmMgfCAgNjcgKysrKysrKysrKystLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS90aW55ZHJtL3N0NzU4Ni5jICAgfCAxMDUgKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vc3Q3NzM1ci5jICB8ICA0MCArKysr KysrKystLQo+ICBpbmNsdWRlL2RybS90aW55ZHJtL21pcGktZGJpLmggICAgIHwgIDI2ICsrKyst LS0KPiAgOCBmaWxlcyBjaGFuZ2VkLCAyOTQgaW5zZXJ0aW9ucygrKSwgMTA0IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9oeDgzNTdkLmMgYi9k cml2ZXJzL2dwdS9kcm0vdGlueWRybS9oeDgzNTdkLmMKPiBpbmRleCA4NGRkYTYyMmRmODUuLmU5 YjllMDhmYWZjNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9oeDgzNTdk LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9oeDgzNTdkLmMKPiBAQCAtMTgsNiAr MTgsNyBAQAo+ICAKPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICAjaW5j bHVkZSA8ZHJtL2RybV9kcnYuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4g ICNpbmNsdWRlIDxkcm0vZHJtX2dlbV9jbWFfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fbW9kZXNldF9o ZWxwZXIuaD4KPiBAQCAtMTg5LDYgKzE5MCw3IEBAIERFRklORV9EUk1fR0VNX0NNQV9GT1BTKGh4 ODM1N2RfZm9wcyk7Cj4gIHN0YXRpYyBzdHJ1Y3QgZHJtX2RyaXZlciBoeDgzNTdkX2RyaXZlciA9 IHsKPiAgCS5kcml2ZXJfZmVhdHVyZXMJPSBEUklWRVJfR0VNIHwgRFJJVkVSX01PREVTRVQgfCBE UklWRVJfUFJJTUUgfCBEUklWRVJfQVRPTUlDLAo+ICAJLmZvcHMJCQk9ICZoeDgzNTdkX2ZvcHMs Cj4gKwkucmVsZWFzZQkJPSBtaXBpX2RiaV9yZWxlYXNlLAo+ICAJRFJNX0dFTV9DTUFfVk1BUF9E UklWRVJfT1BTLAo+ICAJLmRlYnVnZnNfaW5pdAkJPSBtaXBpX2RiaV9kZWJ1Z2ZzX2luaXQsCj4g IAkubmFtZQkJCT0gImh4ODM1N2QiLAo+IEBAIC0yMTMsMTUgKzIxNSwyNSBAQCBNT0RVTEVfREVW SUNFX1RBQkxFKHNwaSwgaHg4MzU3ZF9pZCk7Cj4gIHN0YXRpYyBpbnQgaHg4MzU3ZF9wcm9iZShz dHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ICB7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmc3Bp LT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtOwo+ICAJc3RydWN0IG1pcGlfZGJpICpt aXBpOwo+ICAJc3RydWN0IGdwaW9fZGVzYyAqZGM7Cj4gIAl1MzIgcm90YXRpb24gPSAwOwo+ICAJ aW50IHJldDsKPiAgCj4gLQltaXBpID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCptaXBpKSwg R0ZQX0tFUk5FTCk7Cj4gKwltaXBpID0ga3phbGxvYyhzaXplb2YoKm1pcGkpLCBHRlBfS0VSTkVM KTsKPiAgCWlmICghbWlwaSkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gKwlkcm0gPSAmbWlw aS0+ZHJtOwo+ICsJcmV0ID0gZGV2bV9kcm1fZGV2X2luaXQoZGV2LCBkcm0sICZoeDgzNTdkX2Ry aXZlcik7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJa2ZyZWUobWlwaSk7Cj4gKwkJcmV0dXJuIHJldDsK PiArCX0KPiArCj4gKwlkcm1fbW9kZV9jb25maWdfaW5pdChkcm0pOwo+ICsKPiAgCWRjID0gZGV2 bV9ncGlvZF9nZXQoZGV2LCAiZGMiLCBHUElPRF9PVVRfTE9XKTsKPiAgCWlmIChJU19FUlIoZGMp KSB7Cj4gIAkJRFJNX0RFVl9FUlJPUihkZXYsICJGYWlsZWQgdG8gZ2V0IGdwaW8gJ2RjJ1xuIik7 Cj4gQEAgLTIzOCwxNCArMjUwLDMxIEBAIHN0YXRpYyBpbnQgaHg4MzU3ZF9wcm9iZShzdHJ1Y3Qg c3BpX2RldmljZSAqc3BpKQo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiAtCXJl dCA9IG1pcGlfZGJpX2luaXQoJnNwaS0+ZGV2LCBtaXBpLCAmaHg4MzU3ZF9waXBlX2Z1bmNzLAo+ IC0JCQkgICAgJmh4ODM1N2RfZHJpdmVyLCAmeXgzNTBodjE1X21vZGUsIHJvdGF0aW9uKTsKPiAr CXJldCA9IG1pcGlfZGJpX2luaXQobWlwaSwgJmh4ODM1N2RfcGlwZV9mdW5jcywgJnl4MzUwaHYx NV9tb2RlLCByb3RhdGlvbik7Cj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0J c3BpX3NldF9kcnZkYXRhKHNwaSwgbWlwaS0+dGlueWRybS5kcm0pOwo+ICsJZHJtX21vZGVfY29u ZmlnX3Jlc2V0KGRybSk7Cj4gIAo+IC0JcmV0dXJuIGRldm1fdGlueWRybV9yZWdpc3RlcigmbWlw aS0+dGlueWRybSk7Cj4gKwlyZXQgPSBkcm1fZGV2X3JlZ2lzdGVyKGRybSwgMCk7Cj4gKwlpZiAo cmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJc3BpX3NldF9kcnZkYXRhKHNwaSwgZHJtKTsK PiArCj4gKwlkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cChkcm0sIDMyKTsKPiArCj4gKwlyZXR1cm4g MDsKPiArfQo+ICsKPiArc3RhdGljIGludCBoeDgzNTdkX3JlbW92ZShzdHJ1Y3Qgc3BpX2Rldmlj ZSAqc3BpKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtID0gc3BpX2dldF9kcnZkYXRh KHNwaSk7Cj4gKwo+ICsJZHJtX2Rldl91bnBsdWcoZHJtKTsKPiArCWRybV9hdG9taWNfaGVscGVy X3NodXRkb3duKGRybSk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KVGhlIHNhbXBsZSBjb2RlIHVz ZXMgZHJtX2Rldl91bnJlZ2lzdGVyKCkgaW4gdGhlIF9yZW1vdmUoKSBmdW5jdGlvbi4KRG8gSSBt aXNzIHNvbWV0aGluZyBvYnZpb3VzPwoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK