From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9E3C169C4 for ; Mon, 11 Feb 2019 06:56:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A56720838 for ; Mon, 11 Feb 2019 06:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DrZBX0mS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A56720838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2u30C7U3Re1+O9IZtFmDKs/3X2KgeAB6Qkmbk5OUq8=; b=DrZBX0mSM5o2o/ 9Gpd60qVfrinHHq7YM/KLtjg632HkybUzicUgDASOsnMyDG/KXUlm91mI9ZRfM3UwRMjjjw05lieQ jTYNL2SGAw4EgwdvHs827NSmXMp5h0iG2id3h+bbASvwBS44/fpDYQQoUnmXqygKTqMkGhTkxsW9w 47WFdsDQedDPORnAqlR6b/v0LY6gugl3N5hqYHBfsDJqalV3F5UlMtMBhxDCjQNGhXegvibj8Tf2l 8Kd8xyJ7sw698zUTM8z4MkMgbEpJyM2WO+8acMHZTnQIwPJq3B/7oV981vh91hoZDwzH0iHud/PGO pdQx7CjbRbo9fD1F7Fyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt5Vg-0001lQ-S9; Mon, 11 Feb 2019 06:56:08 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt5Vc-0001jN-KE for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 06:56:07 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8EC1620030; Mon, 11 Feb 2019 07:55:53 +0100 (CET) Date: Mon, 11 Feb 2019 07:55:52 +0100 From: Sam Ravnborg To: "Hean-Loong, Ong" Subject: Re: [PATCHv12 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite Message-ID: <20190211065552.GA7010@ravnborg.org> References: <20190211060926.3433-1-hean.loong.ong@intel.com> <20190211060926.3433-4-hean.loong.ong@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190211060926.3433-4-hean.loong.ong@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=yBYpec10AAAA:8 a=fjobobjgAAAA:8 a=QyXUC8HyAAAA:8 a=jbnKnBcKNtAAbXgpOMQA:9 a=aegFic2g-LuQCSZJ:21 a=er5hxFpQ-oadSlK4:21 a=CjuIK1q_8ugA:10 a=zbxmTX4fiVD2UiCe4Dha:22 a=PlEKnuvBpV2Z9KzPMKMm:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190210_225605_025782_664D3B5E X-CRM114-Status: GOOD ( 21.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rienk de Jong , yves.vandervennet@intel.com, chin.liang.see@intel.com, linux-kernel@vger.kernel.org, Rob Herring , Dinh Nguyen , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org, Ong@freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hean-Loong, Ong Patch looks good to me, but there is a few trivial things I spotted while browsing the code. See below. Sam > +++ b/drivers/gpu/drm/ivip/Makefile > @@ -0,0 +1,7 @@ > +# > +# Makefile for the drm device driver. This driver provides support for the > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > + > +obj-$(CONFIG_DRM_IVIP) += ivip.o > +ivip-objs := intel_vip_of.o intel_vip_core.o \ > + intel_vip_conn.o You could use: ivip-y := intel_vip_of.o intel_vip_core.o ivip-y += intel_vip_conn.o Using "ivip-y" is the recommend syntax today. And using "+=" you get rid of the ugly "\" to continue a line. (Some people prefer "\" in makefiles, but there are not needed) > +++ b/drivers/gpu/drm/ivip/intel_vip_core.c > @@ -0,0 +1,189 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Intel Corporation. > + * > + * intel_vip_core.c -- Intel Video and Image Processing(VIP) > + * Frame Buffer II driver > + * > + * This driver supports the Intel VIP Frame Reader component. > + * More info on the hardware can be found in the Intel Video > + * and Image Processing Suite User Guide at this address > + * http://www.altera.com/literature/ug/ug_vip.pdf. > + * > + * Authors: > + * Walter Goossens > + * Thomas Chou > + * Chris Rauer > + * Ong, Hean-Loong > + * > + */ > + > +#include Please do not use drmP.h in new drivers, we try to get rid of this file. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Sort the list of include files. (Looks like this was properly done before, and only one file is out of palce) > +static void intelvipfb_enable(struct drm_simple_display_pipe *pipe, > + struct drm_crtc_state *crtc_state, struct drm_plane_state * > + plane_state) Fix indent. The parameters on second line and following should be aligned below the opening paranthesis. Use tab(s) + spaces to align properly. > +void intelvipfb_display_pipe_update(struct drm_simple_display_pipe *pipe, > + struct drm_plane_state *old_state) Align parameter > +} > +EXPORT_SYMBOL(intelvipfb_display_pipe_update); > + > +static struct drm_simple_display_pipe_funcs fbpriv_funcs = { > + .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, > + .update = intelvipfb_display_pipe_update, > + .enable = intelvipfb_enable, > + .disable = intelvipfb_disable, > +}; > + > + > +int intelvipfb_probe(struct device *dev) > +{ > + int retval; > + struct drm_device *drm; > + struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev); > + > + struct drm_connector *connector; > + u32 formats[] = {DRM_FORMAT_XRGB8888}; > + > + drm = fbpriv->drm; > + > + drm->dev_private = fbpriv; It would be simpler to just pass fbpriv as a parameter. There is only one user of intelvipfb_probe() so no need to avoid it. Also it would be more logical to set drm = fbpriv->drm; where memory are allocated. > + > + intelvipfb_setup_mode_config(drm); > + > + connector = intelvipfb_conn_setup(drm); > + if (!connector) { > + dev_err(drm->dev, "Connector setup failed\n"); > + goto err_mode_config; > + } > + > + retval = drm_simple_display_pipe_init(drm, > + &fbpriv->pipe, > + &fbpriv_funcs, > + formats, > + ARRAY_SIZE(formats), > + NULL, connector); Consider indent, where subsequent parameters are aligned right after the opening '('. > + > + if (retval < 0) { > + dev_err(drm->dev, "Cannot setup simple display pipe\n"); > + goto err_mode_config; > + } > + > + drm_mode_config_reset(drm); > + > + drm_dev_register(drm, 0); > + > + drm_fbdev_generic_setup(drm, 32); > + > + dev_info(drm->dev, "ivip: Successfully created fb\n"); > + > + return retval; > + > +err_mode_config: > + > + drm_mode_config_cleanup(drm); > + return -ENODEV; > +} > + > diff --git a/drivers/gpu/drm/ivip/intel_vip_of.c b/drivers/gpu/drm/ivip/intel_vip_of.c > new file mode 100644 > index 0000000..c899e30 > --- /dev/null > +++ b/drivers/gpu/drm/ivip/intel_vip_of.c > @@ -0,0 +1,181 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Intel Corporation. > + * > + * intel_vip_of.c -- Intel Video and Image Processing(VIP) > + * Frame Buffer II driver The need for this file confuses me. It does not include only "of" related stuff, but also generic device driver stuff. Maybe merge with intel_vip_core.c? And rename that file to intel_vip_drv.c? > + * > + * This driver supports the Intel VIP Frame Reader component. > + * More info on the hardware can be found in the Intel Video > + * and Image Processing Suite User Guide at this address > + * http://www.altera.com/literature/ug/ug_vip.pdf. > + * > + * Authors: > + * Ong, Hean-Loong > + * > + */ > +#include Drop use of drmP.h > +static int intelvipfb_of_probe(struct platform_device *pdev) > +{ > + int retval; > + struct resource *reg_res; > + struct intelvipfb_priv *fbpriv; > + struct device *dev = &pdev->dev; > + struct drm_device *drm; > + > + fbpriv = devm_kzalloc(dev, sizeof(*fbpriv), GFP_KERNEL); > + if (!fbpriv) > + return -ENOMEM; > + > + /*setup DRM */ Space before "setup" > + > +static const struct of_device_id intelvipfb_of_match[] = { > + { .compatible = "altr,vip-frame-buffer-2.0" }, > + {}, Maybe add "/* sentinel */" comment? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCHv12 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite Date: Mon, 11 Feb 2019 07:55:52 +0100 Message-ID: <20190211065552.GA7010@ravnborg.org> References: <20190211060926.3433-1-hean.loong.ong@intel.com> <20190211060926.3433-4-hean.loong.ong@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190211060926.3433-4-hean.loong.ong@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Hean-Loong, Ong" Cc: devicetree@vger.kernel.org, Rienk de Jong , yves.vandervennet@intel.com, chin.liang.see@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dinh Nguyen , Rob Herring , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Ong@freedesktop.org List-Id: devicetree@vger.kernel.org SGkgSGVhbi1Mb29uZywgT25nCgpQYXRjaCBsb29rcyBnb29kIHRvIG1lLCBidXQgdGhlcmUgaXMg YSBmZXcgdHJpdmlhbAp0aGluZ3MgSSBzcG90dGVkIHdoaWxlIGJyb3dzaW5nIHRoZSBjb2RlLgpT ZWUgYmVsb3cuCgoJU2FtCgo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pdmlwL01ha2VmaWxlCj4g QEAgLTAsMCArMSw3IEBACj4gKyMKPiArIyBNYWtlZmlsZSBmb3IgdGhlIGRybSBkZXZpY2UgZHJp dmVyLiAgVGhpcyBkcml2ZXIgcHJvdmlkZXMgc3VwcG9ydCBmb3IgdGhlCj4gKyMgRGlyZWN0IFJl bmRlcmluZyBJbmZyYXN0cnVjdHVyZSAoRFJJKSBpbiBYRnJlZTg2IDQuMS4wIGFuZCBoaWdoZXIu Cj4gKwo+ICtvYmotJChDT05GSUdfRFJNX0lWSVApICs9IGl2aXAubwo+ICtpdmlwLW9ianMgOj0g aW50ZWxfdmlwX29mLm8gaW50ZWxfdmlwX2NvcmUubyBcCj4gKwlpbnRlbF92aXBfY29ubi5vCgpZ b3UgY291bGQgdXNlOgppdmlwLXkgOj0gaW50ZWxfdmlwX29mLm8gaW50ZWxfdmlwX2NvcmUubwpp dmlwLXkgKz0gaW50ZWxfdmlwX2Nvbm4ubwoKClVzaW5nICJpdmlwLXkiIGlzIHRoZSByZWNvbW1l bmQgc3ludGF4IHRvZGF5LgpBbmQgdXNpbmcgIis9IiB5b3UgZ2V0IHJpZCBvZiB0aGUgdWdseSAi XCIgdG8gY29udGludWUgYSBsaW5lLgooU29tZSBwZW9wbGUgcHJlZmVyICJcIiBpbiBtYWtlZmls ZXMsIGJ1dCB0aGVyZSBhcmUgbm90IG5lZWRlZCkKCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2l2 aXAvaW50ZWxfdmlwX2NvcmUuYwo+IEBAIC0wLDAgKzEsMTg5IEBACj4gKy8vIFNQRFgtTGljZW5z ZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4gKy8qCj4gKyAqIENvcHlyaWdodCAoQykgMjAxOSBJbnRl bCBDb3Jwb3JhdGlvbi4KPiArICoKPiArICogaW50ZWxfdmlwX2NvcmUuYyAtLSBJbnRlbCBWaWRl byBhbmQgSW1hZ2UgUHJvY2Vzc2luZyhWSVApCj4gKyAqIEZyYW1lIEJ1ZmZlciBJSSBkcml2ZXIK PiArICoKPiArICogVGhpcyBkcml2ZXIgc3VwcG9ydHMgdGhlIEludGVsIFZJUCBGcmFtZSBSZWFk ZXIgY29tcG9uZW50Lgo+ICsgKiBNb3JlIGluZm8gb24gdGhlIGhhcmR3YXJlIGNhbiBiZSBmb3Vu ZCBpbiB0aGUgSW50ZWwgVmlkZW8KPiArICogYW5kIEltYWdlIFByb2Nlc3NpbmcgU3VpdGUgVXNl ciBHdWlkZSBhdCB0aGlzIGFkZHJlc3MKPiArICogaHR0cDovL3d3dy5hbHRlcmEuY29tL2xpdGVy YXR1cmUvdWcvdWdfdmlwLnBkZi4KPiArICoKPiArICogQXV0aG9yczoKPiArICogV2FsdGVyIEdv b3NzZW5zIDx3YWx0ZXJnb29zc2Vuc0Bob21lLm5sPgo+ICsgKiBUaG9tYXMgQ2hvdSA8dGhvbWFz QHd5dHJvbi5jb20udHc+Cj4gKyAqIENocmlzIFJhdWVyIDxjcmF1ZXJAYWx0ZXJhLmNvbT4KPiAr ICogT25nLCBIZWFuLUxvb25nIDxoZWFuLmxvb25nLm9uZ0BpbnRlbC5jb20+Cj4gKyAqCj4gKyAq Lwo+ICsKPiArI2luY2x1ZGUgPGRybS9kcm1QLmg+ClBsZWFzZSBkbyBub3QgdXNlIGRybVAuaCBp biBuZXcgZHJpdmVycywgd2UgdHJ5IHRvIGdldCByaWQgb2YgdGhpcyBmaWxlLgoKPiArI2luY2x1 ZGUgPGRybS9kcm1fYXRvbWljLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIu aD4KPiArI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIuaD4KPiArI2luY2x1ZGUgPGRybS9k cm1fZmJfaGVscGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX2ZiX2NtYV9oZWxwZXIuaD4KPiAr I2luY2x1ZGUgPGRybS9kcm1fZ2VtX2NtYV9oZWxwZXIuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1f cGxhbmVfaGVscGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmg+ Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuaD4KU29ydCB0aGUg bGlzdCBvZiBpbmNsdWRlIGZpbGVzLgooTG9va3MgbGlrZSB0aGlzIHdhcyBwcm9wZXJseSBkb25l IGJlZm9yZSwgYW5kIG9ubHkgb25lIGZpbGUgaXMgb3V0IG9mIHBhbGNlKQoKCj4gK3N0YXRpYyB2 b2lkIGludGVsdmlwZmJfZW5hYmxlKHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlw ZSwKPiArCSAgICAgICBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsIHN0cnVjdCBk cm1fcGxhbmVfc3RhdGUgKgo+ICsJICAgICAgIHBsYW5lX3N0YXRlKQpGaXggaW5kZW50LiBUaGUg cGFyYW1ldGVycyBvbiBzZWNvbmQgbGluZSBhbmQgZm9sbG93aW5nIHNob3VsZCBiZSBhbGlnbmVk CmJlbG93IHRoZSBvcGVuaW5nIHBhcmFudGhlc2lzLgpVc2UgdGFiKHMpICsgc3BhY2VzIHRvIGFs aWduIHByb3Blcmx5LgoKPiArdm9pZCBpbnRlbHZpcGZiX2Rpc3BsYXlfcGlwZV91cGRhdGUoc3Ry dWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlLAo+ICsJCQkJIHN0cnVjdCBkcm1fcGxh bmVfc3RhdGUgKm9sZF9zdGF0ZSkKQWxpZ24gcGFyYW1ldGVyCgo+ICt9Cj4gK0VYUE9SVF9TWU1C T0woaW50ZWx2aXBmYl9kaXNwbGF5X3BpcGVfdXBkYXRlKTsKPiArCj4gK3N0YXRpYyBzdHJ1Y3Qg ZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfZnVuY3MgZmJwcml2X2Z1bmNzID0gewo+ICsJLnByZXBh cmVfZmIgPSBkcm1fZ2VtX2ZiX3NpbXBsZV9kaXNwbGF5X3BpcGVfcHJlcGFyZV9mYiwKPiArCS51 cGRhdGUgPSBpbnRlbHZpcGZiX2Rpc3BsYXlfcGlwZV91cGRhdGUsCj4gKwkuZW5hYmxlID0gaW50 ZWx2aXBmYl9lbmFibGUsCj4gKwkuZGlzYWJsZSA9IGludGVsdmlwZmJfZGlzYWJsZSwKPiArfTsK PiArCj4gKwo+ICtpbnQgaW50ZWx2aXBmYl9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sK PiArCWludCByZXR2YWw7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtOwo+ICsJc3RydWN0IGlu dGVsdmlwZmJfcHJpdiAqZmJwcml2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ICsJc3Ry dWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiArCXUzMiBmb3JtYXRzW10gPSB7RFJNX0ZP Uk1BVF9YUkdCODg4OH07Cj4gKwo+ICsJZHJtID0gZmJwcml2LT5kcm07Cj4gKwo+ICsJZHJtLT5k ZXZfcHJpdmF0ZSA9IGZicHJpdjsKCkl0IHdvdWxkIGJlIHNpbXBsZXIgdG8ganVzdCBwYXNzIGZi cHJpdiBhcyBhIHBhcmFtZXRlci4KVGhlcmUgaXMgb25seSBvbmUgdXNlciBvZiBpbnRlbHZpcGZi X3Byb2JlKCkgc28gbm8gbmVlZAp0byBhdm9pZCBpdC4KCkFsc28gaXQgd291bGQgYmUgbW9yZSBs b2dpY2FsIHRvIHNldCBkcm0gPSBmYnByaXYtPmRybTsgd2hlcmUgbWVtb3J5IGFyZSBhbGxvY2F0 ZWQuCgo+ICsKPiArCWludGVsdmlwZmJfc2V0dXBfbW9kZV9jb25maWcoZHJtKTsKPiArCj4gKwlj b25uZWN0b3IgPSBpbnRlbHZpcGZiX2Nvbm5fc2V0dXAoZHJtKTsKPiArCWlmICghY29ubmVjdG9y KSB7Cj4gKwkJZGV2X2Vycihkcm0tPmRldiwgIkNvbm5lY3RvciBzZXR1cCBmYWlsZWRcbiIpOwo+ ICsJCWdvdG8gZXJyX21vZGVfY29uZmlnOwo+ICsJfQo+ICsKPiArCXJldHZhbCA9IGRybV9zaW1w bGVfZGlzcGxheV9waXBlX2luaXQoZHJtLAo+ICsJCQkmZmJwcml2LT5waXBlLAo+ICsJCQkmZmJw cml2X2Z1bmNzLAo+ICsJCQlmb3JtYXRzLAo+ICsJCQlBUlJBWV9TSVpFKGZvcm1hdHMpLAo+ICsJ CQlOVUxMLCBjb25uZWN0b3IpOwpDb25zaWRlciBpbmRlbnQsIHdoZXJlIHN1YnNlcXVlbnQgcGFy YW1ldGVycyBhcmUgYWxpZ25lZCByaWdodCBhZnRlciB0aGUKb3BlbmluZyAnKCcuCgo+ICsKPiAr CWlmIChyZXR2YWwgPCAwKSB7Cj4gKwkJZGV2X2Vycihkcm0tPmRldiwgIkNhbm5vdCBzZXR1cCBz aW1wbGUgZGlzcGxheSBwaXBlXG4iKTsKPiArCQlnb3RvIGVycl9tb2RlX2NvbmZpZzsKPiArCX0K PiArCj4gKwlkcm1fbW9kZV9jb25maWdfcmVzZXQoZHJtKTsKPiArCj4gKwlkcm1fZGV2X3JlZ2lz dGVyKGRybSwgMCk7Cj4gKwo+ICsJZHJtX2ZiZGV2X2dlbmVyaWNfc2V0dXAoZHJtLCAzMik7Cj4g Kwo+ICsJZGV2X2luZm8oZHJtLT5kZXYsICJpdmlwOiBTdWNjZXNzZnVsbHkgY3JlYXRlZCBmYlxu Iik7Cj4gKwo+ICsJcmV0dXJuIHJldHZhbDsKPiArCj4gK2Vycl9tb2RlX2NvbmZpZzoKPiArCj4g Kwlkcm1fbW9kZV9jb25maWdfY2xlYW51cChkcm0pOwo+ICsJcmV0dXJuIC1FTk9ERVY7Cj4gK30K PiArCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaXZpcC9pbnRlbF92aXBfb2YuYyBi L2RyaXZlcnMvZ3B1L2RybS9pdmlwL2ludGVsX3ZpcF9vZi5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2 NDQKPiBpbmRleCAwMDAwMDAwLi5jODk5ZTMwCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pdmlwL2ludGVsX3ZpcF9vZi5jCj4gQEAgLTAsMCArMSwxODEgQEAKPiArLy8g U1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiArLyoKPiArICogQ29weXJpZ2h0IChD KSAyMDE5IEludGVsIENvcnBvcmF0aW9uLgo+ICsgKgo+ICsgKiBpbnRlbF92aXBfb2YuYyAtLSBJ bnRlbCBWaWRlbyBhbmQgSW1hZ2UgUHJvY2Vzc2luZyhWSVApCj4gKyAqIEZyYW1lIEJ1ZmZlciBJ SSBkcml2ZXIKClRoZSBuZWVkIGZvciB0aGlzIGZpbGUgY29uZnVzZXMgbWUuCkl0IGRvZXMgbm90 IGluY2x1ZGUgb25seSAib2YiIHJlbGF0ZWQgc3R1ZmYsIGJ1dCBhbHNvIGdlbmVyaWMgZGV2aWNl IGRyaXZlciBzdHVmZi4KCk1heWJlIG1lcmdlIHdpdGggaW50ZWxfdmlwX2NvcmUuYz8KQW5kIHJl bmFtZSB0aGF0IGZpbGUgdG8gaW50ZWxfdmlwX2Rydi5jPwoKPiArICoKPiArICogVGhpcyBkcml2 ZXIgc3VwcG9ydHMgdGhlIEludGVsIFZJUCBGcmFtZSBSZWFkZXIgY29tcG9uZW50Lgo+ICsgKiBN b3JlIGluZm8gb24gdGhlIGhhcmR3YXJlIGNhbiBiZSBmb3VuZCBpbiB0aGUgSW50ZWwgVmlkZW8K PiArICogYW5kIEltYWdlIFByb2Nlc3NpbmcgU3VpdGUgVXNlciBHdWlkZSBhdCB0aGlzIGFkZHJl c3MKPiArICogaHR0cDovL3d3dy5hbHRlcmEuY29tL2xpdGVyYXR1cmUvdWcvdWdfdmlwLnBkZi4K PiArICoKPiArICogQXV0aG9yczoKPiArICogT25nLCBIZWFuLUxvb25nIDxoZWFuLmxvb25nLm9u Z0BpbnRlbC5jb20+Cj4gKyAqCj4gKyAqLwo+ICsjaW5jbHVkZSA8ZHJtL2RybVAuaD4KRHJvcCB1 c2Ugb2YgZHJtUC5oCgo+ICtzdGF0aWMgaW50IGludGVsdmlwZmJfb2ZfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJaW50IHJldHZhbDsKPiArCXN0cnVjdCByZXNv dXJjZSAqcmVnX3JlczsKPiArCXN0cnVjdCBpbnRlbHZpcGZiX3ByaXYgKmZicHJpdjsKPiArCXN0 cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZHJt Owo+ICsKPiArCWZicHJpdiA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqZmJwcml2KSwgR0ZQ X0tFUk5FTCk7Cj4gKwlpZiAoIWZicHJpdikKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwkv KnNldHVwIERSTSAqLwpTcGFjZSBiZWZvcmUgInNldHVwIgoKPiArCj4gK3N0YXRpYyBjb25zdCBz dHJ1Y3Qgb2ZfZGV2aWNlX2lkIGludGVsdmlwZmJfb2ZfbWF0Y2hbXSA9IHsKPiArCXsgLmNvbXBh dGlibGUgPSAiYWx0cix2aXAtZnJhbWUtYnVmZmVyLTIuMCIgfSwKPiArCXt9LApNYXliZSBhZGQg Ii8qIHNlbnRpbmVsICovIiBjb21tZW50PwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFE1C169C4 for ; Mon, 11 Feb 2019 06:56:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57F1C20838 for ; Mon, 11 Feb 2019 06:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726050AbfBKGz7 (ORCPT ); Mon, 11 Feb 2019 01:55:59 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:53617 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfBKGz7 (ORCPT ); Mon, 11 Feb 2019 01:55:59 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8EC1620030; Mon, 11 Feb 2019 07:55:53 +0100 (CET) Date: Mon, 11 Feb 2019 07:55:52 +0100 From: Sam Ravnborg To: "Hean-Loong, Ong" Cc: Rob Herring , Dinh Nguyen , Daniel Vetter , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Rienk de Jong , devicetree@vger.kernel.org, yves.vandervennet@intel.com, chin.liang.see@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ong@freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv12 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite Message-ID: <20190211065552.GA7010@ravnborg.org> References: <20190211060926.3433-1-hean.loong.ong@intel.com> <20190211060926.3433-4-hean.loong.ong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211060926.3433-4-hean.loong.ong@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=yBYpec10AAAA:8 a=fjobobjgAAAA:8 a=QyXUC8HyAAAA:8 a=jbnKnBcKNtAAbXgpOMQA:9 a=aegFic2g-LuQCSZJ:21 a=er5hxFpQ-oadSlK4:21 a=CjuIK1q_8ugA:10 a=zbxmTX4fiVD2UiCe4Dha:22 a=PlEKnuvBpV2Z9KzPMKMm:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hean-Loong, Ong Patch looks good to me, but there is a few trivial things I spotted while browsing the code. See below. Sam > +++ b/drivers/gpu/drm/ivip/Makefile > @@ -0,0 +1,7 @@ > +# > +# Makefile for the drm device driver. This driver provides support for the > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > + > +obj-$(CONFIG_DRM_IVIP) += ivip.o > +ivip-objs := intel_vip_of.o intel_vip_core.o \ > + intel_vip_conn.o You could use: ivip-y := intel_vip_of.o intel_vip_core.o ivip-y += intel_vip_conn.o Using "ivip-y" is the recommend syntax today. And using "+=" you get rid of the ugly "\" to continue a line. (Some people prefer "\" in makefiles, but there are not needed) > +++ b/drivers/gpu/drm/ivip/intel_vip_core.c > @@ -0,0 +1,189 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Intel Corporation. > + * > + * intel_vip_core.c -- Intel Video and Image Processing(VIP) > + * Frame Buffer II driver > + * > + * This driver supports the Intel VIP Frame Reader component. > + * More info on the hardware can be found in the Intel Video > + * and Image Processing Suite User Guide at this address > + * http://www.altera.com/literature/ug/ug_vip.pdf. > + * > + * Authors: > + * Walter Goossens > + * Thomas Chou > + * Chris Rauer > + * Ong, Hean-Loong > + * > + */ > + > +#include Please do not use drmP.h in new drivers, we try to get rid of this file. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Sort the list of include files. (Looks like this was properly done before, and only one file is out of palce) > +static void intelvipfb_enable(struct drm_simple_display_pipe *pipe, > + struct drm_crtc_state *crtc_state, struct drm_plane_state * > + plane_state) Fix indent. The parameters on second line and following should be aligned below the opening paranthesis. Use tab(s) + spaces to align properly. > +void intelvipfb_display_pipe_update(struct drm_simple_display_pipe *pipe, > + struct drm_plane_state *old_state) Align parameter > +} > +EXPORT_SYMBOL(intelvipfb_display_pipe_update); > + > +static struct drm_simple_display_pipe_funcs fbpriv_funcs = { > + .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, > + .update = intelvipfb_display_pipe_update, > + .enable = intelvipfb_enable, > + .disable = intelvipfb_disable, > +}; > + > + > +int intelvipfb_probe(struct device *dev) > +{ > + int retval; > + struct drm_device *drm; > + struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev); > + > + struct drm_connector *connector; > + u32 formats[] = {DRM_FORMAT_XRGB8888}; > + > + drm = fbpriv->drm; > + > + drm->dev_private = fbpriv; It would be simpler to just pass fbpriv as a parameter. There is only one user of intelvipfb_probe() so no need to avoid it. Also it would be more logical to set drm = fbpriv->drm; where memory are allocated. > + > + intelvipfb_setup_mode_config(drm); > + > + connector = intelvipfb_conn_setup(drm); > + if (!connector) { > + dev_err(drm->dev, "Connector setup failed\n"); > + goto err_mode_config; > + } > + > + retval = drm_simple_display_pipe_init(drm, > + &fbpriv->pipe, > + &fbpriv_funcs, > + formats, > + ARRAY_SIZE(formats), > + NULL, connector); Consider indent, where subsequent parameters are aligned right after the opening '('. > + > + if (retval < 0) { > + dev_err(drm->dev, "Cannot setup simple display pipe\n"); > + goto err_mode_config; > + } > + > + drm_mode_config_reset(drm); > + > + drm_dev_register(drm, 0); > + > + drm_fbdev_generic_setup(drm, 32); > + > + dev_info(drm->dev, "ivip: Successfully created fb\n"); > + > + return retval; > + > +err_mode_config: > + > + drm_mode_config_cleanup(drm); > + return -ENODEV; > +} > + > diff --git a/drivers/gpu/drm/ivip/intel_vip_of.c b/drivers/gpu/drm/ivip/intel_vip_of.c > new file mode 100644 > index 0000000..c899e30 > --- /dev/null > +++ b/drivers/gpu/drm/ivip/intel_vip_of.c > @@ -0,0 +1,181 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Intel Corporation. > + * > + * intel_vip_of.c -- Intel Video and Image Processing(VIP) > + * Frame Buffer II driver The need for this file confuses me. It does not include only "of" related stuff, but also generic device driver stuff. Maybe merge with intel_vip_core.c? And rename that file to intel_vip_drv.c? > + * > + * This driver supports the Intel VIP Frame Reader component. > + * More info on the hardware can be found in the Intel Video > + * and Image Processing Suite User Guide at this address > + * http://www.altera.com/literature/ug/ug_vip.pdf. > + * > + * Authors: > + * Ong, Hean-Loong > + * > + */ > +#include Drop use of drmP.h > +static int intelvipfb_of_probe(struct platform_device *pdev) > +{ > + int retval; > + struct resource *reg_res; > + struct intelvipfb_priv *fbpriv; > + struct device *dev = &pdev->dev; > + struct drm_device *drm; > + > + fbpriv = devm_kzalloc(dev, sizeof(*fbpriv), GFP_KERNEL); > + if (!fbpriv) > + return -ENOMEM; > + > + /*setup DRM */ Space before "setup" > + > +static const struct of_device_id intelvipfb_of_match[] = { > + { .compatible = "altr,vip-frame-buffer-2.0" }, > + {}, Maybe add "/* sentinel */" comment?