All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2] nvmetcli: ANA configuration support
Date: Mon, 11 Feb 2019 09:23:08 +0100	[thread overview]
Message-ID: <20190211082308.GA16512@lst.de> (raw)
In-Reply-To: <88f6608b-df3c-2528-4f9c-1e4610fabf44@suse.com>

Did you get a chance to look into this or should I spend some time on
it?

On Wed, Nov 14, 2018@04:23:08PM +0100, Hannes Reinecke wrote:
> On 11/14/18 4:14 PM, Christoph Hellwig wrote:
>> This fails to restore a config that doesn't have the ANA fields
>> yet (actual config attached):
>>
>> Traceback (most recent call last):
>>    File "./nvmetcli", line 740, in <module>
>>      main()
>>    File "./nvmetcli", line 722, in main
>>      funcs[sys.argv[1]](savefile)
>>    File "./nvmetcli", line 678, in restore
>>      errors = nvme.Root().restore_from_file(from_file)
>>    File "/root/nvmetcli/nvmet/nvme.py", line 382, in restore_from_file
>>      abort_on_error=abort_on_error)
>>    File "/root/nvmetcli/nvmet/nvme.py", line 356, in restore
>>      Subsystem.setup(t, err_func)
>>    File "/root/nvmetcli/nvmet/nvme.py", line 497, in setup
>>      Namespace.setup(s, ns, err_func)
>>    File "/root/nvmetcli/nvmet/nvme.py", line 610, in setup
>>      ns.set_grpid(int(n['ana_grpid']))
>> KeyError: 'ana_grpid'
>>
> Gnaa. My python skills are crap.
>
> Will see to have it fixed.
>
> Cheers,
>
> Hannes
> -- 
> Dr. Hannes Reinecke		               zSeries & Storage
> hare at suse.com			               +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
> GF: F. Imend?rffer, J. Smithard, D. Upmanyu, G. Norton
> HRB 21284 (AG N?rnberg)
---end quoted text---

      parent reply	other threads:[~2019-02-11  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 12:27 [PATCHv2] nvmetcli: ANA configuration support Hannes Reinecke
2018-11-08 23:57 ` Sagi Grimberg
2018-11-14 15:14 ` Christoph Hellwig
2018-11-14 15:23   ` Hannes Reinecke
2018-12-12  7:45     ` Christoph Hellwig
2019-02-11  8:23     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211082308.GA16512@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.