From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/8] usb: ohci-da8xx: add a helper pointer to &pdev->dev From: Bartosz Golaszewski Message-Id: <20190211103702.4277-3-brgl@bgdev.pl> Date: Mon, 11 Feb 2019 11:36:56 +0100 To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Linus Walleij , Bartosz Golaszewski List-ID: RnJvbTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4KCkFk ZCBhIGhlbHBlciBwb2ludGVyIHRvICZwZGV2LT5kZXYuIFRoaXMgaW1wcm92ZXMgcmVhZGFiaWxp dHkgYnkKcmVtb3ZpbmcgYWxsIHRoZSAmcGRldi0+ZGV2IGRlcmVmZXJlbmNpbmcuCgpTaWduZWQt b2ZmLWJ5OiBCYXJ0b3N6IEdvbGFzemV3c2tpIDxiZ29sYXN6ZXdza2lAYmF5bGlicmUuY29tPgpB Y2tlZC1ieTogQWxhbiBTdGVybiA8c3Rlcm5Acm93bGFuZC5oYXJ2YXJkLmVkdT4KLS0tCiBkcml2 ZXJzL3VzYi9ob3N0L29oY2ktZGE4eHguYyB8IDE4ICsrKysrKysrKy0tLS0tLS0tLQogMSBmaWxl IGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3VzYi9ob3N0L29oY2ktZGE4eHguYyBiL2RyaXZlcnMvdXNiL2hvc3Qvb2hjaS1kYTh4 eC5jCmluZGV4IGM0OTJjN2U2Zjc0Ni4uZThlZGUwYjVlM2YwIDEwMDY0NAotLS0gYS9kcml2ZXJz L3VzYi9ob3N0L29oY2ktZGE4eHguYworKysgYi9kcml2ZXJzL3VzYi9ob3N0L29oY2ktZGE4eHgu YwpAQCAtNDAyLDM1ICs0MDIsMzUgQEAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgZGE4eHhfb2hj aV9pZHMpOwogc3RhdGljIGludCBvaGNpX2RhOHh4X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCiB7CiAJc3RydWN0IGRhOHh4X29oY2lfaGNkICpkYTh4eF9vaGNpOworCXN0cnVj dCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7CiAJc3RydWN0IHVzYl9oY2QJKmhjZDsKIAlzdHJ1 Y3QgcmVzb3VyY2UgKm1lbTsKIAlpbnQgZXJyb3IsIGlycTsKIAotCWhjZCA9IHVzYl9jcmVhdGVf aGNkKCZvaGNpX2RhOHh4X2hjX2RyaXZlciwgJnBkZXYtPmRldiwKLQkJCQlkZXZfbmFtZSgmcGRl di0+ZGV2KSk7CisJaGNkID0gdXNiX2NyZWF0ZV9oY2QoJm9oY2lfZGE4eHhfaGNfZHJpdmVyLCBk ZXYsIGRldl9uYW1lKGRldikpOwogCWlmICghaGNkKQogCQlyZXR1cm4gLUVOT01FTTsKIAogCWRh OHh4X29oY2kgPSB0b19kYTh4eF9vaGNpKGhjZCk7CiAJZGE4eHhfb2hjaS0+aGNkID0gaGNkOwog Ci0JZGE4eHhfb2hjaS0+dXNiMTFfY2xrID0gZGV2bV9jbGtfZ2V0KCZwZGV2LT5kZXYsIE5VTEwp OworCWRhOHh4X29oY2ktPnVzYjExX2NsayA9IGRldm1fY2xrX2dldChkZXYsIE5VTEwpOwogCWlm IChJU19FUlIoZGE4eHhfb2hjaS0+dXNiMTFfY2xrKSkgewogCQllcnJvciA9IFBUUl9FUlIoZGE4 eHhfb2hjaS0+dXNiMTFfY2xrKTsKIAkJaWYgKGVycm9yICE9IC1FUFJPQkVfREVGRVIpCi0JCQlk ZXZfZXJyKCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gZ2V0IGNsb2NrLlxuIik7CisJCQlkZXZfZXJy KGRldiwgIkZhaWxlZCB0byBnZXQgY2xvY2suXG4iKTsKIAkJZ290byBlcnI7CiAJfQogCi0JZGE4 eHhfb2hjaS0+dXNiMTFfcGh5ID0gZGV2bV9waHlfZ2V0KCZwZGV2LT5kZXYsICJ1c2ItcGh5Iik7 CisJZGE4eHhfb2hjaS0+dXNiMTFfcGh5ID0gZGV2bV9waHlfZ2V0KGRldiwgInVzYi1waHkiKTsK IAlpZiAoSVNfRVJSKGRhOHh4X29oY2ktPnVzYjExX3BoeSkpIHsKIAkJZXJyb3IgPSBQVFJfRVJS KGRhOHh4X29oY2ktPnVzYjExX3BoeSk7CiAJCWlmIChlcnJvciAhPSAtRVBST0JFX0RFRkVSKQot CQkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFpbGVkIHRvIGdldCBwaHkuXG4iKTsKKwkJCWRldl9l cnIoZGV2LCAiRmFpbGVkIHRvIGdldCBwaHkuXG4iKTsKIAkJZ290byBlcnI7CiAJfQogCi0JZGE4 eHhfb2hjaS0+dmJ1c19yZWcgPSBkZXZtX3JlZ3VsYXRvcl9nZXRfb3B0aW9uYWwoJnBkZXYtPmRl diwgInZidXMiKTsKKwlkYTh4eF9vaGNpLT52YnVzX3JlZyA9IGRldm1fcmVndWxhdG9yX2dldF9v cHRpb25hbChkZXYsICJ2YnVzIik7CiAJaWYgKElTX0VSUihkYTh4eF9vaGNpLT52YnVzX3JlZykp IHsKIAkJZXJyb3IgPSBQVFJfRVJSKGRhOHh4X29oY2ktPnZidXNfcmVnKTsKIAkJaWYgKGVycm9y ID09IC1FTk9ERVYpIHsKQEAgLTQzOCwxMyArNDM4LDEzIEBAIHN0YXRpYyBpbnQgb2hjaV9kYTh4 eF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQl9IGVsc2UgaWYgKGVycm9y ID09IC1FUFJPQkVfREVGRVIpIHsKIAkJCWdvdG8gZXJyOwogCQl9IGVsc2UgewotCQkJZGV2X2Vy cigmcGRldi0+ZGV2LCAiRmFpbGVkIHRvIGdldCByZWd1bGF0b3JcbiIpOworCQkJZGV2X2Vycihk ZXYsICJGYWlsZWQgdG8gZ2V0IHJlZ3VsYXRvclxuIik7CiAJCQlnb3RvIGVycjsKIAkJfQogCX0K IAogCW1lbSA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7 Ci0JaGNkLT5yZWdzID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKCZwZGV2LT5kZXYsIG1lbSk7CisJ aGNkLT5yZWdzID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgbWVtKTsKIAlpZiAoSVNfRVJS KGhjZC0+cmVncykpIHsKIAkJZXJyb3IgPSBQVFJfRVJSKGhjZC0+cmVncyk7CiAJCWdvdG8gZXJy Owo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C923C282D7 for ; Mon, 11 Feb 2019 10:37:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 652F42084D for ; Mon, 11 Feb 2019 10:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VQcuuoI4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="uLye05mH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 652F42084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VPbB/yCTgLFSG8CONnEMGTNFRk3hOvE+CJobMZkkFaw=; b=VQcuuoI4Vvi7Fv 4dVAcDSgbEc09bDS/RMMAPnKCfRxB0OEJhWi5s5mfSbi9dlHkM05cRRxquPvsRi9yXrtmYLQLKX42 cuUKwiKI4QgSPHLljbz39FHfVekbnE1m/Cwi3ABuCPnxbpuGcxrfKKfYW0Ba0mtfFTy6edLDrrcJv opQeW5C0uw5K6sOcfa9aHinZlMLKfAcpJUvQbgoDRwBluj8IYnRXOF8JzOh7rZitYQ06U1OjCRDSr rqq5sX0JFA6losFeBdEbEaf+8VDsjExjQtRilGBaPiehwKxssnsm1Kpt+oYTbKz0VVRV1eyqbdfiE 0biAnhIGemi2ZaI7sAKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt8yH-0007D3-M7; Mon, 11 Feb 2019 10:37:53 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt8xa-0006WP-Ej for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 10:37:17 +0000 Received: by mail-wm1-x343.google.com with SMTP id x10so10932060wmg.2 for ; Mon, 11 Feb 2019 02:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ORsjA8hmqOYVa1A6z58C/tpqF85yI2kmPo177hZON40=; b=uLye05mHf5U4mdu8gXtjfTR+N3aOWDgsG2T1ERC4B3Socyqgmm/3fxEawS5ubPSdFG B/ugTQ69/ccJCN00HR4Lcd5V4LlAZZKtW1s8Og3uVxvxvXrVJyE11GUsT9OsoPTGzUHM KuzWsf48SBy2Y5Bus0/mXAoubrViDagkXNF2DHWvAg8468CqDAeNXfahxXHfjuX+acWV v+sU48xODUB6NESxzJW5iJF4xcMRX9IPNV7u8mxCsTi/tTgI90a5scml1fnBDrVw1L4i fdXYERqFuxqjpOg1epP/K3xE6iVPojWA+jj910LrTB/6BG8TRWFPJwSHGeuqSaBOuHeZ Djyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ORsjA8hmqOYVa1A6z58C/tpqF85yI2kmPo177hZON40=; b=fU5mUPj3pJp47th7UDIn/fMg6eQjefEzOfF52GRDJt8IzBYB7dR8PYaZaWfSGb6VCk GxH0FSbYqqugJHDFV96raFC9lwBlFEyPwnIyRlnONeJBKO3KtSltbAbJstwEzpw9r+vX I5htRLVldlRa2ixJbGogSQAIT1xlyMjunNh13kbpP+ilNJUWAmtsYWuVYDjFF2+kp79f NqtGl33l/WZtGNdr7D7PTG+SiWevcwZSKc9VtLG+H3fNlNXmec9JI2PG5+nf0rz1hy0d 1/z1bjlAcFmWlAXZdc9iG3xV+3/Ie1tGCvUHsAm9pqRJsyMWPTxJjCczw6AN113Hz9h8 ulVA== X-Gm-Message-State: AHQUAuay46pyMthTPar6Pnd7BKx0iBYnbM+a0vw5X2SlXPD0nIyQ9HB7 FH0wEtw9j95aZKi8qBEdgR5uJQ== X-Google-Smtp-Source: AHgI3Ib/RRpS7Aag0oclwa7+AqIq9+WfvoGs3rvHUtSqAKvhDoU0qM6dtbyLVU0XyAbi8y51UGZqXw== X-Received: by 2002:a1c:2408:: with SMTP id k8mr8550037wmk.110.1549881428735; Mon, 11 Feb 2019 02:37:08 -0800 (PST) Received: from debian-brgl.home ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id i192sm11121275wmg.7.2019.02.11.02.37.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 02:37:08 -0800 (PST) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Subject: [PATCH v2 2/8] usb: ohci-da8xx: add a helper pointer to &pdev->dev Date: Mon, 11 Feb 2019 11:36:56 +0100 Message-Id: <20190211103702.4277-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211103702.4277-1-brgl@bgdev.pl> References: <20190211103702.4277-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_023710_927823_99D64315 X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , Linus Walleij , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Add a helper pointer to &pdev->dev. This improves readability by removing all the &pdev->dev dereferencing. Signed-off-by: Bartosz Golaszewski Acked-by: Alan Stern --- drivers/usb/host/ohci-da8xx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index c492c7e6f746..e8ede0b5e3f0 100644 --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -402,35 +402,35 @@ MODULE_DEVICE_TABLE(of, da8xx_ohci_ids); static int ohci_da8xx_probe(struct platform_device *pdev) { struct da8xx_ohci_hcd *da8xx_ohci; + struct device *dev = &pdev->dev; struct usb_hcd *hcd; struct resource *mem; int error, irq; - hcd = usb_create_hcd(&ohci_da8xx_hc_driver, &pdev->dev, - dev_name(&pdev->dev)); + hcd = usb_create_hcd(&ohci_da8xx_hc_driver, dev, dev_name(dev)); if (!hcd) return -ENOMEM; da8xx_ohci = to_da8xx_ohci(hcd); da8xx_ohci->hcd = hcd; - da8xx_ohci->usb11_clk = devm_clk_get(&pdev->dev, NULL); + da8xx_ohci->usb11_clk = devm_clk_get(dev, NULL); if (IS_ERR(da8xx_ohci->usb11_clk)) { error = PTR_ERR(da8xx_ohci->usb11_clk); if (error != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to get clock.\n"); + dev_err(dev, "Failed to get clock.\n"); goto err; } - da8xx_ohci->usb11_phy = devm_phy_get(&pdev->dev, "usb-phy"); + da8xx_ohci->usb11_phy = devm_phy_get(dev, "usb-phy"); if (IS_ERR(da8xx_ohci->usb11_phy)) { error = PTR_ERR(da8xx_ohci->usb11_phy); if (error != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to get phy.\n"); + dev_err(dev, "Failed to get phy.\n"); goto err; } - da8xx_ohci->vbus_reg = devm_regulator_get_optional(&pdev->dev, "vbus"); + da8xx_ohci->vbus_reg = devm_regulator_get_optional(dev, "vbus"); if (IS_ERR(da8xx_ohci->vbus_reg)) { error = PTR_ERR(da8xx_ohci->vbus_reg); if (error == -ENODEV) { @@ -438,13 +438,13 @@ static int ohci_da8xx_probe(struct platform_device *pdev) } else if (error == -EPROBE_DEFER) { goto err; } else { - dev_err(&pdev->dev, "Failed to get regulator\n"); + dev_err(dev, "Failed to get regulator\n"); goto err; } } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hcd->regs = devm_ioremap_resource(&pdev->dev, mem); + hcd->regs = devm_ioremap_resource(dev, mem); if (IS_ERR(hcd->regs)) { error = PTR_ERR(hcd->regs); goto err; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CADAC169C4 for ; Mon, 11 Feb 2019 10:37:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DAD52084D for ; Mon, 11 Feb 2019 10:37:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="uLye05mH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbfBKKhN (ORCPT ); Mon, 11 Feb 2019 05:37:13 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55456 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726337AbfBKKhK (ORCPT ); Mon, 11 Feb 2019 05:37:10 -0500 Received: by mail-wm1-f68.google.com with SMTP id r17so16680331wmh.5 for ; Mon, 11 Feb 2019 02:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ORsjA8hmqOYVa1A6z58C/tpqF85yI2kmPo177hZON40=; b=uLye05mHf5U4mdu8gXtjfTR+N3aOWDgsG2T1ERC4B3Socyqgmm/3fxEawS5ubPSdFG B/ugTQ69/ccJCN00HR4Lcd5V4LlAZZKtW1s8Og3uVxvxvXrVJyE11GUsT9OsoPTGzUHM KuzWsf48SBy2Y5Bus0/mXAoubrViDagkXNF2DHWvAg8468CqDAeNXfahxXHfjuX+acWV v+sU48xODUB6NESxzJW5iJF4xcMRX9IPNV7u8mxCsTi/tTgI90a5scml1fnBDrVw1L4i fdXYERqFuxqjpOg1epP/K3xE6iVPojWA+jj910LrTB/6BG8TRWFPJwSHGeuqSaBOuHeZ Djyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ORsjA8hmqOYVa1A6z58C/tpqF85yI2kmPo177hZON40=; b=gtYCHU7K2OjbOg3kLEwgkSkMvKlpKaRpg1VlX+7NDp+XsSp2X9aO6BzCg+E+3h/wTP CZvjYZad3XiSUpz6Xz22eMVu45s889tuawjdug3/GclNDyfTTmt8jhqHqfLxg8/lLWaW 0EvoWMxmMjI8hLghHnrV9+zhMvonsluMrGy8EBi3xltUMvNsgVlEZ9mLbOo93JsJgPK9 CR7RrYmEgiHBlUSLrbTXwL2T2A/qmLV/6AP2ZX6xSfGzCt/6/64dbjKwsz5ti/JB6dYI gGVolvIXaMnwH/yWurVothX3wHGlegeKmUoOYUubjnEhmlrOF1aq439UPNW9/lf5GTt3 ebjg== X-Gm-Message-State: AHQUAuay1iYqowo/temOw/nUfg4BhOy3YkZTvLfQpqmMobMgFgLIvWB0 Z1Q8Vxc0bNN4pEkCQYsiiPp6Pw== X-Google-Smtp-Source: AHgI3Ib/RRpS7Aag0oclwa7+AqIq9+WfvoGs3rvHUtSqAKvhDoU0qM6dtbyLVU0XyAbi8y51UGZqXw== X-Received: by 2002:a1c:2408:: with SMTP id k8mr8550037wmk.110.1549881428735; Mon, 11 Feb 2019 02:37:08 -0800 (PST) Received: from debian-brgl.home ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id i192sm11121275wmg.7.2019.02.11.02.37.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 02:37:08 -0800 (PST) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Linus Walleij , Bartosz Golaszewski Subject: [PATCH v2 2/8] usb: ohci-da8xx: add a helper pointer to &pdev->dev Date: Mon, 11 Feb 2019 11:36:56 +0100 Message-Id: <20190211103702.4277-3-brgl@bgdev.pl> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211103702.4277-1-brgl@bgdev.pl> References: <20190211103702.4277-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Add a helper pointer to &pdev->dev. This improves readability by removing all the &pdev->dev dereferencing. Signed-off-by: Bartosz Golaszewski Acked-by: Alan Stern --- drivers/usb/host/ohci-da8xx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index c492c7e6f746..e8ede0b5e3f0 100644 --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -402,35 +402,35 @@ MODULE_DEVICE_TABLE(of, da8xx_ohci_ids); static int ohci_da8xx_probe(struct platform_device *pdev) { struct da8xx_ohci_hcd *da8xx_ohci; + struct device *dev = &pdev->dev; struct usb_hcd *hcd; struct resource *mem; int error, irq; - hcd = usb_create_hcd(&ohci_da8xx_hc_driver, &pdev->dev, - dev_name(&pdev->dev)); + hcd = usb_create_hcd(&ohci_da8xx_hc_driver, dev, dev_name(dev)); if (!hcd) return -ENOMEM; da8xx_ohci = to_da8xx_ohci(hcd); da8xx_ohci->hcd = hcd; - da8xx_ohci->usb11_clk = devm_clk_get(&pdev->dev, NULL); + da8xx_ohci->usb11_clk = devm_clk_get(dev, NULL); if (IS_ERR(da8xx_ohci->usb11_clk)) { error = PTR_ERR(da8xx_ohci->usb11_clk); if (error != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to get clock.\n"); + dev_err(dev, "Failed to get clock.\n"); goto err; } - da8xx_ohci->usb11_phy = devm_phy_get(&pdev->dev, "usb-phy"); + da8xx_ohci->usb11_phy = devm_phy_get(dev, "usb-phy"); if (IS_ERR(da8xx_ohci->usb11_phy)) { error = PTR_ERR(da8xx_ohci->usb11_phy); if (error != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to get phy.\n"); + dev_err(dev, "Failed to get phy.\n"); goto err; } - da8xx_ohci->vbus_reg = devm_regulator_get_optional(&pdev->dev, "vbus"); + da8xx_ohci->vbus_reg = devm_regulator_get_optional(dev, "vbus"); if (IS_ERR(da8xx_ohci->vbus_reg)) { error = PTR_ERR(da8xx_ohci->vbus_reg); if (error == -ENODEV) { @@ -438,13 +438,13 @@ static int ohci_da8xx_probe(struct platform_device *pdev) } else if (error == -EPROBE_DEFER) { goto err; } else { - dev_err(&pdev->dev, "Failed to get regulator\n"); + dev_err(dev, "Failed to get regulator\n"); goto err; } } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hcd->regs = devm_ioremap_resource(&pdev->dev, mem); + hcd->regs = devm_ioremap_resource(dev, mem); if (IS_ERR(hcd->regs)) { error = PTR_ERR(hcd->regs); goto err; -- 2.20.1