From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
Markos Chandras <markos.chandras@imgtec.com>,
Paul Burton <paul.burton@mips.com>,
linux-mips@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Song Liu <songliubraving@fb.com>,
Jiong Wang <jiong.wang@netronome.com>,
Alexei Starovoitov <ast@kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.19 113/313] mips: bpf: fix encoding bug for mm_srlv32_op
Date: Mon, 11 Feb 2019 15:16:33 +0100 [thread overview]
Message-ID: <20190211141901.415699443@linuxfoundation.org> (raw)
In-Reply-To: <20190211141852.749630980@linuxfoundation.org>
4.19-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit 17f6c83fb5ebf7db4fcc94a5be4c22d5a7bfe428 ]
For micro-mips, srlv inside POOL32A encoding space should use 0x50
sub-opcode, NOT 0x90.
Some early version ISA doc describes the encoding as 0x90 for both srlv and
srav, this looks to me was a typo. I checked Binutils libopcode
implementation which is using 0x50 for srlv and 0x90 for srav.
v1->v2:
- Keep mm_srlv32_op sorted by value.
Fixes: f31318fdf324 ("MIPS: uasm: Add srlv uasm instruction")
Cc: Markos Chandras <markos.chandras@imgtec.com>
Cc: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/mips/include/uapi/asm/inst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h
index c05dcf5ab414..273ef58f4d43 100644
--- a/arch/mips/include/uapi/asm/inst.h
+++ b/arch/mips/include/uapi/asm/inst.h
@@ -369,8 +369,8 @@ enum mm_32a_minor_op {
mm_ext_op = 0x02c,
mm_pool32axf_op = 0x03c,
mm_srl32_op = 0x040,
+ mm_srlv32_op = 0x050,
mm_sra_op = 0x080,
- mm_srlv32_op = 0x090,
mm_rotr_op = 0x0c0,
mm_lwxs_op = 0x118,
mm_addu32_op = 0x150,
--
2.19.1
next prev parent reply other threads:[~2019-02-11 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190211141852.749630980@linuxfoundation.org>
2019-02-11 14:15 ` [PATCH 4.19 054/313] x86/resctrl: Fixup the user-visible strings Greg Kroah-Hartman
2019-02-11 18:12 ` Reinette Chatre
2019-02-11 19:27 ` Greg Kroah-Hartman
2019-02-11 14:16 ` [PATCH 4.19 082/313] firmware/efi: Add NULL pointer checks in efivars API functions Greg Kroah-Hartman
2019-02-11 14:16 ` [PATCH 4.19 089/313] ARM: dts: aspeed: add missing memory unit-address Greg Kroah-Hartman
2019-02-11 14:16 ` Greg Kroah-Hartman
2019-02-11 14:16 ` Greg Kroah-Hartman
2019-02-11 14:16 ` [PATCH 4.19 090/313] x86/fpu: Add might_fault() to user_insn() Greg Kroah-Hartman
2019-02-11 14:16 ` Greg Kroah-Hartman [this message]
2019-02-11 14:18 ` [PATCH 4.19 233/313] block/swim3: Fix -EBUSY error when re-opening device after unmount Greg Kroah-Hartman
2019-02-11 14:19 ` [PATCH 4.19 291/313] futex: Handle early deadlock return correctly Greg Kroah-Hartman
2019-02-11 14:19 ` [PATCH 4.19 303/313] cpu/hotplug: Fix "SMT disabled by BIOS" detection for KVM Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211141901.415699443@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=ast@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=jiong.wang@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@mips.com \
--cc=sashal@kernel.org \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.