From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Lorenzo Bianconi Message-Id: <20190211155726.GE8128@localhost.localdomain> Date: Mon, 11 Feb 2019 16:57:27 +0100 To: Stefan Wahren Cc: Stanislaw Gruszka , Felix Fietkau , Doug Anderson , Minas Harutyunyan , linux-wireless , linux-usb@vger.kernel.org List-ID: PiBIaSwKPiAKPiBBbSAxMS4wMi4xOSB1bSAxNjoxMCBzY2hyaWViIExvcmVuem8gQmlhbmNvbmk6 Cj4gPj4gSGkgTG9yZW56bywKPiA+Pgo+ID4+IEFtIDExLjAyLjE5IHVtIDEyOjA2IHNjaHJpZWIg TG9yZW56byBCaWFuY29uaToKPiA+Pj4+IEhpLAo+ID4+Pj4KPiA+Pj4+IEFtIDExLjAyLjE5IHVt IDExOjA0IHNjaHJpZWIgTG9yZW56byBCaWFuY29uaToKPiA+Pj4+Pj4gT24gU3VuLCBGZWIgMTAs IDIwMTkgYXQgMTE6MjI6MjVBTSArMDEwMCwgTG9yZW56byBCaWFuY29uaSB3cm90ZToKPiA+Pj4+ Pj4+PiBPbiBTYXQsIEZlYiAwOSwgMjAxOSBhdCAwOToyOTowNVBNICswMTAwLCBTdGVmYW4gV2Fo cmVuIHdyb3RlOgo+ID4+Pj4+Pj4+Pj4gY291bGQgeW91IHBsZWFzZSB0ZXN0IHRoZSBmb2xsb3dp bmcgc2VyaWVzOgo+ID4+Pj4+Pj4+Pj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9jb3Zl ci8xMDc2NDQ1My8KPiA+Pj4+Pj4+Pj4geWVhaCB0aGlzIGZpeGVkIHRoZSBwcm9iaW5nIHRpbWVv dXQgYW5kIHRoZSBkcml2ZXIgd2lsbCBwcm9iZSBzdWNjZXNzZnVsLiBBRkFJSyB0aGUgZHdjMiBo b3N0IG1vZGUgZG9lc24ndCBzdXBwb3J0IHNjYXR0ZXItZ2F0aGVyIHlldC4KPiA+Pj4+Pj4+PiBT byB0aGlzIGlzIGVpdGhlciBkd2MyIHNjYXR0ZXItZ2F0aGVyIHByb2JsZW0gd2hpY2ggc2hvdWxk IGJlIGFkZHJlc3NlZCBpbgo+ID4+Pj4+Pj4+IHRoaXMgZHJpdmVyIG9yIG10NzZ4MHUgZG9lcyBz b21ldGhpbmcgd3Jvbmcgd2hlbiBjb25maWd1cmluZyBTRy4KPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+ IERpc2FibGluZyBTRyBpcyBqdXN0IHdvcmthcm91bmQsIHdoaWNoIGRvIG5vdCBhZGRyZXNzIGFj dHVhbCBwcm9ibGVtLgo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gSSB0aGluayBJIGZvdW5kIG10NzZ4 MHUgaXNzdWUgdGhhdCBjb3VsZCBjYXVzZSB0aGlzIFVTQiBwcm9iZSBlcnJvcgo+ID4+Pj4+Pj4+ IChhbmQgcG9zc2libHkgYWxzbyBhZGRyZXNzIEFNRCBJT01NVSBpc3N1ZSkuIFdlIHNlZW1zIGRv IG5vdCBjb3JyZWN0bHkKPiA+Pj4+Pj4+PiBzZXQgVVJCIHRyYW5zZmVyIGxlbmd0aCBzbWFsbGVy IHRoYW4gc2cgYnVmZmVyIGxlbmd0aC4gQXR0YWNoZWQgIHBhdGNoCj4gPj4+Pj4+Pj4gc2hvdWxk IGNvcnJlY3QgdGhhdC4KPiA+Pj4+Pj4+IEhpIFN0YW5pc2xhdywKPiA+Pj4+Pj4+Cj4gPj4+Pj4+ PiBJIHRoaW5rICdzZ1swXS5sZW5ndGgnIGlzIGFscmVhZHkgc2V0IGluIG10NzZ1X2ZpbGxfcnhf c2coKS4KPiA+Pj4+Pj4gSXQgaXMsIGJ1Zi0+bGVuIGFuZCBzZ1swXS5sZW5ndGggYXJlIGluaXRp YWxpemVkIHRvIHRoZSBzYW1lIHZhbHVlIGZvciAxCj4gPj4+Pj4+IHNlZ21lbnQuIEJ1dCB0aGVu IGJ1Zi0+bGVuIChhc3NpZ25lZCB0byB1cmItPmJ1ZmZlcl90cmFuc2Zlcl9sZW5ndGgpIGNoYW5n ZQo+ID4+Pj4+PiB0byBzbWFsbGVyIHZhbHVlICwgYnV0IHNnWzBdLmxlbmd0aCBzdGF5IHRoZSBz YW1lLiBXaGF0IEkgdGhpbmsgY2FuIGJlCj4gPj4+Pj4+IHByb2JsZW0gZm9yIHVzYiBob3N0IGRy aXZlci4KPiA+Pj4+Pj4KPiA+Pj4+Pj4+IE1vcmVvdmVyIGFwcGx5aW5nIHRoaXMgcGF0Y2ggSSBn b3QgdGhlIGZvbGxvd2luZyBjcmFzaCAocnBpLTUuMC55KToKPiA+Pj4+Pj4gT2ssIHNvIHdpdGgg cGF0Y2ggcHJvYmUgZmFpbCBpbnN0YW50bHkgYW5kIHRyaWdnZXIgeWV0IGFub3RoZXIgYnVnKHMp Cj4gPj4+Pj4+IG9uIGVycm9yIHBhdGguIFlvdSBzZWVtcyB0byBhZGRyZXNzIHRoYXQgYWxyZWFk eS4gCj4gPj4+Pj4+Cj4gPj4+Pj4+PiBNb3Jlb3ZlciBmb3IgbXQ3NngwdSBTRyBpcyAnYWxyZWFk eScgZGlzYWJsZWQgc2luY2Ugd2UgdXNlIGp1c3Qgb25lCj4gPj4+Pj4+PiBidWZmZXIgc28gZnJv bSBwZXJmb3JtYW5jZSBwb2ludCBvZiB2aWV3IEkgZG8gbm90IHNlZSBhbnkgZGlmZmVyZW5jZQo+ ID4+Pj4+Pj4gb2YgdXNpbmcgYSBzdGFuZGFyZCB1c2IgYnVmZmVyLgo+ID4+Pj4+Pj4gVGhpcyBw YXRjaCBoYXMgYmVlbiB0ZXN0ZWQgaW4gbXVsdGlwbGUgc2NlbmFyaW9zIGFuZCBzZWVtcyB0byBm aXgKPiA+Pj4+Pj4+IHJlcG9ydGVkIGlzc3VlcyAoZm9yIHVzYjIuMCkuCj4gPj4+Pj4+IE9rLCBz byBwYXNzaW5nIGJ1ZmZlciB2aWEgdXJiLT50cmFuc2Zlcl9idWZmZXIgd29ya3MuIEJ1dCB3aHkg dXJiLT5zZwo+ID4+Pj4+PiBkb2VzIG5vdCB3b3JrIGZvciAxIHNlZ21lbnQgPwo+ID4+Pj4+IEhl cmUgaXQgaXMgYSBkaWZmZXJlbnQgaXNzdWUgcmVzcGVjdCB0byB0aGUgQU1EIElPTU1VIG9uZSwg ZHdjMiBob3N0IGRyaXZlcgo+ID4+Pj4+IGRvZXMgbm90IGltcGxlbWVudCBTRyBJL08gc28gcHJv YmluZyBmYWlscy4gSSBndWVzcyBpdCBpcyBzdGlsbCB1c2VmdWwgdG8KPiA+Pj4+PiBpbXBsZW1l bnQgYSAnbGVnYWN5JyBtb2RlIHRoYXQgZW5hYmxlIG10NzYgb24gaG9zdCBjb250cm9sbGVycyB0 aGF0IGRvIG5vdCBpbXBsZW1lbnQKPiA+Pj4+PiBTRyBJL08gKHJwaSBpcyBhIHZlcnkgY29tbW9u IGRldmljZSBzbyBpdCB3aWxsIGJlIGNvb2wgdG8gaGF2ZSBtdDc2IHdvcmtpbmcgb24KPiA+Pj4+ PiBpdCkuIE1vcmVvdmVyIHdlIGFyZSBub3QgcmVtb3ZpbmcgZnVuY3Rpb25hbGl0aWVzLCB1c2Vy IGV4cGVyaWVuY2Ugd2lsbCByZW1haW4KPiA+Pj4+PiB0aGUgc2FtZQo+ID4+Pj4+Cj4gPj4+PiBp J20gbm90IHN1cmUgdGhhdCB5b3UgdW5kZXJzdGFuZCBteSBtYWlsIFsxXSB3aXRoIHRoZSBzdW1t YXJ5IG9mIG15IHRlc3QKPiA+Pj4+IHJlc3VsdHMuCj4gPj4+Pgo+ID4+PiBZZXMgcmlnaHQsIEkg ZGlkIG5vdCBnZXQgaXQgc29ycnkgOikKPiA+Pj4gYXMgaW5kaWNhdGVkIGhlcmUgaHR0cHM6Ly93 d3cucmFzcGJlcnJ5cGkub3JnL2RvY3VtZW50YXRpb24vbGludXgva2VybmVsL2J1aWxkaW5nLm1k Cj4gPj4+IEkgYW0gdXNpbmcgYmNtMjcwOV9kZWZjb25maWcgY29uZmlnICh1c2luZyBpdCBJIHNw b3R0ZWQgdGhlIG10NzYgY3Jhc2hlcyBhbmQKPiA+Pj4gcHJvYmUgZmFpbHVyZSkKPiA+PiBubyBw cm9ibGVtLCBhdCB0aGUgYmVnaW5uaW5nIHRoaXMgY291bGQgYmUgdmVyeSBjb25mdXNpbmcuIEkg b25seSB3YW50Cj4gPj4gdG8gY2xhcmlmeSB0aGF0IHRoaXMgZG9jdW1lbnRhdGlvbiByZWZlcnMg dG8gdGhlIHZlbmRvciBrZXJuZWwgKHdpdGggYQo+ID4+IGRpZmZlcmVudCBVU0IgaG9zdCBkcml2 ZXIpIG9mIHRoZSBSYXNwYmVycnkgUGkgRm91bmRhdGlvbi4KPiA+Pgo+ID4+IEFsbCBteSByZXN1 bHRzIHJlZmVycyB0byB0aGUgbWFpbmxpbmUga2VybmVsIHdlIGFsbCBzaG91bGQgdGFsayBhYm91 dC4gSQo+ID4+IHN0YXJ0ZWQgYSBnaXN0IHdoaWNoIHRyeSB0byBkZXNjcmliZSB0aGUgbWFpbmxp bmUgdmFyaWFudDoKPiA+PiBodHRwczovL2dpc3QuZ2l0aHViLmNvbS9sYXRlZ29vZGJ5ZS9jNzMx N2E0MmJmN2Y5YzA3ZjVhOTFiYWVkOGM2OGY3NQo+ID4gU28gdG8gc3VtbWFyaXplOgo+ID4gLSBS YXNwYmVycnkgUGkgRm91bmRhdGlvbiBrZXJuZWwgd29ya3MganVzdCB3aXRoIFJGQyBzZXJpZXMK PiA+IC0gbWFpbmxpbmUga2VybmVsIHdvcmtzIG91dCBvZiB0aGUgYm94Cj4gPgo+ID4gaXMgbXkg dW5kZXJzdGFuZGluZyBjb3JyZWN0PyAKPiAKPiBub3QgcmVhbGx5Lgo+IAo+IENvbXBpbGluZyB0 aGUgbWFpbmxpbmUga2VybmVsIHdpdGggYXJtL211bHRpX3Y3X2RlZmNvbmZpZyBpdCB3b3Jrcy4K PiBVc2luZyB0aGUgc2FtZSBrZXJuZWwgYnV0IHdpdGggYXJtNjQvZGVmY29uZmlnIGRvZXNuJ3Qg d29yay4gQnV0IGkgZG9uJ3QKPiB0aGluayB0aGlzIGlzIGEgMzIvNjQgYml0IGlzc3VlLiBUaGUg YXJtNjQgZGVmY29uZmlnIGlzIG11Y2ggbW9yZQo+IGNvbXBsZXggKGUuZy4gZW5hYmxlcyBtb3Jl IElPTU1VIHN0dWZmKS4KCnRoeCBmb3IgdGhlIGNsYXJpZmljYXRpb24gOikKClJlZ2FyZHMsCkxv cmVuem8KCj4gCj4gUmVnYXJkcwo+IFN0ZWZhbgo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F3EEC169C4 for ; Mon, 11 Feb 2019 15:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6028021B24 for ; Mon, 11 Feb 2019 15:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730699AbfBKP5e (ORCPT ); Mon, 11 Feb 2019 10:57:34 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37540 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbfBKP5d (ORCPT ); Mon, 11 Feb 2019 10:57:33 -0500 Received: by mail-wr1-f67.google.com with SMTP id c8so5308469wrs.4 for ; Mon, 11 Feb 2019 07:57:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=U4WtZrcFe7pghKORxIYH4V2t8b+PZ+1G2RnMWrOsh4w=; b=hGeoV37gSbjanjJkxndupbZ849AsY/8JgTP63qNoxqwjkPextEH+Prq1dnk3X2g1cG QwDr21om+0vuuevngWQNG4yZ/pqWRARHMMwsB8cRJvDMLMNRf6GgFMw+xOQUmWTb96Bf 9/jq4E7xD5ze+gcKyBJy7fiyQlvRWbC+IM+MeuzlaDOuJSUZIrj72nny0xYxZzZcJyWu VYnDJhlEKZnjkh4aGesC6uKXN1ZcXobS+y27BIEniltCJwA0HoHZLNbyr2WNrmzDTUFW anXByiOODCg8wVbnNc+l+I39yYsRjywXhBX72f1DEwRKuHaNRSZ62wTYcqc+QP6w0XCN dyYg== X-Gm-Message-State: AHQUAuZkH/4l2R7ucWz9xGEu6WxPrN5jrV/cJw2LMdD67Ws8Iyhh+MPr rLcD86JABwe0qo1kfdjh/C84+g== X-Google-Smtp-Source: AHgI3IagsVC4nt9rbShcUX1sxIBrU1OJufUNy6xZYjsMgXwKS8518UZ4MEI2ts9ZYra46/nI8K8ZaQ== X-Received: by 2002:a5d:538a:: with SMTP id d10mr5502597wrv.121.1549900651227; Mon, 11 Feb 2019 07:57:31 -0800 (PST) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id b14sm19689770wrx.36.2019.02.11.07.57.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 07:57:30 -0800 (PST) Date: Mon, 11 Feb 2019 16:57:27 +0100 From: Lorenzo Bianconi To: Stefan Wahren Cc: Stanislaw Gruszka , Felix Fietkau , Doug Anderson , Minas Harutyunyan , linux-wireless , linux-usb@vger.kernel.org Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190211155726.GE8128@localhost.localdomain> References: <165515185.283024.1549744145982@email.ionos.de> <20190210094123.GB2913@redhat.com> <20190211074455.GA6292@redhat.com> <20190211100405.GD3467@localhost.localdomain> <20190211110635.GD2293@localhost.localdomain> <8a996497-ed69-4087-2c37-7f73633cbb4e@i2se.com> <20190211151055.GC8128@localhost.localdomain> <500c0d4a-611a-1b00-5ea4-7368e5e9f1e9@i2se.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <500c0d4a-611a-1b00-5ea4-7368e5e9f1e9@i2se.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Hi, > > Am 11.02.19 um 16:10 schrieb Lorenzo Bianconi: > >> Hi Lorenzo, > >> > >> Am 11.02.19 um 12:06 schrieb Lorenzo Bianconi: > >>>> Hi, > >>>> > >>>> Am 11.02.19 um 11:04 schrieb Lorenzo Bianconi: > >>>>>> On Sun, Feb 10, 2019 at 11:22:25AM +0100, Lorenzo Bianconi wrote: > >>>>>>>> On Sat, Feb 09, 2019 at 09:29:05PM +0100, Stefan Wahren wrote: > >>>>>>>>>> could you please test the following series: > >>>>>>>>>> https://patchwork.kernel.org/cover/10764453/ > >>>>>>>>> yeah this fixed the probing timeout and the driver will probe successful. AFAIK the dwc2 host mode doesn't support scatter-gather yet. > >>>>>>>> So this is either dwc2 scatter-gather problem which should be addressed in > >>>>>>>> this driver or mt76x0u does something wrong when configuring SG. > >>>>>>>> > >>>>>>>> Disabling SG is just workaround, which do not address actual problem. > >>>>>>>> > >>>>>>>> I think I found mt76x0u issue that could cause this USB probe error > >>>>>>>> (and possibly also address AMD IOMMU issue). We seems do not correctly > >>>>>>>> set URB transfer length smaller than sg buffer length. Attached patch > >>>>>>>> should correct that. > >>>>>>> Hi Stanislaw, > >>>>>>> > >>>>>>> I think 'sg[0].length' is already set in mt76u_fill_rx_sg(). > >>>>>> It is, buf->len and sg[0].length are initialized to the same value for 1 > >>>>>> segment. But then buf->len (assigned to urb->buffer_transfer_length) change > >>>>>> to smaller value , but sg[0].length stay the same. What I think can be > >>>>>> problem for usb host driver. > >>>>>> > >>>>>>> Moreover applying this patch I got the following crash (rpi-5.0.y): > >>>>>> Ok, so with patch probe fail instantly and trigger yet another bug(s) > >>>>>> on error path. You seems to address that already. > >>>>>> > >>>>>>> Moreover for mt76x0u SG is 'already' disabled since we use just one > >>>>>>> buffer so from performance point of view I do not see any difference > >>>>>>> of using a standard usb buffer. > >>>>>>> This patch has been tested in multiple scenarios and seems to fix > >>>>>>> reported issues (for usb2.0). > >>>>>> Ok, so passing buffer via urb->transfer_buffer works. But why urb->sg > >>>>>> does not work for 1 segment ? > >>>>> Here it is a different issue respect to the AMD IOMMU one, dwc2 host driver > >>>>> does not implement SG I/O so probing fails. I guess it is still useful to > >>>>> implement a 'legacy' mode that enable mt76 on host controllers that do not implement > >>>>> SG I/O (rpi is a very common device so it will be cool to have mt76 working on > >>>>> it). Moreover we are not removing functionalities, user experience will remain > >>>>> the same > >>>>> > >>>> i'm not sure that you understand my mail [1] with the summary of my test > >>>> results. > >>>> > >>> Yes right, I did not get it sorry :) > >>> as indicated here https://www.raspberrypi.org/documentation/linux/kernel/building.md > >>> I am using bcm2709_defconfig config (using it I spotted the mt76 crashes and > >>> probe failure) > >> no problem, at the beginning this could be very confusing. I only want > >> to clarify that this documentation refers to the vendor kernel (with a > >> different USB host driver) of the Raspberry Pi Foundation. > >> > >> All my results refers to the mainline kernel we all should talk about. I > >> started a gist which try to describe the mainline variant: > >> https://gist.github.com/lategoodbye/c7317a42bf7f9c07f5a91baed8c68f75 > > So to summarize: > > - Raspberry Pi Foundation kernel works just with RFC series > > - mainline kernel works out of the box > > > > is my understanding correct? > > not really. > > Compiling the mainline kernel with arm/multi_v7_defconfig it works. > Using the same kernel but with arm64/defconfig doesn't work. But i don't > think this is a 32/64 bit issue. The arm64 defconfig is much more > complex (e.g. enables more IOMMU stuff). thx for the clarification :) Regards, Lorenzo > > Regards > Stefan >