diff for duplicates of <20190211172738.4633-7-ebiggers@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 47a4f1e..6f1921a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -319,7 +319,7 @@ index 6c1e675d4eef..000000000000 - key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, - ctx->master_key_descriptor, - mode->keysize, &payload); -- if (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { +- if (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { - key = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix, - ctx->master_key_descriptor, - mode->keysize, &payload); @@ -333,7 +333,8 @@ index 6c1e675d4eef..000000000000 - "direct key mode not allowed with %s", - mode->friendly_name); - err = -EINVAL; -- } else if (ctx->contents_encryption_mode !- ctx->filenames_encryption_mode) { +- } else if (ctx->contents_encryption_mode != +- ctx->filenames_encryption_mode) { - fscrypt_warn(inode->i_sb, - "direct key mode not allowed with different contents and filenames modes"); - err = -EINVAL; @@ -697,10 +698,10 @@ index 6c1e675d4eef..000000000000 - if (res) - goto out; - -- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) +- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) - crypt_info = NULL; -out: -- if (res = -ENOKEY) +- if (res == -ENOKEY) - res = 0; - put_crypt_info(crypt_info); - kzfree(raw_key); @@ -1013,10 +1014,10 @@ index 000000000000..898a82d5ff3c + if (res) + goto out; + -+ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) ++ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) + crypt_info = NULL; +out: -+ if (res = -ENOKEY) ++ if (res == -ENOKEY) + res = 0; + put_crypt_info(crypt_info); + return res; @@ -1361,7 +1362,7 @@ index 000000000000..a48588458f07 + key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); -+ if (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { ++ if (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { + key = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); diff --git a/a/content_digest b/N1/content_digest index 1b2cf95..8c863fe 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020190211172738.4633-1-ebiggers@kernel.org\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" "Subject\0[RFC PATCH v2 06/20] fscrypt: refactor v1 policy key setup into keysetup_legacy.c\0" - "Date\0Mon, 11 Feb 2019 17:27:24 +0000\0" + "Date\0Mon, 11 Feb 2019 09:27:24 -0800\0" "To\0linux-fscrypt@vger.kernel.org\0" "Cc\0Satya Tangirala <satyat@google.com>" linux-api@vger.kernel.org @@ -335,7 +335,7 @@ "-\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "-\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\tmode->keysize, &payload);\n" - "-\tif (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" + "-\tif (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" "-\t\tkey = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix,\n" "-\t\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\t\tmode->keysize, &payload);\n" @@ -349,7 +349,8 @@ "-\t\t\t\t \"direct key mode not allowed with %s\",\n" "-\t\t\t\t mode->friendly_name);\n" "-\t\t\terr = -EINVAL;\n" - "-\t\t} else if (ctx->contents_encryption_mode !-\t\t\t ctx->filenames_encryption_mode) {\n" + "-\t\t} else if (ctx->contents_encryption_mode !=\n" + "-\t\t\t ctx->filenames_encryption_mode) {\n" "-\t\t\tfscrypt_warn(inode->i_sb,\n" "-\t\t\t\t \"direct key mode not allowed with different contents and filenames modes\");\n" "-\t\t\terr = -EINVAL;\n" @@ -713,10 +714,10 @@ "-\tif (res)\n" "-\t\tgoto out;\n" "-\n" - "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "-\t\tcrypt_info = NULL;\n" "-out:\n" - "-\tif (res = -ENOKEY)\n" + "-\tif (res == -ENOKEY)\n" "-\t\tres = 0;\n" "-\tput_crypt_info(crypt_info);\n" "-\tkzfree(raw_key);\n" @@ -1029,10 +1030,10 @@ "+\tif (res)\n" "+\t\tgoto out;\n" "+\n" - "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "+\t\tcrypt_info = NULL;\n" "+out:\n" - "+\tif (res = -ENOKEY)\n" + "+\tif (res == -ENOKEY)\n" "+\t\tres = 0;\n" "+\tput_crypt_info(crypt_info);\n" "+\treturn res;\n" @@ -1377,7 +1378,7 @@ "+\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "+\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\tci->ci_mode->keysize, &payload);\n" - "+\tif (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" + "+\tif (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" "+\t\tkey = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix,\n" "+\t\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\t\tci->ci_mode->keysize, &payload);\n" @@ -1416,4 +1417,4 @@ "-- \n" 2.20.1 -b811879371e4ac3f80049f4c6dc26008623d94b91222459811aa1542c2303a27 +1e7d171e04fab3fe282039163c1770504e12b6625e974358b4e6f3a779bde588
diff --git a/a/1.txt b/N2/1.txt index 47a4f1e..6f1921a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -319,7 +319,7 @@ index 6c1e675d4eef..000000000000 - key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, - ctx->master_key_descriptor, - mode->keysize, &payload); -- if (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { +- if (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { - key = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix, - ctx->master_key_descriptor, - mode->keysize, &payload); @@ -333,7 +333,8 @@ index 6c1e675d4eef..000000000000 - "direct key mode not allowed with %s", - mode->friendly_name); - err = -EINVAL; -- } else if (ctx->contents_encryption_mode !- ctx->filenames_encryption_mode) { +- } else if (ctx->contents_encryption_mode != +- ctx->filenames_encryption_mode) { - fscrypt_warn(inode->i_sb, - "direct key mode not allowed with different contents and filenames modes"); - err = -EINVAL; @@ -697,10 +698,10 @@ index 6c1e675d4eef..000000000000 - if (res) - goto out; - -- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) +- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) - crypt_info = NULL; -out: -- if (res = -ENOKEY) +- if (res == -ENOKEY) - res = 0; - put_crypt_info(crypt_info); - kzfree(raw_key); @@ -1013,10 +1014,10 @@ index 000000000000..898a82d5ff3c + if (res) + goto out; + -+ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) ++ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) + crypt_info = NULL; +out: -+ if (res = -ENOKEY) ++ if (res == -ENOKEY) + res = 0; + put_crypt_info(crypt_info); + return res; @@ -1361,7 +1362,7 @@ index 000000000000..a48588458f07 + key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); -+ if (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { ++ if (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { + key = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); diff --git a/a/content_digest b/N2/content_digest index 1b2cf95..203431f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,16 +1,16 @@ "ref\020190211172738.4633-1-ebiggers@kernel.org\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" "Subject\0[RFC PATCH v2 06/20] fscrypt: refactor v1 policy key setup into keysetup_legacy.c\0" - "Date\0Mon, 11 Feb 2019 17:27:24 +0000\0" + "Date\0Mon, 11 Feb 2019 09:27:24 -0800\0" "To\0linux-fscrypt@vger.kernel.org\0" - "Cc\0Satya Tangirala <satyat@google.com>" - linux-api@vger.kernel.org + "Cc\0linux-ext4@vger.kernel.org" linux-f2fs-devel@lists.sourceforge.net - keyrings@vger.kernel.org linux-mtd@lists.infradead.org - linux-crypto@vger.kernel.org linux-fsdevel@vger.kernel.org - linux-ext4@vger.kernel.org + linux-crypto@vger.kernel.org + linux-api@vger.kernel.org + keyrings@vger.kernel.org + Satya Tangirala <satyat@google.com> " Paul Crowley <paulcrowley@google.com>\0" "\00:1\0" "b\0" @@ -335,7 +335,7 @@ "-\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "-\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\tmode->keysize, &payload);\n" - "-\tif (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" + "-\tif (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" "-\t\tkey = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix,\n" "-\t\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\t\tmode->keysize, &payload);\n" @@ -349,7 +349,8 @@ "-\t\t\t\t \"direct key mode not allowed with %s\",\n" "-\t\t\t\t mode->friendly_name);\n" "-\t\t\terr = -EINVAL;\n" - "-\t\t} else if (ctx->contents_encryption_mode !-\t\t\t ctx->filenames_encryption_mode) {\n" + "-\t\t} else if (ctx->contents_encryption_mode !=\n" + "-\t\t\t ctx->filenames_encryption_mode) {\n" "-\t\t\tfscrypt_warn(inode->i_sb,\n" "-\t\t\t\t \"direct key mode not allowed with different contents and filenames modes\");\n" "-\t\t\terr = -EINVAL;\n" @@ -713,10 +714,10 @@ "-\tif (res)\n" "-\t\tgoto out;\n" "-\n" - "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "-\t\tcrypt_info = NULL;\n" "-out:\n" - "-\tif (res = -ENOKEY)\n" + "-\tif (res == -ENOKEY)\n" "-\t\tres = 0;\n" "-\tput_crypt_info(crypt_info);\n" "-\tkzfree(raw_key);\n" @@ -1029,10 +1030,10 @@ "+\tif (res)\n" "+\t\tgoto out;\n" "+\n" - "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "+\t\tcrypt_info = NULL;\n" "+out:\n" - "+\tif (res = -ENOKEY)\n" + "+\tif (res == -ENOKEY)\n" "+\t\tres = 0;\n" "+\tput_crypt_info(crypt_info);\n" "+\treturn res;\n" @@ -1377,7 +1378,7 @@ "+\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "+\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\tci->ci_mode->keysize, &payload);\n" - "+\tif (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" + "+\tif (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" "+\t\tkey = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix,\n" "+\t\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\t\tci->ci_mode->keysize, &payload);\n" @@ -1416,4 +1417,4 @@ "-- \n" 2.20.1 -b811879371e4ac3f80049f4c6dc26008623d94b91222459811aa1542c2303a27 +1054f99f9bb3055f42efc3f3d55e5e9698e35e022289e4611f5650df303bf5b0
diff --git a/a/1.txt b/N3/1.txt index 47a4f1e..3f1a01a 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -319,7 +319,7 @@ index 6c1e675d4eef..000000000000 - key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, - ctx->master_key_descriptor, - mode->keysize, &payload); -- if (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { +- if (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { - key = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix, - ctx->master_key_descriptor, - mode->keysize, &payload); @@ -333,7 +333,8 @@ index 6c1e675d4eef..000000000000 - "direct key mode not allowed with %s", - mode->friendly_name); - err = -EINVAL; -- } else if (ctx->contents_encryption_mode !- ctx->filenames_encryption_mode) { +- } else if (ctx->contents_encryption_mode != +- ctx->filenames_encryption_mode) { - fscrypt_warn(inode->i_sb, - "direct key mode not allowed with different contents and filenames modes"); - err = -EINVAL; @@ -697,10 +698,10 @@ index 6c1e675d4eef..000000000000 - if (res) - goto out; - -- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) +- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) - crypt_info = NULL; -out: -- if (res = -ENOKEY) +- if (res == -ENOKEY) - res = 0; - put_crypt_info(crypt_info); - kzfree(raw_key); @@ -1013,10 +1014,10 @@ index 000000000000..898a82d5ff3c + if (res) + goto out; + -+ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) ++ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) + crypt_info = NULL; +out: -+ if (res = -ENOKEY) ++ if (res == -ENOKEY) + res = 0; + put_crypt_info(crypt_info); + return res; @@ -1361,7 +1362,7 @@ index 000000000000..a48588458f07 + key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); -+ if (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { ++ if (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { + key = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); @@ -1399,3 +1400,10 @@ index 8b1e44421497..5afb9fc13ef4 100644 return -EOPNOTSUPP; -- 2.20.1 + + + +_______________________________________________ +Linux-f2fs-devel mailing list +Linux-f2fs-devel@lists.sourceforge.net +https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel diff --git a/a/content_digest b/N3/content_digest index 1b2cf95..348cd47 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,7 +1,7 @@ "ref\020190211172738.4633-1-ebiggers@kernel.org\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" - "Subject\0[RFC PATCH v2 06/20] fscrypt: refactor v1 policy key setup into keysetup_legacy.c\0" - "Date\0Mon, 11 Feb 2019 17:27:24 +0000\0" + "Subject\0[f2fs-dev] [RFC PATCH v2 06/20] fscrypt: refactor v1 policy key setup into keysetup_legacy.c\0" + "Date\0Mon, 11 Feb 2019 09:27:24 -0800\0" "To\0linux-fscrypt@vger.kernel.org\0" "Cc\0Satya Tangirala <satyat@google.com>" linux-api@vger.kernel.org @@ -335,7 +335,7 @@ "-\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "-\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\tmode->keysize, &payload);\n" - "-\tif (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" + "-\tif (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" "-\t\tkey = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix,\n" "-\t\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\t\tmode->keysize, &payload);\n" @@ -349,7 +349,8 @@ "-\t\t\t\t \"direct key mode not allowed with %s\",\n" "-\t\t\t\t mode->friendly_name);\n" "-\t\t\terr = -EINVAL;\n" - "-\t\t} else if (ctx->contents_encryption_mode !-\t\t\t ctx->filenames_encryption_mode) {\n" + "-\t\t} else if (ctx->contents_encryption_mode !=\n" + "-\t\t\t ctx->filenames_encryption_mode) {\n" "-\t\t\tfscrypt_warn(inode->i_sb,\n" "-\t\t\t\t \"direct key mode not allowed with different contents and filenames modes\");\n" "-\t\t\terr = -EINVAL;\n" @@ -713,10 +714,10 @@ "-\tif (res)\n" "-\t\tgoto out;\n" "-\n" - "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "-\t\tcrypt_info = NULL;\n" "-out:\n" - "-\tif (res = -ENOKEY)\n" + "-\tif (res == -ENOKEY)\n" "-\t\tres = 0;\n" "-\tput_crypt_info(crypt_info);\n" "-\tkzfree(raw_key);\n" @@ -1029,10 +1030,10 @@ "+\tif (res)\n" "+\t\tgoto out;\n" "+\n" - "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "+\t\tcrypt_info = NULL;\n" "+out:\n" - "+\tif (res = -ENOKEY)\n" + "+\tif (res == -ENOKEY)\n" "+\t\tres = 0;\n" "+\tput_crypt_info(crypt_info);\n" "+\treturn res;\n" @@ -1377,7 +1378,7 @@ "+\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "+\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\tci->ci_mode->keysize, &payload);\n" - "+\tif (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" + "+\tif (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" "+\t\tkey = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix,\n" "+\t\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\t\tci->ci_mode->keysize, &payload);\n" @@ -1414,6 +1415,13 @@ " {\n" " \treturn -EOPNOTSUPP;\n" "-- \n" - 2.20.1 + "2.20.1\n" + "\n" + "\n" + "\n" + "_______________________________________________\n" + "Linux-f2fs-devel mailing list\n" + "Linux-f2fs-devel@lists.sourceforge.net\n" + https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -b811879371e4ac3f80049f4c6dc26008623d94b91222459811aa1542c2303a27 +824a6f011a902b25c7c6ba7e32f1292021c74b42b330a374c9c8ccf5a4f26273
diff --git a/a/1.txt b/N4/1.txt index 47a4f1e..d1b3c2f 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -319,7 +319,7 @@ index 6c1e675d4eef..000000000000 - key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, - ctx->master_key_descriptor, - mode->keysize, &payload); -- if (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { +- if (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) { - key = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix, - ctx->master_key_descriptor, - mode->keysize, &payload); @@ -333,7 +333,8 @@ index 6c1e675d4eef..000000000000 - "direct key mode not allowed with %s", - mode->friendly_name); - err = -EINVAL; -- } else if (ctx->contents_encryption_mode !- ctx->filenames_encryption_mode) { +- } else if (ctx->contents_encryption_mode != +- ctx->filenames_encryption_mode) { - fscrypt_warn(inode->i_sb, - "direct key mode not allowed with different contents and filenames modes"); - err = -EINVAL; @@ -697,10 +698,10 @@ index 6c1e675d4eef..000000000000 - if (res) - goto out; - -- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) +- if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) - crypt_info = NULL; -out: -- if (res = -ENOKEY) +- if (res == -ENOKEY) - res = 0; - put_crypt_info(crypt_info); - kzfree(raw_key); @@ -1013,10 +1014,10 @@ index 000000000000..898a82d5ff3c + if (res) + goto out; + -+ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL) ++ if (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL) + crypt_info = NULL; +out: -+ if (res = -ENOKEY) ++ if (res == -ENOKEY) + res = 0; + put_crypt_info(crypt_info); + return res; @@ -1361,7 +1362,7 @@ index 000000000000..a48588458f07 + key = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); -+ if (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { ++ if (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) { + key = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix, + ci->ci_master_key_descriptor, + ci->ci_mode->keysize, &payload); @@ -1399,3 +1400,8 @@ index 8b1e44421497..5afb9fc13ef4 100644 return -EOPNOTSUPP; -- 2.20.1 + + +______________________________________________________ +Linux MTD discussion mailing list +http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/a/content_digest b/N4/content_digest index 1b2cf95..f8e640e 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -1,7 +1,7 @@ "ref\020190211172738.4633-1-ebiggers@kernel.org\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" "Subject\0[RFC PATCH v2 06/20] fscrypt: refactor v1 policy key setup into keysetup_legacy.c\0" - "Date\0Mon, 11 Feb 2019 17:27:24 +0000\0" + "Date\0Mon, 11 Feb 2019 09:27:24 -0800\0" "To\0linux-fscrypt@vger.kernel.org\0" "Cc\0Satya Tangirala <satyat@google.com>" linux-api@vger.kernel.org @@ -335,7 +335,7 @@ "-\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "-\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\tmode->keysize, &payload);\n" - "-\tif (key = ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" + "-\tif (key == ERR_PTR(-ENOKEY) && inode->i_sb->s_cop->key_prefix) {\n" "-\t\tkey = find_and_lock_process_key(inode->i_sb->s_cop->key_prefix,\n" "-\t\t\t\t\t\tctx->master_key_descriptor,\n" "-\t\t\t\t\t\tmode->keysize, &payload);\n" @@ -349,7 +349,8 @@ "-\t\t\t\t \"direct key mode not allowed with %s\",\n" "-\t\t\t\t mode->friendly_name);\n" "-\t\t\terr = -EINVAL;\n" - "-\t\t} else if (ctx->contents_encryption_mode !-\t\t\t ctx->filenames_encryption_mode) {\n" + "-\t\t} else if (ctx->contents_encryption_mode !=\n" + "-\t\t\t ctx->filenames_encryption_mode) {\n" "-\t\t\tfscrypt_warn(inode->i_sb,\n" "-\t\t\t\t \"direct key mode not allowed with different contents and filenames modes\");\n" "-\t\t\terr = -EINVAL;\n" @@ -713,10 +714,10 @@ "-\tif (res)\n" "-\t\tgoto out;\n" "-\n" - "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "-\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "-\t\tcrypt_info = NULL;\n" "-out:\n" - "-\tif (res = -ENOKEY)\n" + "-\tif (res == -ENOKEY)\n" "-\t\tres = 0;\n" "-\tput_crypt_info(crypt_info);\n" "-\tkzfree(raw_key);\n" @@ -1029,10 +1030,10 @@ "+\tif (res)\n" "+\t\tgoto out;\n" "+\n" - "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) = NULL)\n" + "+\tif (cmpxchg(&inode->i_crypt_info, NULL, crypt_info) == NULL)\n" "+\t\tcrypt_info = NULL;\n" "+out:\n" - "+\tif (res = -ENOKEY)\n" + "+\tif (res == -ENOKEY)\n" "+\t\tres = 0;\n" "+\tput_crypt_info(crypt_info);\n" "+\treturn res;\n" @@ -1377,7 +1378,7 @@ "+\tkey = find_and_lock_process_key(FSCRYPT_KEY_DESC_PREFIX,\n" "+\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\tci->ci_mode->keysize, &payload);\n" - "+\tif (key = ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" + "+\tif (key == ERR_PTR(-ENOKEY) && ci->ci_inode->i_sb->s_cop->key_prefix) {\n" "+\t\tkey = find_and_lock_process_key(ci->ci_inode->i_sb->s_cop->key_prefix,\n" "+\t\t\t\t\t\tci->ci_master_key_descriptor,\n" "+\t\t\t\t\t\tci->ci_mode->keysize, &payload);\n" @@ -1414,6 +1415,11 @@ " {\n" " \treturn -EOPNOTSUPP;\n" "-- \n" - 2.20.1 + "2.20.1\n" + "\n" + "\n" + "______________________________________________________\n" + "Linux MTD discussion mailing list\n" + http://lists.infradead.org/mailman/listinfo/linux-mtd/ -b811879371e4ac3f80049f4c6dc26008623d94b91222459811aa1542c2303a27 +bb9679ad9e28ef8c4015c0c31672d7769f30003da3b27841b6a3909fd80fb258
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.