From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5E7C169C4 for ; Mon, 11 Feb 2019 20:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 927FF217FA for ; Mon, 11 Feb 2019 20:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388759AbfBKUSi (ORCPT ); Mon, 11 Feb 2019 15:18:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729137AbfBKUSg (ORCPT ); Mon, 11 Feb 2019 15:18:36 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB3B5821CC; Mon, 11 Feb 2019 20:18:35 +0000 (UTC) Received: from krava (ovpn-204-173.brq.redhat.com [10.40.204.173]) by smtp.corp.redhat.com (Postfix) with SMTP id 0490610018E0; Mon, 11 Feb 2019 20:18:32 +0000 (UTC) Date: Mon, 11 Feb 2019 21:18:31 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Stephane Eranian , Alexey Budankov , Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Adrian Hunter , Andi Kleen Subject: Re: [RFC/PATCH 00/14] perf record: Add support to store data in directory Message-ID: <20190211201831.GE5046@krava> References: <20190204192721.GI5593@kernel.org> <20190204202818.GC4794@krava> <20190205133727.GF4794@krava> <20190211101957.GB14253@krava> <20190211185306.GD5046@krava> <20190211193202.GG3269@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211193202.GG3269@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 11 Feb 2019 20:18:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 04:32:02PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 11, 2019 at 07:53:06PM +0100, Jiri Olsa escreveu: > > On Mon, Feb 11, 2019 at 10:34:16AM -0800, Stephane Eranian wrote: > > > On Mon, Feb 11, 2019 at 2:20 AM Jiri Olsa wrote: > > > > On Tue, Feb 05, 2019 at 02:37:27PM +0100, Jiri Olsa wrote: > > > > I think all could be added and worked around with exception > > > > of BUILD_ID, which we store at the end (after processing > > > > all data) and we need it early in the report phase > > > > Buildids are injected after the fact via perf inject when in pipe mode. > > > > > maybe it's time to re-think that buildid -> mmap event > > > > association again, because it's pain in current implementation > > > > as well > > > > Sure, but what do you propose? > > > this: > > > > > > looks like bpf code is actualy getting build ids and storing > > > > it for the callchains in kernel.. we can check if we can do > > > > something similar for mmap events > > kernel/bpf/stackmap.c > > /* Parse build ID from 64-bit ELF */ > static int stack_map_get_build_id_64(void *page_addr, > unsigned char *build_id) > > yeah, wasn't aware of that, good thing doing backports, huh? :-) > > So do you thing about having a PERF_SAMPLE_BUILDID in sample_type and go > and stash that thing in PERF_RECORD_MMAP2? I thought having new MMAP3 event version with buildid field in it if available and/or enabled by bit in perf_event_attr jirka