All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/4] wpebackend-fdo: new package
Date: Mon, 11 Feb 2019 22:31:24 +0100	[thread overview]
Message-ID: <20190211223124.0d289abc@windsurf> (raw)
In-Reply-To: <20190205204152.10376-3-francois.perrad@gadz.org>

Hello,

On Tue,  5 Feb 2019 21:41:50 +0100
Francois Perrad <fperrad@gmail.com> wrote:

> diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in
> new file mode 100644
> index 000000000..06392c93f
> --- /dev/null
> +++ b/package/wpebackend-fdo/Config.in
> @@ -0,0 +1,19 @@
> +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
> +	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
> +		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +
> +config BR2_PACKAGE_WPEBACKEND_FDO
> +	bool "wpebackend-fdo"
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	depends on BR2_USE_WCHAR # gettext
> +	depends on BR2_USE_MMU # fork()
> +	depends on BR2_PACKAGE_HAS_LIBEGL

I changed this like this:

+       depends on !BR2_STATIC_LIBS # wayland
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_TOOLCHAIN_HAS_THREADS # wayland, libglib2
+       depends on BR2_USE_WCHAR # libglib2
+       depends on BR2_USE_MMU # libglib2
+       depends on BR2_PACKAGE_HAS_LIBEGL

i.e we care more about why this particular package needed those "depends
on" rather than why those "depends on" where needed by the packages we
are selecting.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-02-11 21:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 20:41 [Buildroot] [PATCH v2 0/4] WPE WebKit Francois Perrad
2019-02-05 20:41 ` [Buildroot] [PATCH v2 1/4] libwpe: new package Francois Perrad
2019-02-05 20:41 ` [Buildroot] [PATCH v2 2/4] wpebackend-fdo: " Francois Perrad
2019-02-11 21:31   ` Thomas Petazzoni [this message]
2019-02-05 20:41 ` [Buildroot] [PATCH v2 3/4] wpewebkit: " Francois Perrad
2019-02-05 21:40   ` Adrian Perez de Castro
2019-02-11 21:34   ` Thomas Petazzoni
2019-02-05 20:41 ` [Buildroot] [PATCH v2 4/4] cog: " Francois Perrad
2019-02-05 21:40   ` Adrian Perez de Castro
2019-02-11 21:36   ` Thomas Petazzoni
2019-02-05 21:42 ` [Buildroot] [PATCH v2 0/4] WPE WebKit Adrian Perez de Castro
2019-02-11 21:29 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211223124.0d289abc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.