From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ From: Lorenzo Bianconi Message-Id: <20190212115842.GA24197@localhost.localdomain> Date: Tue, 12 Feb 2019 12:58:43 +0100 To: Stanislaw Gruszka Cc: Alan Stern , Stefan Wahren , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless List-ID: Wy4uLl0KCj4gSW4gdXNiX3NnX2luaXQoKSB1cmItPm51bV9zZ3MgaXMgc2V0IDAgZm9yIHNnX3Rh Ymxlc2l6ZSA9IDAgY29udHJvbGxlcnMuCj4gSW4gbXQ3NiB3ZSBzZXQgdXJiLT5udW1fc2dzIHRv IDEuIEkgdGhvdWdodCBpdCBpcyBmaW5lLCBidXQgbm93IEkgdGhpbmsKPiB0aGlzIGlzIGJ1Zy4g V2UgY2FuIGZpeCB0aGF0IHdpdGhvdXQgY2hhbmdpbmcgYWxsb2NhdGlvbiBtZXRob2QgYW5kCj4g c3RpbGwgdXNlIFNHIGFsbG9jYXRpb24uIEF0dGFjaGVkIHBhdGNoIGRvIHRoaXMsIHBsZWFzZSBj aGVjayBpZiBpdCB3b3Jrcwo+IG9uIHJwaS4gUGF0Y2ggaXMgb24gdG9wIG9mIHlvdXIgZXJyb3Ig cGF0aCBmaXhlcy4KPiAKPiBTdGFuaXNsYXcKCj4gRnJvbSBmNzlhYzBkZjk2N2Q0MDY1MjNkMGEx YzAzYTEzOGQxMzk0ZTc2NjVhIE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQo+IEZyb206IFN0YW5p c2xhdyBHcnVzemthIDxzZ3J1c3prYUByZWRoYXQuY29tPgo+IERhdGU6IFR1ZSwgMTIgRmViIDIw MTkgMTA6MDI6NTMgKzAxMDAKPiBTdWJqZWN0OiBbUEFUQ0hdIG10NzZ1c2I6IGRvIG5vdCBzZXQg dXJiLT5udW1fc2dzIHRvIDEgZm9yIG5vbiBTRyB1c2IgaG9zdAo+ICBkcml2ZXJzCj4gCj4gVHJh Y2sgbnVtYmVyIG9mIHNlZ21lbnRzIGluIG10NzZ1X2J1ZiBzdHJ1Y3R1cmUgYW5kIGRvIG5vdAo+ IHN1Ym1pdCB1cmJzIHdpdGggdXJiLT5udW1fc2dzID0gMSBpZiB1c2IgaG9zdCBkcml2ZXIKPiBz Z190YWJsZXNpemUgaXMgemVyby4KPiAKPiBUaGlzIHN1cHBvc2UgZml4IHByb2JsZW0gb2YgbXQ3 NiBub3Qgd29ya2luZyB3aXRoIHNvbWUgdXNiCj4gaG9zdCBjb250cm9sbGVycyBsaWtlIGR3YzIu Cj4gCj4gU2lnbmVkLW9mZi1ieTogU3RhbmlzbGF3IEdydXN6a2EgPHNncnVzemthQHJlZGhhdC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL21lZGlhdGVrL210NzYvbXQ3Ni5oIHwg IDEgKwo+ICBkcml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L3VzYi5jICB8IDU1ICsr KysrKysrKysrKysrLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygr KSwgMjAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNz L21lZGlhdGVrL210NzYvbXQ3Ni5oIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWVkaWF0ZWsvbXQ3 Ni9tdDc2LmgKPiBpbmRleCAyZTViY2IzZmRmZjcuLmVhZGM5MTNjMzdiNiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L210NzYuaAo+ICsrKyBiL2RyaXZl cnMvbmV0L3dpcmVsZXNzL21lZGlhdGVrL210NzYvbXQ3Ni5oCj4gQEAgLTg2LDYgKzg2LDcgQEAg c3RydWN0IG10NzZfcXVldWVfYnVmIHsKPiAgc3RydWN0IG10NzZ1X2J1ZiB7Cj4gIAlzdHJ1Y3Qg bXQ3Nl9kZXYgKmRldjsKPiAgCXN0cnVjdCB1cmIgKnVyYjsKPiArCWludCBudW1fc2dzOwo+ICAJ c2l6ZV90IGxlbjsKPiAgCWJvb2wgZG9uZTsKPiAgfTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9u ZXQvd2lyZWxlc3MvbWVkaWF0ZWsvbXQ3Ni91c2IuYyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL21l ZGlhdGVrL210NzYvdXNiLmMKPiBpbmRleCBhMTgxMWMzOTQxNWUuLmQ4MmRlNTllYzZkYyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9tZWRpYXRlay9tdDc2L3VzYi5jCj4gKysr IGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvbWVkaWF0ZWsvbXQ3Ni91c2IuYwo+IEBAIC0yOTksMTQg KzI5OSwxNCBAQCBtdDc2dV9maWxsX3J4X3NnKHN0cnVjdCBtdDc2X2RldiAqZGV2LCBzdHJ1Y3Qg bXQ3NnVfYnVmICpidWYsCj4gIAlpZiAoaSA8IG5zZ3MpIHsKPiAgCQlpbnQgajsKPiAgCj4gLQkJ Zm9yIChqID0gbnNnczsgaiA8IHVyYi0+bnVtX3NnczsgaisrKQo+ICsJCWZvciAoaiA9IG5zZ3M7 IGogPCBidWYtPm51bV9zZ3M7IGorKykKPiAgCQkJc2tiX2ZyZWVfZnJhZyhzZ192aXJ0KCZ1cmIt PnNnW2pdKSk7Cj4gLQkJdXJiLT5udW1fc2dzID0gaTsKPiArCQlidWYtPm51bV9zZ3MgPSBpOwo+ ICAJfQo+ICAKPiAtCXVyYi0+bnVtX3NncyA9IG1heF90KGludCwgaSwgdXJiLT5udW1fc2dzKTsK PiAtCWJ1Zi0+bGVuID0gdXJiLT5udW1fc2dzICogc2dsZW4sCj4gLQlzZ19pbml0X21hcmtlcih1 cmItPnNnLCB1cmItPm51bV9zZ3MpOwo+ICsJYnVmLT5udW1fc2dzID0gbWF4X3QoaW50LCBpLCBi dWYtPm51bV9zZ3MpOwo+ICsJYnVmLT5sZW4gPSBidWYtPm51bV9zZ3MgKiBzZ2xlbiwKPiArCXNn X2luaXRfbWFya2VyKHVyYi0+c2csIGJ1Zi0+bnVtX3Nncyk7Cj4gIAo+ICAJcmV0dXJuIGkgPyA6 IC1FTk9NRU07Cj4gIH0KPiBAQCAtMzI1LDYgKzMyNSw3IEBAIGludCBtdDc2dV9idWZfYWxsb2Mo c3RydWN0IG10NzZfZGV2ICpkZXYsIHN0cnVjdCBtdDc2dV9idWYgKmJ1ZiwKPiAgCj4gIAlzZ19p bml0X3RhYmxlKGJ1Zi0+dXJiLT5zZywgbnNncyk7Cj4gIAlidWYtPmRldiA9IGRldjsKPiArCWJ1 Zi0+bnVtX3NncyA9IG5zZ3M7Cj4gIAo+ICAJcmV0dXJuIG10NzZ1X2ZpbGxfcnhfc2coZGV2LCBi dWYsIG5zZ3MsIGxlbiwgc2dsZW4pOwo+ICB9Cj4gQEAgLTMzNiw3ICszMzcsNyBAQCB2b2lkIG10 NzZ1X2J1Zl9mcmVlKHN0cnVjdCBtdDc2dV9idWYgKmJ1ZikKPiAgCXN0cnVjdCBzY2F0dGVybGlz dCAqc2c7Cj4gIAlpbnQgaTsKPiAgCj4gLQlmb3IgKGkgPSAwOyBpIDwgdXJiLT5udW1fc2dzOyBp KyspIHsKPiArCWZvciAoaSA9IDA7IGkgPCBidWYtPm51bV9zZ3M7IGkrKykgewo+ICAJCXNnID0g JnVyYi0+c2dbaV07Cj4gIAkJaWYgKCFzZykKPiAgCQkJY29udGludWU7Cj4gQEAgLTM0Nyw5ICsz NDgsMTAgQEAgdm9pZCBtdDc2dV9idWZfZnJlZShzdHJ1Y3QgbXQ3NnVfYnVmICpidWYpCj4gIH0K PiAgRVhQT1JUX1NZTUJPTF9HUEwobXQ3NnVfYnVmX2ZyZWUpOwo+ICAKPiAtaW50IG10NzZ1X3N1 Ym1pdF9idWYoc3RydWN0IG10NzZfZGV2ICpkZXYsIGludCBkaXIsIGludCBpbmRleCwKPiAtCQkg ICAgIHN0cnVjdCBtdDc2dV9idWYgKmJ1ZiwgZ2ZwX3QgZ2ZwLAo+IC0JCSAgICAgdXNiX2NvbXBs ZXRlX3QgY29tcGxldGVfZm4sIHZvaWQgKmNvbnRleHQpCj4gK3N0YXRpYyB2b2lkCj4gK210NzZ1 X2ZpbGxfYnVsa191cmIoc3RydWN0IG10NzZfZGV2ICpkZXYsIGludCBkaXIsIGludCBpbmRleCwK PiArCQkgICAgc3RydWN0IG10NzZ1X2J1ZiAqYnVmLCB1c2JfY29tcGxldGVfdCBjb21wbGV0ZV9m biwKPiArCQkgICAgdm9pZCAqY29udGV4dCkKPiAgewo+ICAJc3RydWN0IHVzYl9pbnRlcmZhY2Ug KmludGYgPSB0b191c2JfaW50ZXJmYWNlKGRldi0+ZGV2KTsKPiAgCXN0cnVjdCB1c2JfZGV2aWNl ICp1ZGV2ID0gaW50ZXJmYWNlX3RvX3VzYmRldihpbnRmKTsKPiBAQCAtMzYwLDkgKzM2MiwyNSBA QCBpbnQgbXQ3NnVfc3VibWl0X2J1ZihzdHJ1Y3QgbXQ3Nl9kZXYgKmRldiwgaW50IGRpciwgaW50 IGluZGV4LAo+ICAJZWxzZQo+ICAJCXBpcGUgPSB1c2Jfc25kYnVsa3BpcGUodWRldiwgZGV2LT51 c2Iub3V0X2VwW2luZGV4XSk7Cj4gIAo+IC0JdXNiX2ZpbGxfYnVsa191cmIoYnVmLT51cmIsIHVk ZXYsIHBpcGUsIE5VTEwsIGJ1Zi0+bGVuLAo+IC0JCQkgIGNvbXBsZXRlX2ZuLCBjb250ZXh0KTsK PiArCXVzYl9maWxsX2J1bGtfdXJiKGJ1Zi0+dXJiLCB1ZGV2LCBwaXBlLCBOVUxMLCBidWYtPmxl biwgY29tcGxldGVfZm4sCj4gKwkJCSAgY29udGV4dCk7Cj4gKwo+ICsJaWYgKHVkZXYtPmJ1cy0+ c2dfdGFibGVzaXplID4gMCkgewo+ICsJCWJ1Zi0+dXJiLT5udW1fc2dzID0gYnVmLT5udW1fc2dz Owo+ICsJfSBlbHNlIHsKPiArCQlXQVJOX09OX09OQ0UoYnVmLT5udW1fc2dzICE9IDEpOwo+ICsJ CS8qIFNlZSB1c2Jfc2dfaW5pdCgpICovCj4gKwkJYnVmLT51cmItPm51bV9zZ3MgPSAwOwo+ICsJ CWlmICghUGFnZUhpZ2hNZW0oc2dfcGFnZShidWYtPnVyYi0+c2cpKSkKPiArCQkJYnVmLT51cmIt PnRyYW5zZmVyX2J1ZmZlciA9IHNnX3ZpcnQoYnVmLT51cmItPnNnKTsKCnBsZWFzZSBjb3JyZWN0 IG1lIGlmIEkgYW0gd3JvbmcgYnV0IGRvaW5nIHNvIHdlIHdpbGwgdXNlIHRyYW5zZmVyX2J1ZmZl cgpmb3IgOTUlIG9mIHRoZSB1c2UgY2FzZXMsIHJpZ2h0PyBJZiBzbyB3aHkgbm90IGtlZXAgaXQg c2ltcGxlIGFuZCBhbHdheXMKdXNlIGl0IHdoZW4gc2dfdGFibGVzaXplIGlzIDAgKGF2b2lkaW5n IFNHIEkvTyk/CkJ0dyB0aGlzIGlzIHdoYXQgSSBwcm9wb3NlZCB3aXRoIHRoZSBSRkMgc2VyaWVz IGFjdHVhbGx5IDopIChhbHdheXMgdXNlCnRyYW5zZmVyX2J1ZmZlciBpbiB0aGUgdXNiIDIuMCBj YXNlKQoKUmVnYXJkcywKTG9yZW56bwoKPiArCX0KPiArfQo+ICAKPiAraW50IG10NzZ1X3N1Ym1p dF9idWYoc3RydWN0IG10NzZfZGV2ICpkZXYsIGludCBkaXIsIGludCBpbmRleCwKPiArCQkgICAg IHN0cnVjdCBtdDc2dV9idWYgKmJ1ZiwgZ2ZwX3QgZ2ZwLAo+ICsJCSAgICAgdXNiX2NvbXBsZXRl X3QgY29tcGxldGVfZm4sIHZvaWQgKmNvbnRleHQpCj4gK3sKPiArCW10NzZ1X2ZpbGxfYnVsa191 cmIoZGV2LCBkaXIsIGluZGV4LCBidWYsIGNvbXBsZXRlX2ZuLCBjb250ZXh0KTsKPiAgCXJldHVy biB1c2Jfc3VibWl0X3VyYihidWYtPnVyYiwgZ2ZwKTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MX0dQ TChtdDc2dV9zdWJtaXRfYnVmKTsKPiBAQCAtNjcyLDEwICs2OTAsMTEgQEAgc3RhdGljIHZvaWQg bXQ3NnVfY29tcGxldGVfdHgoc3RydWN0IHVyYiAqdXJiKQo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50 Cj4gLW10NzZ1X3R4X2J1aWxkX3NnKHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCB1cmIgKnVy YikKPiArbXQ3NnVfdHhfYnVpbGRfc2coc3RydWN0IHNrX2J1ZmYgKnNrYiwgc3RydWN0IG10NzZ1 X2J1ZiAqYnVmKQo+ICB7Cj4gIAlpbnQgbnNncyA9IDEgKyBza2Jfc2hpbmZvKHNrYiktPm5yX2Zy YWdzOwo+ICAJc3RydWN0IHNrX2J1ZmYgKml0ZXI7Cj4gKwlzdHJ1Y3QgdXJiICp1cmIgPSBidWYt PnVyYjsKPiAgCj4gIAlza2Jfd2Fsa19mcmFncyhza2IsIGl0ZXIpCj4gIAkJbnNncyArPSAxICsg c2tiX3NoaW5mbyhpdGVyKS0+bnJfZnJhZ3M7Cj4gQEAgLTY4NCw3ICs3MDMsOCBAQCBtdDc2dV90 eF9idWlsZF9zZyhzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgdXJiICp1cmIpCj4gIAo+ICAJ bnNncyA9IG1pbl90KGludCwgTVRfU0dfTUFYX1NJWkUsIG5zZ3MpOwo+ICAJc2dfaW5pdF9tYXJr ZXIodXJiLT5zZywgbnNncyk7Cj4gLQl1cmItPm51bV9zZ3MgPSBuc2dzOwo+ICsJYnVmLT5udW1f c2dzID0gbnNnczsKPiArCWJ1Zi0+bGVuID0gc2tiLT5sZW47Cj4gIAo+ICAJcmV0dXJuIHNrYl90 b19zZ3ZlY19ub21hcmsoc2tiLCB1cmItPnNnLCAwLCBza2ItPmxlbik7Cj4gIH0KPiBAQCAtNjk0 LDEyICs3MTQsOSBAQCBtdDc2dV90eF9xdWV1ZV9za2Ioc3RydWN0IG10NzZfZGV2ICpkZXYsIHN0 cnVjdCBtdDc2X3F1ZXVlICpxLAo+ICAJCSAgIHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBt dDc2X3djaWQgKndjaWQsCj4gIAkJICAgc3RydWN0IGllZWU4MDIxMV9zdGEgKnN0YSkKPiAgewo+ IC0Jc3RydWN0IHVzYl9pbnRlcmZhY2UgKmludGYgPSB0b191c2JfaW50ZXJmYWNlKGRldi0+ZGV2 KTsKPiAtCXN0cnVjdCB1c2JfZGV2aWNlICp1ZGV2ID0gaW50ZXJmYWNlX3RvX3VzYmRldihpbnRm KTsKPiAgCXU4IGVwID0gcTJlcChxLT5od19pZHgpOwo+ICAJc3RydWN0IG10NzZ1X2J1ZiAqYnVm Owo+ICAJdTE2IGlkeCA9IHEtPnRhaWw7Cj4gLQl1bnNpZ25lZCBpbnQgcGlwZTsKPiAgCWludCBl cnI7Cj4gIAo+ICAJaWYgKHEtPnF1ZXVlZCA9PSBxLT5uZGVzYykKPiBAQCAtNzEyLDEzICs3Mjks MTEgQEAgbXQ3NnVfdHhfcXVldWVfc2tiKHN0cnVjdCBtdDc2X2RldiAqZGV2LCBzdHJ1Y3QgbXQ3 Nl9xdWV1ZSAqcSwKPiAgCWJ1ZiA9ICZxLT5lbnRyeVtpZHhdLnVidWY7Cj4gIAlidWYtPmRvbmUg PSBmYWxzZTsKPiAgCj4gLQllcnIgPSBtdDc2dV90eF9idWlsZF9zZyhza2IsIGJ1Zi0+dXJiKTsK PiArCWVyciA9IG10NzZ1X3R4X2J1aWxkX3NnKHNrYiwgYnVmKTsKPiAgCWlmIChlcnIgPCAwKQo+ ICAJCXJldHVybiBlcnI7Cj4gIAo+IC0JcGlwZSA9IHVzYl9zbmRidWxrcGlwZSh1ZGV2LCBkZXYt PnVzYi5vdXRfZXBbZXBdKTsKPiAtCXVzYl9maWxsX2J1bGtfdXJiKGJ1Zi0+dXJiLCB1ZGV2LCBw aXBlLCBOVUxMLCBza2ItPmxlbiwKPiAtCQkJICBtdDc2dV9jb21wbGV0ZV90eCwgYnVmKTsKPiAr CW10NzZ1X2ZpbGxfYnVsa191cmIoZGV2LCBVU0JfRElSX09VVCwgZXAsIGJ1ZiwgbXQ3NnVfY29t cGxldGVfdHgsIGJ1Zik7Cj4gIAo+ICAJcS0+dGFpbCA9IChxLT50YWlsICsgMSkgJSBxLT5uZGVz YzsKPiAgCXEtPmVudHJ5W2lkeF0uc2tiID0gc2tiOwo+IC0tIAo+IDIuMTkuMgo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57C5DC282C4 for ; Tue, 12 Feb 2019 11:58:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25D3F206BA for ; Tue, 12 Feb 2019 11:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728546AbfBLL6t (ORCPT ); Tue, 12 Feb 2019 06:58:49 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33561 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728041AbfBLL6s (ORCPT ); Tue, 12 Feb 2019 06:58:48 -0500 Received: by mail-wr1-f65.google.com with SMTP id i12so2410569wrw.0 for ; Tue, 12 Feb 2019 03:58:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MBq4MK1irna6zYc+WgwDk4eBYBJ/c7xw2urAyBWvO+w=; b=tGZ9EXWC7SEV1aqSx/oTjZGUD4tY5mKj9KpvDVgof/Ha3LaVvHuzacTVRqI2zPxVmk 6PxdHxenDwt7+eP2czu4DbYW9kD4ejeYxa+pFd1zB6lRWJNi/umIn1PdDHmZd0Wg3ZRK oEAOjvQzkxEyMy0WYphssuTSdediC+hi3Fmm/sHcH2i3i1TOIKBVUHQT3dcSrQ58QTbq ji8auDx2QLZaOU0QADJH0S/SNuSoU2RuexA25LIXnK8cPOHlgCEuHodxHZ0q41iDj6PF ol/q7fXsv5PlrT/gx09cPyj045r82xwD6Cy52Jeqoyk2q4NYJgTOwUCxPRgyq/ZUSWhv l6MA== X-Gm-Message-State: AHQUAub24gWyn1aJ4J6S2sqJB1AFonBX7r0SxZnCzie72y8T6qcyoKJ8 6yJ9XDlPD4aRpyXjboWomqGYrg== X-Google-Smtp-Source: AHgI3IafYduaHimbP98PlzWdrIpqHl4rjD5Co0pR4qgJE5A510a8oEH/Cb63sJONWEUQV46bSlBXcQ== X-Received: by 2002:a5d:474f:: with SMTP id o15mr2681702wrs.70.1549972726373; Tue, 12 Feb 2019 03:58:46 -0800 (PST) Received: from localhost.localdomain (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id e9sm24433114wrc.56.2019.02.12.03.58.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 03:58:45 -0800 (PST) Date: Tue, 12 Feb 2019 12:58:43 +0100 From: Lorenzo Bianconi To: Stanislaw Gruszka Cc: Alan Stern , Stefan Wahren , Felix Fietkau , Doug Anderson , Minas Harutyunyan , USB list , linux-wireless Subject: Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+ Message-ID: <20190212115842.GA24197@localhost.localdomain> References: <20190211173315.GE6292@redhat.com> <20190212093035.GB12906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212093035.GB12906@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org [...] > In usb_sg_init() urb->num_sgs is set 0 for sg_tablesize = 0 controllers. > In mt76 we set urb->num_sgs to 1. I thought it is fine, but now I think > this is bug. We can fix that without changing allocation method and > still use SG allocation. Attached patch do this, please check if it works > on rpi. Patch is on top of your error path fixes. > > Stanislaw > From f79ac0df967d406523d0a1c03a138d1394e7665a Mon Sep 17 00:00:00 2001 > From: Stanislaw Gruszka > Date: Tue, 12 Feb 2019 10:02:53 +0100 > Subject: [PATCH] mt76usb: do not set urb->num_sgs to 1 for non SG usb host > drivers > > Track number of segments in mt76u_buf structure and do not > submit urbs with urb->num_sgs = 1 if usb host driver > sg_tablesize is zero. > > This suppose fix problem of mt76 not working with some usb > host controllers like dwc2. > > Signed-off-by: Stanislaw Gruszka > --- > drivers/net/wireless/mediatek/mt76/mt76.h | 1 + > drivers/net/wireless/mediatek/mt76/usb.c | 55 ++++++++++++++--------- > 2 files changed, 36 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h > index 2e5bcb3fdff7..eadc913c37b6 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76.h > +++ b/drivers/net/wireless/mediatek/mt76/mt76.h > @@ -86,6 +86,7 @@ struct mt76_queue_buf { > struct mt76u_buf { > struct mt76_dev *dev; > struct urb *urb; > + int num_sgs; > size_t len; > bool done; > }; > diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c > index a1811c39415e..d82de59ec6dc 100644 > --- a/drivers/net/wireless/mediatek/mt76/usb.c > +++ b/drivers/net/wireless/mediatek/mt76/usb.c > @@ -299,14 +299,14 @@ mt76u_fill_rx_sg(struct mt76_dev *dev, struct mt76u_buf *buf, > if (i < nsgs) { > int j; > > - for (j = nsgs; j < urb->num_sgs; j++) > + for (j = nsgs; j < buf->num_sgs; j++) > skb_free_frag(sg_virt(&urb->sg[j])); > - urb->num_sgs = i; > + buf->num_sgs = i; > } > > - urb->num_sgs = max_t(int, i, urb->num_sgs); > - buf->len = urb->num_sgs * sglen, > - sg_init_marker(urb->sg, urb->num_sgs); > + buf->num_sgs = max_t(int, i, buf->num_sgs); > + buf->len = buf->num_sgs * sglen, > + sg_init_marker(urb->sg, buf->num_sgs); > > return i ? : -ENOMEM; > } > @@ -325,6 +325,7 @@ int mt76u_buf_alloc(struct mt76_dev *dev, struct mt76u_buf *buf, > > sg_init_table(buf->urb->sg, nsgs); > buf->dev = dev; > + buf->num_sgs = nsgs; > > return mt76u_fill_rx_sg(dev, buf, nsgs, len, sglen); > } > @@ -336,7 +337,7 @@ void mt76u_buf_free(struct mt76u_buf *buf) > struct scatterlist *sg; > int i; > > - for (i = 0; i < urb->num_sgs; i++) { > + for (i = 0; i < buf->num_sgs; i++) { > sg = &urb->sg[i]; > if (!sg) > continue; > @@ -347,9 +348,10 @@ void mt76u_buf_free(struct mt76u_buf *buf) > } > EXPORT_SYMBOL_GPL(mt76u_buf_free); > > -int mt76u_submit_buf(struct mt76_dev *dev, int dir, int index, > - struct mt76u_buf *buf, gfp_t gfp, > - usb_complete_t complete_fn, void *context) > +static void > +mt76u_fill_bulk_urb(struct mt76_dev *dev, int dir, int index, > + struct mt76u_buf *buf, usb_complete_t complete_fn, > + void *context) > { > struct usb_interface *intf = to_usb_interface(dev->dev); > struct usb_device *udev = interface_to_usbdev(intf); > @@ -360,9 +362,25 @@ int mt76u_submit_buf(struct mt76_dev *dev, int dir, int index, > else > pipe = usb_sndbulkpipe(udev, dev->usb.out_ep[index]); > > - usb_fill_bulk_urb(buf->urb, udev, pipe, NULL, buf->len, > - complete_fn, context); > + usb_fill_bulk_urb(buf->urb, udev, pipe, NULL, buf->len, complete_fn, > + context); > + > + if (udev->bus->sg_tablesize > 0) { > + buf->urb->num_sgs = buf->num_sgs; > + } else { > + WARN_ON_ONCE(buf->num_sgs != 1); > + /* See usb_sg_init() */ > + buf->urb->num_sgs = 0; > + if (!PageHighMem(sg_page(buf->urb->sg))) > + buf->urb->transfer_buffer = sg_virt(buf->urb->sg); please correct me if I am wrong but doing so we will use transfer_buffer for 95% of the use cases, right? If so why not keep it simple and always use it when sg_tablesize is 0 (avoiding SG I/O)? Btw this is what I proposed with the RFC series actually :) (always use transfer_buffer in the usb 2.0 case) Regards, Lorenzo > + } > +} > > +int mt76u_submit_buf(struct mt76_dev *dev, int dir, int index, > + struct mt76u_buf *buf, gfp_t gfp, > + usb_complete_t complete_fn, void *context) > +{ > + mt76u_fill_bulk_urb(dev, dir, index, buf, complete_fn, context); > return usb_submit_urb(buf->urb, gfp); > } > EXPORT_SYMBOL_GPL(mt76u_submit_buf); > @@ -672,10 +690,11 @@ static void mt76u_complete_tx(struct urb *urb) > } > > static int > -mt76u_tx_build_sg(struct sk_buff *skb, struct urb *urb) > +mt76u_tx_build_sg(struct sk_buff *skb, struct mt76u_buf *buf) > { > int nsgs = 1 + skb_shinfo(skb)->nr_frags; > struct sk_buff *iter; > + struct urb *urb = buf->urb; > > skb_walk_frags(skb, iter) > nsgs += 1 + skb_shinfo(iter)->nr_frags; > @@ -684,7 +703,8 @@ mt76u_tx_build_sg(struct sk_buff *skb, struct urb *urb) > > nsgs = min_t(int, MT_SG_MAX_SIZE, nsgs); > sg_init_marker(urb->sg, nsgs); > - urb->num_sgs = nsgs; > + buf->num_sgs = nsgs; > + buf->len = skb->len; > > return skb_to_sgvec_nomark(skb, urb->sg, 0, skb->len); > } > @@ -694,12 +714,9 @@ mt76u_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q, > struct sk_buff *skb, struct mt76_wcid *wcid, > struct ieee80211_sta *sta) > { > - struct usb_interface *intf = to_usb_interface(dev->dev); > - struct usb_device *udev = interface_to_usbdev(intf); > u8 ep = q2ep(q->hw_idx); > struct mt76u_buf *buf; > u16 idx = q->tail; > - unsigned int pipe; > int err; > > if (q->queued == q->ndesc) > @@ -712,13 +729,11 @@ mt76u_tx_queue_skb(struct mt76_dev *dev, struct mt76_queue *q, > buf = &q->entry[idx].ubuf; > buf->done = false; > > - err = mt76u_tx_build_sg(skb, buf->urb); > + err = mt76u_tx_build_sg(skb, buf); > if (err < 0) > return err; > > - pipe = usb_sndbulkpipe(udev, dev->usb.out_ep[ep]); > - usb_fill_bulk_urb(buf->urb, udev, pipe, NULL, skb->len, > - mt76u_complete_tx, buf); > + mt76u_fill_bulk_urb(dev, USB_DIR_OUT, ep, buf, mt76u_complete_tx, buf); > > q->tail = (q->tail + 1) % q->ndesc; > q->entry[idx].skb = skb; > -- > 2.19.2 >