From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 03/12] drm/drv: DOC: Add driver example code Date: Tue, 12 Feb 2019 15:06:12 +0100 Message-ID: <20190212140612.GA23159@phenom.ffwll.local> References: <20190210131039.52664-1-noralf@tronnes.org> <20190210131039.52664-4-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDB0C6E005 for ; Tue, 12 Feb 2019 14:06:16 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id a2so2328028edi.0 for ; Tue, 12 Feb 2019 06:06:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190210131039.52664-4-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBGZWIgMTAsIDIwMTkgYXQgMDI6MTA6MzBQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IEFkZCBkcml2ZXIgZXhhbXBsZSB0aGF0IHNob3dzIGhvdyBkZXZtX2RybV9kZXZf aW5pdCgpIGNhbiBiZSB1c2VkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8 bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+IAo+IEknbSBub3Qgc3VyZSBob3cgZGV0YWlsZWQg c3VjaCBhbiBleGFtcGxlIHN1Y2ggYmUgYW5kIGEgZGVzY3JpcHRpb24gb2YgCj4gc29tZSBraW5k IGlzIGFsc28gcmVxdWlyZWQuIEhlbHAgaXMgbmVlZGVkIDotKQoKUGVyc29uYWxseSBJJ2QgbWFr ZSBpdCBtb3JlIG1pbmltYWwsIHBzZXVkby1jb2RlIHN0eWxlLCByZW1vdmluZyBtb3N0IG9mCnRo ZSBib2lsZXJwbGF0ZSAoZS5nLiB0aGUgY29udGFpbmVyX29mIHdyYXBwZXIpLiBUaGF0IHdheSBp dCBjYW4gaGlnaGxpZ2h0CnRoZSBpbXBvcnRhbnQgYml0cyBtb3JlLiBCdXQgaXQncyBhbHJlYWR5 IHZlcnkgbWluaW1hbC4KCldydCB0ZXh0LCBtYXliZSBhIG1pbmltYWwgaW50cm8gcGFyYWdyYXBo LiBBc2lkZSBmcm9tIHRoYXQgbG9va3MgYWxsIGdvb2QKdG8gbWUuCgpBY2tlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCk9uZSBxdWVzdGlvbiBiZWxvdy4KPiAK PiBOb3JhbGYuCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMgfCAxMTggKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDExOCBpbnNl cnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4gaW5kZXggMzUxZjEyOGVjNGI3Li45OWNhMzU1MTY4 OGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZHJ2LmMKPiBAQCAtMjg2LDYgKzI4NiwxMjQgQEAgdm9pZCBkcm1fbWlu b3JfcmVsZWFzZShzdHJ1Y3QgZHJtX21pbm9yICptaW5vcikKPiAgICogTm90ZSB0aGF0IHRoZSBs aWZldGltZSBydWxlcyBmb3IgJmRybV9kZXZpY2UgaW5zdGFuY2UgaGFzIHN0aWxsIGEgbG90IG9m Cj4gICAqIGhpc3RvcmljYWwgYmFnZ2FnZS4gSGVuY2UgdXNlIHRoZSByZWZlcmVuY2UgY291bnRp bmcgcHJvdmlkZWQgYnkKPiAgICogZHJtX2Rldl9nZXQoKSBhbmQgZHJtX2Rldl9wdXQoKSBvbmx5 IGNhcmVmdWxseS4KPiArICoKPiArICogRGlzcGxheSBkcml2ZXIgZXhhbXBsZQo+ICsgKiB+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+Cj4gKyAqCj4gKyAqIC4uIGNvZGUtYmxvY2s6OiBjCj4gKyAqCj4g KyAqCXN0cnVjdCBkcml2ZXJfZGV2aWNlIHsKPiArICoJCXN0cnVjdCBkcm1fZGV2aWNlIGRybTsK PiArICoJCXZvaWQgKnVzZXJzcGFjZV9mYWNpbmc7Cj4gKyAqCQlzdHJ1Y3QgY2xrICpwY2xrOwo+ ICsgKgl9Owo+ICsgKgo+ICsgKglzdGF0aWMgaW5saW5lIHN0cnVjdCBkcml2ZXJfZGV2aWNlICpk cm1fdG9fcHJpdihzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICsgKgl7Cj4gKyAqCQlyZXR1cm4g Y29udGFpbmVyX29mKGRybSwgc3RydWN0IGRyaXZlcl9kZXZpY2UsIGRybSk7Cj4gKyAqCX0KPiAr ICoKPiArICoJc3RhdGljIHZvaWQgZHJpdmVyX2RybV9yZWxlYXNlKHN0cnVjdCBkcm1fZGV2aWNl ICpkcm0pCj4gKyAqCXsKPiArICoJCXN0cnVjdCBkcml2ZXJfZGV2aWNlICpwcml2ID0gZHJtX3Rv X3ByaXYoZHJtKTsKPiArICoKPiArICoJCWRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybSk7Cj4g KyAqCQlkcm1fZGV2X2ZpbmkoZHJtKTsKPiArICoJCWtmcmVlKHByaXYtPnVzZXJzcGFjZV9mYWNp bmcpOwo+ICsgKgkJa2ZyZWUocHJpdik7Cj4gKyAqCX0KPiArICoKPiArICoJc3RhdGljIHN0cnVj dCBkcm1fZHJpdmVyIGRyaXZlcl9kcm1fZHJpdmVyID0gewo+ICsgKgkJWy4uLl0KPiArICoJCS5y ZWxlYXNlID0gZHJpdmVyX2RybV9yZWxlYXNlLAo+ICsgKgl9Owo+ICsgKgo+ICsgKglzdGF0aWMg aW50IGRyaXZlcl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICsgKgl7Cj4g KyAqCQlzdHJ1Y3QgZHJpdmVyX2RldmljZSAqcHJpdjsKPiArICoJCXN0cnVjdCBkcm1fZGV2aWNl ICpkcm07Cj4gKyAqCQlpbnQgcmV0Owo+ICsgKgo+ICsgKgkJcHJpdiA9IGt6YWxsb2Moc2l6ZW9m KCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4gKyAqCQlpZiAoIXByaXYpCj4gKyAqCQkJcmV0dXJuIC1F Tk9NRU07Cj4gKyAqCj4gKyAqCQlkcm0gPSAmcHJpdi0+ZHJtOwo+ICsgKgo+ICsgKgkJcmV0ID0g ZGV2bV9kcm1fZGV2X2luaXQoJnBkZXYtPmRldiwgZHJtLCAmZHJpdmVyX2RybV9kcml2ZXIpOwo+ ICsgKgkJaWYgKHJldCkgewo+ICsgKgkJCWtmcmVlKGRybSk7Cj4gKyAqCQkJcmV0dXJuIHJldDsK PiArICoJCX0KPiArICoKPiArICoJCWRybV9tb2RlX2NvbmZpZ19pbml0KGRybSk7Cj4gKyAqCj4g KyAqCQlwcml2LT51c2Vyc3BhY2VfZmFjaW5nID0ga3phbGxvYyguLi4sIEdGUF9LRVJORUwpOwo+ ICsgKgkJaWYgKCFwcml2LT51c2Vyc3BhY2VfZmFjaW5nKQo+ICsgKgkJCXJldHVybiAtRU5PTUVN Owo+ICsgKgo+ICsgKgkJcHJpdi0+cGNsayA9IGRldm1fY2xrX2dldChkZXYsICJQQ0xLIik7Cj4g KyAqCQlpZiAoSVNfRVJSKHByaXYtPnBjbGspKQo+ICsgKgkJCXJldHVybiBQVFJfRVJSKHByaXYt PnBjbGspOwo+ICsgKgo+ICsgKgkJWyBGdXJ0aGVyIHNldHVwLCBkaXNwbGF5IHBpcGVsaW5lIGV0 YyBdCj4gKyAqCj4gKyAqCQlkcm1fbW9kZV9jb25maWdfcmVzZXQoZHJtKTsKPiArICoKPiArICoJ CXJldCA9IGRybV9kZXZfcmVnaXN0ZXIoZHJtKTsKPiArICoJCWlmIChyZXQpCj4gKyAqCQkJcmV0 dXJuIHJldDsKPiArICoKPiArICoJCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRybSk7CgpI bSwgZG9uJ3Qgd2UgbmVlZCB0byBzZXQgdGhhdCBiZWZvcmUgcmVnaXN0ZXJpbmc/IE9yIGV2ZW4g YmVmb3JlCmRybV9tb2RlX2NvbmZpZ19yZXNldD8gS2luZGEgZGVwZW5kcyB1cG9uIHdoYXQgdGhl IGRyaXZlciBpcyB1c2luZyB0aGUKZHJ2ZGF0YSBmb3IuCgo+ICsgKgo+ICsgKgkJZHJtX2ZiZGV2 X2dlbmVyaWNfc2V0dXAoZHJtLCAzMik7Cj4gKyAqCj4gKyAqCQlyZXR1cm4gMDsKPiArICoJfQo+ ICsgKgo+ICsgKglbIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIGJlZm9yZSB0aGUgZGV2bV8gcmVz b3VyY2VzIGFyZSByZWxlYXNlZCBdCj4gKyAqCXN0YXRpYyBpbnQgZHJpdmVyX3JlbW92ZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICsgKgl7Cj4gKyAqCQlzdHJ1Y3QgZHJtX2Rldmlj ZSAqZHJtID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gKyAqCj4gKyAqCQlkcm1fZGV2 X3VucmVnaXN0ZXIoZHJtKTsKPiArICoJCWRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKGRybSkK PiArICoKPiArICoJCXJldHVybiAwOwo+ICsgKgl9Cj4gKyAqCj4gKyAqCXN0YXRpYyB2b2lkIGRy aXZlcl9zaHV0ZG93bihzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICsgKgl7Cj4gKyAq CQlkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bihwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KSk7 Cj4gKyAqCX0KPiArICoKPiArICoJc3RhdGljIGludCBfX21heWJlX3VudXNlZCBkcml2ZXJfcG1f c3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gKyAqCXsKPiArICoJCXJldHVybiBkcm1fbW9k ZV9jb25maWdfaGVscGVyX3N1c3BlbmQoZGV2X2dldF9kcnZkYXRhKGRldikpOwo+ICsgKgl9Cj4g KyAqCj4gKyAqCXN0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgZHJpdmVyX3BtX3Jlc3VtZShzdHJ1 Y3QgZGV2aWNlICpkZXYpCj4gKyAqCXsKPiArICoJCWRybV9tb2RlX2NvbmZpZ19oZWxwZXJfcmVz dW1lKGRldl9nZXRfZHJ2ZGF0YShkZXYpKTsKPiArICoKPiArICoJCXJldHVybiAwOwo+ICsgKgl9 Cj4gKyAqCj4gKyAqCXN0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBkcml2ZXJfcG1fb3Bz ID0gewo+ICsgKgkJU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFMoZHJpdmVyX3BtX3N1c3BlbmQsIGRy aXZlcl9wbV9yZXN1bWUpCj4gKyAqCX07Cj4gKyAqCj4gKyAqCXN0YXRpYyBzdHJ1Y3QgcGxhdGZv cm1fZHJpdmVyIGRyaXZlcl9kcml2ZXIgPSB7Cj4gKyAqCQkuZHJpdmVyID0gewo+ICsgKgkJCVsu Li5dCj4gKyAqCQkJLnBtID0gJmRyaXZlcl9wbV9vcHMsCj4gKyAqCQl9LAo+ICsgKgkJLnByb2Jl ID0gZHJpdmVyX3Byb2JlLAo+ICsgKgkJLnJlbW92ZSA9IGRyaXZlcl9yZW1vdmUsCj4gKyAqCQku c2h1dGRvd24gPSBkcml2ZXJfc2h1dGRvd24sCj4gKyAqCX07Cj4gKyAqCW1vZHVsZV9wbGF0Zm9y bV9kcml2ZXIoZHJpdmVyX2RyaXZlcik7Cj4gKyAqCj4gICAqLwo+ICAKPiAgLyoqCj4gLS0gCj4g Mi4yMC4xCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs