Re: ✓ Fi.CI.IGT: success for Add support for Gen 11 pipe color features (rev9)

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Feb 12, 2019 at 12:37:40PM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Patchwork [mailto:patchwork@emeril.freedesktop.org]
> >Sent: Monday, February 11, 2019 11:16 PM
> >To: Shankar, Uma <uma.shankar@intel.com>
> >Cc: intel-gfx@lists.freedesktop.org
> >Subject: ✓ Fi.CI.IGT: success for Add support for Gen 11 pipe color features (rev9)
> >
> >== Series Details ==
> >
> >Series: Add support for Gen 11 pipe color features (rev9)
> >URL   : https://patchwork.freedesktop.org/series/51408/
> >State : success
> >
> >== Summary ==
> >
> >CI Bug Log - changes from CI_DRM_5588_full -> Patchwork_12192_full
> >====================================================
> >
> >Summary
> >-------
> >
> >  **WARNING**
> >
> >  Minor unknown changes coming with Patchwork_12192_full need to be verified
> >  manually.
> >
> >  If you think the reported changes have nothing to do with the changes
> >  introduced in Patchwork_12192_full, please notify your bug team to allow them
> >  to document this new failure mode, which will reduce false positives in CI.
> >
> >
> >
> >Possible new issues
> >-------------------
> >
> >  Here are the unknown changes that may have been introduced in
> >Patchwork_12192_full:
> >
> >### IGT changes ###
> >
> >#### Warnings ####
> >
> >  * igt@kms_color@pipe-c-degamma:
> >    - shard-glk:          {SKIP} [fdo#109271] -> FAIL +4
> 
> This is due to CRC mismatch which happens due to rounding issues in pipe.
> So, crc may not match exactly. These tests rely on crc to match which may not happen here.
> 
> We are extending and re-using code from GLK. Currently GLK has all this disabled in driver and hence
> tests  were skipped. But ideally it should not, since its working fine just the crc mismatch are there.
> It is same for ICL.
> 
> Pipe output however is correct and I have verified on simulation that we get exact bit wise match.
> This is what even we are facing on some of the planar format testing. 
> 
> For this series, I believe we can mark these tests as known issues with how current
> hardware behaves. We can create a separate task and work within team to come up with different ideas
> to test these in CI.

At least one problem is that the uapi doesn't allow us to say 1.0
which is what we need for all the interpolated gamma modes. Not sure
if the test is calculating the other entries correctly either for
these interpolated modes.

But not sure if this has anything to do with the crc mismatches.

Anyways series looks all right to me:
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

A few things we probably would want to do as a followup:
- abstract the output csc vs. pipe csc a bit to avoid
  the code duplication. Maybe parametrize the registers,
  or just add a function for each that takes in the coeffs
  as a parameter.
- readout seems to be missing for the new crtc state stuff

> 
> Regards,
> Uma Shankar
> 
> >Known issues
> >------------
> >
> >  Here are the changes found in Patchwork_12192_full that come from known issues:
> >
> >### IGT changes ###
> >
> >#### Issues hit ####
> >
> >  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
> >    - shard-hsw:          PASS -> DMESG-WARN [fdo#107956]
> >
> >  * igt@kms_color@pipe-c-ctm-max:
> >    - shard-apl:          PASS -> FAIL [fdo#108147]
> >
> >  * igt@kms_cursor_crc@cursor-128x128-suspend:
> >    - shard-hsw:          PASS -> INCOMPLETE [fdo#103540]
> >
> >  * igt@kms_cursor_crc@cursor-256x85-sliding:
> >    - shard-apl:          PASS -> FAIL [fdo#103232]
> >
> >  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
> >    - shard-apl:          PASS -> FAIL [fdo#103167] +1
> >
> >  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
> >    - shard-apl:          PASS -> FAIL [fdo#108948]
> >
> >  * igt@kms_plane@plane-position-covered-pipe-a-planes:
> >    - shard-glk:          PASS -> FAIL [fdo#103166]
> >
> >  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> >    - shard-apl:          PASS -> FAIL [fdo#103166] +1
> >
> >  * igt@kms_setmode@basic:
> >    - shard-kbl:          PASS -> FAIL [fdo#99912]
> >
> >
> >#### Possible fixes ####
> >
> >  * igt@gem_eio@unwedge-stress:
> >    - shard-snb:          FAIL [fdo#107799] -> PASS
> >
> >  * igt@i915_suspend@fence-restore-untiled:
> >    - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> >
> >  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> >    - shard-glk:          FAIL [fdo#108145] -> PASS
> >
> >  * igt@kms_color@pipe-b-ctm-green-to-red:
> >    - shard-glk:          {SKIP} [fdo#109271] -> PASS +29
> >
> >  * igt@kms_cursor_legacy@all-pipes-torture-move:
> >    - shard-hsw:          DMESG-WARN [fdo#107122] -> PASS
> >
> >  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
> >    - shard-glk:          FAIL [fdo#103167] -> PASS +1
> >
> >  * igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
> >    - shard-apl:          FAIL [fdo#103166] -> PASS +2
> >
> >
> >#### Warnings ####
> >
> >  * igt@i915_suspend@shrink:
> >    - shard-apl:          DMESG-WARN [fdo#107886] / [fdo#109244] -> INCOMPLETE
> >[fdo#103927] / [fdo#106886]
> >    - shard-glk:          INCOMPLETE [fdo#103359] / [fdo#106886] / [k.org#198133] ->
> >DMESG-WARN [fdo#109244]
> >
> >  * igt@kms_color@pipe-a-degamma:
> >    - shard-glk:          {SKIP} [fdo#109271] -> FAIL [fdo#108145]
> >
> >
> >  {name}: This element is suppressed. This means it is ignored when computing
> >          the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> >  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> >  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> >  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> >  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> >  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> >  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> >  [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
> >  [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
> >  [fdo#107799]: https://bugs.freedesktop.org/show_bug.cgi?id=107799
> >  [fdo#107886]: https://bugs.freedesktop.org/show_bug.cgi?id=107886
> >  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> >  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
> >  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
> >  [fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
> >  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> >  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> >
> >
> >Participating hosts (7 -> 5)
> >------------------------------
> >
> >  Missing    (2): shard-skl shard-iclb
> >
> >
> >Build changes
> >-------------
> >
> >    * Linux: CI_DRM_5588 -> Patchwork_12192
> >
> >  CI_DRM_5588: 133ed6b29f62713f2edd95eac6ccc2ae1d6e4d6e @
> >git://anongit.freedesktop.org/gfx-ci/linux
> >  IGT_4816: f62577c85c9ef0539d468d6fad105b706a15139c @
> >git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >  Patchwork_12192: a781ee195597d269666195f2709e7bb404446d55 @
> >git://anongit.freedesktop.org/gfx-ci/linux
> >  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> >git://anongit.freedesktop.org/piglit
> >
> >== Logs ==
> >
> >For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12192/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx