From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: [PATCH v7 5/7] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() Date: Tue, 12 Feb 2019 10:48:05 -0800 Message-ID: <20190212184807.20304-6-guro@fb.com> References: <20190212184807.20304-1-guro@fb.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EXXdq7GrYAICjYexP9jF/A5d/mueQ96ws92MW4tT5O4=; b=LQpG3etk7MTKXkfQSPMgt1GsnnOOJYCT94TODTqM2M4NDx7aIxlM1gAMAGiH2LBzkK NsRzL1/yNTTUICGEVjV5WPrLB+lyt/3CIefoAEWj5uyYfaYJ0ifBO/3LHtyzQtZGj4OJ gkjtVGi1ypGgB81f/5pHoPT5OFe77VWTI2QSlF0ZMCXvXMmHq36ciHy7f0Yh+e0tveoe XDPch2lyiJKH5xe/oQcdyVzCxF5/izdKBGpK+blGJmNJNgp8kOWczhtjfnc/Xnb/7l0q 8MtaUhoRHjMPgW8tfeTeulUr68IHzq0NoJ496q8NQk/IDPxLha0Y2VDeACSRbftDPECt vCgA== In-Reply-To: <20190212184807.20304-1-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo , Oleg Nesterov Cc: kernel-team@fb.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shuah Khan , linux-kselftest@vger.kernel.org If the cgroup destruction races with an exit() of a belonging process(es), cg_kill_all() may fail. It's not a good reason to make cg_destroy() fail and leave the cgroup in place, potentially causing next test runs to fail. Signed-off-by: Roman Gushchin Cc: Shuah Khan Cc: Tejun Heo Cc: kernel-team@fb.com Cc: linux-kselftest@vger.kernel.org --- tools/testing/selftests/cgroup/cgroup_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 14c9fe284806..eba06f94433b 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup) retry: ret = rmdir(cgroup); if (ret && errno == EBUSY) { - ret = cg_killall(cgroup); - if (ret) - return ret; + cg_killall(cgroup); usleep(100); goto retry; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: guroan at gmail.com (Roman Gushchin) Date: Tue, 12 Feb 2019 10:48:05 -0800 Subject: [PATCH v7 5/7] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() In-Reply-To: <20190212184807.20304-1-guro@fb.com> References: <20190212184807.20304-1-guro@fb.com> Message-ID: <20190212184807.20304-6-guro@fb.com> If the cgroup destruction races with an exit() of a belonging process(es), cg_kill_all() may fail. It's not a good reason to make cg_destroy() fail and leave the cgroup in place, potentially causing next test runs to fail. Signed-off-by: Roman Gushchin Cc: Shuah Khan Cc: Tejun Heo Cc: kernel-team at fb.com Cc: linux-kselftest at vger.kernel.org --- tools/testing/selftests/cgroup/cgroup_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 14c9fe284806..eba06f94433b 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup) retry: ret = rmdir(cgroup); if (ret && errno == EBUSY) { - ret = cg_killall(cgroup); - if (ret) - return ret; + cg_killall(cgroup); usleep(100); goto retry; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: guroan@gmail.com (Roman Gushchin) Date: Tue, 12 Feb 2019 10:48:05 -0800 Subject: [PATCH v7 5/7] kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy() In-Reply-To: <20190212184807.20304-1-guro@fb.com> References: <20190212184807.20304-1-guro@fb.com> Message-ID: <20190212184807.20304-6-guro@fb.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190212184805.uV-s979jNSF6--tR9u1gsof1qvFp30Ux4Srh3pY1v70@z> If the cgroup destruction races with an exit() of a belonging process(es), cg_kill_all() may fail. It's not a good reason to make cg_destroy() fail and leave the cgroup in place, potentially causing next test runs to fail. Signed-off-by: Roman Gushchin Cc: Shuah Khan Cc: Tejun Heo Cc: kernel-team at fb.com Cc: linux-kselftest at vger.kernel.org --- tools/testing/selftests/cgroup/cgroup_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c index 14c9fe284806..eba06f94433b 100644 --- a/tools/testing/selftests/cgroup/cgroup_util.c +++ b/tools/testing/selftests/cgroup/cgroup_util.c @@ -227,9 +227,7 @@ int cg_destroy(const char *cgroup) retry: ret = rmdir(cgroup); if (ret && errno == EBUSY) { - ret = cg_killall(cgroup); - if (ret) - return ret; + cg_killall(cgroup); usleep(100); goto retry; } -- 2.20.1