From: Andi Shyti via igt-dev <igt-dev@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>,
Andi Shyti <andi@etezian.org>,
Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [RFC PATCH v8 4/5] lib: ioctl_wrappers: reach engines by index as well
Date: Wed, 13 Feb 2019 03:11:03 +0200 [thread overview]
Message-ID: <20190213011029.GC4740@intel.intel> (raw)
In-Reply-To: <155001714462.13414.756418260848193187@skylake-alporthouse-com>
Hi Chris,
> > -bool gem_has_ring(int fd, unsigned ring)
> > +bool gem_has_ring_by_idx(int fd, unsigned idx, unsigned rsvd1)
>
> __gem_has_ring(int fd, uint32_t ctx, unsigned int ring)
>
> #define gem_has_ring(fd, ring) __gem_has_ring(fd, 0, ring)
>
> * mutters rsvd1!
Yes, that's quite a controversy: the concept of 'ring' is swapped
depending on whether you call 'gem_has_ring' or
'gem_has_ring_by_idx' and I bet there is no naming choice that
would please both callers. Unless I use neutral names, like 'a'
and 'b', or 'x' and 'y'.
That's why originally I called it 'flags' and 'rsvd1' as they are
called in the 'drm_i915_gem_execbuffer2' structure, in order to
minimize confusion.
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-13 1:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 23:54 [igt-dev] [RFC PATCH v8 0/5] new engine discovery interface Andi Shyti via igt-dev
2019-02-12 23:54 ` [igt-dev] [RFC PATCH v8 1/5] include/drm-uapi: import i915_drm.h header file Andi Shyti via igt-dev
2019-02-12 23:54 ` [igt-dev] [RFC PATCH v8 2/5] lib/i915: add gem_query library Andi Shyti via igt-dev
2019-02-13 0:13 ` Chris Wilson
2019-02-13 0:55 ` Andi Shyti via igt-dev
2019-02-13 9:19 ` Chris Wilson
2019-02-13 9:55 ` Andi Shyti via igt-dev
2019-02-13 10:00 ` Chris Wilson
2019-02-12 23:54 ` [igt-dev] [RFC PATCH v8 3/5] lib/igt_gt: use for_each_engine2 to loop through engines Andi Shyti via igt-dev
2019-02-13 0:16 ` Chris Wilson
2019-02-13 1:19 ` Andi Shyti via igt-dev
2019-02-13 9:20 ` Chris Wilson
2019-02-13 11:07 ` Andi Shyti via igt-dev
2019-02-12 23:54 ` [igt-dev] [RFC PATCH v8 4/5] lib: ioctl_wrappers: reach engines by index as well Andi Shyti via igt-dev
2019-02-13 0:19 ` Chris Wilson
2019-02-13 1:11 ` Andi Shyti via igt-dev [this message]
2019-02-13 9:22 ` Chris Wilson
2019-02-12 23:54 ` [igt-dev] [RFC PATCH v8 5/5] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test Andi Shyti via igt-dev
2019-02-13 0:23 ` Chris Wilson
2019-02-13 1:02 ` Andi Shyti via igt-dev
2019-02-13 0:28 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-02-13 2:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213011029.GC4740@intel.intel \
--to=igt-dev@lists.freedesktop.org \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=chris@chris-wilson.co.uk \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.