From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: bsz@semihalf.com, matthewgarrett@google.com
Cc: linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, peterhuewe@gmx.de,
ard.biesheuvel@linaro.org, tweek@google.com, mingo@kernel.org,
hdegoede@redhat.com, leif.lindholm@linaro.org, mw@semihalf.com
Subject: Re: [PATCH 1/5] tpm: Copy calc_tpm2_event_size() to TPM library
Date: Wed, 13 Feb 2019 13:18:06 +0200 [thread overview]
Message-ID: <20190213111806.GF7087@linux.intel.com> (raw)
In-Reply-To: <20190213111443.GE7087@linux.intel.com>
On Wed, Feb 13, 2019 at 01:14:43PM +0200, Jarkko Sakkinen wrote:
> On Mon, Feb 11, 2019 at 03:30:48PM +0100, bsz@semihalf.com wrote:
> > From: Bartosz Szczepanek <bsz@semihalf.com>
> >
> > Function to calculate event size in TPM 2.0 log will also be needed in EFI
> > stub. Separate it to library to make it accessible out of TPM character
> > driver.
> >
> > It will be removed from tpm2.c in subsequent commit.
> >
> > Signed-off-by: Bartosz Szczepanek <bsz@semihalf.com>
>
> Collides with Matthew's patch set, which has priority over this because
> it was sent earlier.
>
> Matthew, what you think of this? Maybe could replace 1/4 with this in
> your patch set? Somehow feels a bit cleaner approach.
This commit is in any case broken. It leaves two versions of the
function hanging to the code base.
/Jarkko
next prev parent reply other threads:[~2019-02-13 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 14:30 [PATCH 0/5] Add support for TPM event log 2.0 on EFI/ARM bsz
2019-02-11 14:30 ` [PATCH 1/5] tpm: Copy calc_tpm2_event_size() to TPM library bsz
2019-02-13 11:14 ` Jarkko Sakkinen
2019-02-13 11:18 ` Jarkko Sakkinen [this message]
2019-02-11 14:30 ` [PATCH 2/5] tpm: Change calc_tpm2_event_size signature bsz
2019-02-13 11:20 ` Jarkko Sakkinen
2019-02-11 14:30 ` [PATCH 3/5] tpm: Use library version of calc_tpm2_event_size in sysfs code bsz
2019-02-13 11:22 ` Jarkko Sakkinen
2019-02-11 14:30 ` [PATCH 4/5] efi/libstub/tpm: Retrieve TPM event log in 2.0 format bsz
2019-02-13 11:26 ` Jarkko Sakkinen
2019-02-13 14:21 ` Bartosz Szczepanek
2019-02-13 14:22 ` Ard Biesheuvel
2019-02-11 14:30 ` [PATCH 5/5] efi/arm: Retrieve TPM event log at efi_entry bsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213111806.GF7087@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bsz@semihalf.com \
--cc=hdegoede@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=mingo@kernel.org \
--cc=mw@semihalf.com \
--cc=peterhuewe@gmx.de \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.