From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding via dri-devel Subject: Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting Date: Wed, 13 Feb 2019 13:41:26 +0100 Message-ID: <20190213124126.GG647@ulmo> References: Reply-To: Thierry Reding Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1331269376==" Return-path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1167F6E721 for ; Wed, 13 Feb 2019 12:41:30 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id m1so2295052wml.2 for ; Wed, 13 Feb 2019 04:41:29 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David =?utf-8?Q?Santamar=C3=ADa?= Rogado Cc: David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1331269376== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2E/hm+v6kSLEYT3h" Content-Disposition: inline --2E/hm+v6kSLEYT3h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamar=C3=ADa Rogado wrot= e: > Sorry previous one wasn't signed off by. And now you've got this comment in the commit message that's going to confuse people looking at the log. It's usually to put this kind of comment below the --- line... > The (void *) casting in the driver_data variable assignment is superfluou= s. > Spotted by Jani Nikula. >=20 > Signed-off-by: David Santamar=C3=ADa Rogado > --- =2E.. right here. > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Otherwise, looks good to me: Acked-by: Thierry Reding --2E/hm+v6kSLEYT3h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlxkEHYACgkQ3SOs138+ s6EQLhAAry6KTxMp8vewfKJACkjHJuIsX86/VkDQgdD1y2NZjeHJ1uZuN2Yq++li 9c0R5+zrMJEHXK+2l297S39yIFyOLRKU3xQCvuqTraK5cXIiATUKSuwHFKjHcVwP SQKAxY2u1D/21i64W8BkXWx74Bw9/ZGG8WrfEOhfO8cgT+8vsLeEsF15miFKrhU5 5T2pACnQeqGjsXDkj4AYYtn4aCCRBuicUtkJaaAZoXTZODxoEwwJB/NN+246u8f4 mkAlgXoWk5mUd/Q7/A5IQ2VP6pNbk1eir17JTNkulrATb5P8KMaIYQJIqWK2jLH7 IUbd0/z5kLYAT2KbxrSvl+WsgoNXr60RqynHtTR5252BopDpm+tO2UWNw1m76Q4o uRkhlwc30eSwThAGHwE0Qg+AW2QmJzHCOT2YOAoJj2GPjItpJ7cxYEGlUVfrVMEZ Ew7iPXbbedWwNzm9ue4PZZ3Z7e40gqB6F5liBDqxOyXW0erN9yoXPvbN1kXmUK6b m/N7ijiC5D5AmXLYrqzszaB3a61QSCToY1p2FpfKjeVqtfE7Xyu2eDwjCz76IAW2 D9l8kYRMknIqus0TscWLespttwM3UdcLEVtnCvm4fOj4RV7c2qC2cGzqQobOjsY3 kvEiV7XIz1pI/rDi1tKEa1obk/D7Gv8wMEm8lUjNHUsoB8y6qrQ= =YTW0 -----END PGP SIGNATURE----- --2E/hm+v6kSLEYT3h-- --===============1331269376== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1331269376==--