From: Yuval Shaia <yuval.shaia@oracle.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
dgilbert@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument
Date: Wed, 13 Feb 2019 16:46:30 +0200 [thread overview]
Message-ID: <20190213144629.GA10728@lap1> (raw)
In-Reply-To: <d460be76-ceb9-16ba-6cc7-56541a420753@redhat.com>
On Wed, Feb 13, 2019 at 01:40:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/13/19 7:53 AM, Yuval Shaia wrote:
> > The function argument rdma_dev_res is not needed as it is stored in the
> > backend_dev object at init.
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> > Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
>
> Should we teach checkpatch.pl to check name/space/email?
Nice idea :)
Marcel, i copied it from your signature so you may want to check it.
Anyway, is re-spin needed or you can fix it for the PR?
Yuval
next prev parent reply other threads:[~2019-02-13 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:53 [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 1/9] hw/rdma: Switch to generic error reporting way Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 2/9] hw/rdma: Introduce protected qlist Yuval Shaia
2019-02-14 13:17 ` Marcel Apfelbaum
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 3/9] hw/rdma: Protect against concurrent execution of poll_cq Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface Yuval Shaia
2019-02-13 10:21 ` Dr. David Alan Gilbert
2019-02-14 13:17 ` Marcel Apfelbaum
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 5/9] hw/rdma: Free all MAD receive buffers when device is closed Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 6/9] hw/rdma: Free all receive buffers when QP is destroyed Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument Yuval Shaia
2019-02-13 12:40 ` Philippe Mathieu-Daudé
2019-02-13 14:46 ` Yuval Shaia [this message]
2019-02-14 13:18 ` Marcel Apfelbaum
2019-02-13 15:40 ` Eric Blake
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 8/9] hw/pvrdma: Delete pvrdma_exit function Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 9/9] hw/pvrdma: Unregister from shutdown notifier when device goes down Yuval Shaia
2019-02-14 14:14 ` [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213144629.GA10728@lap1 \
--to=yuval.shaia@oracle.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.