From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= via dri-devel Subject: Re: [PATCH v2] drm: Merge __drm_atomic_helper_disable_all() into drm_atomic_helper_disable_all() Date: Wed, 13 Feb 2019 17:35:05 +0200 Message-ID: <20190213153505.GG20097@intel.com> References: <20190212170816.GJ114153@art_vandelay> <20190212173245.51980-1-sean@poorly.run> Reply-To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EEB2D6E778 for ; Wed, 13 Feb 2019 15:35:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190212173245.51980-1-sean@poorly.run> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: Sinclair Yeh , Maxime Ripard , dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMTIsIDIwMTkgYXQgMTI6MzI6NDFQTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFRoZSBvbmx5 IGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgZnVuY3Rpb25zIGlzIHRoZSBjbGVhbl9vbGRfZmJzIGFy Z3VtZW50LCB3aG9zZQo+IHVzZSB3YXMgcmVtb3ZlZCBpbiB0aGUgcGF0Y2ggcmVmZXJlbmNlZCBi ZWxvdy4gU28gcmVtb3ZlIHRoZSBpbnRlcm5hbAo+IGNvcHkgYW5kIGRyb3AgdGhlIGd1dHMgYmFj ayBpbnRvIGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKCkKPiAKPiBDaGFuZ2VzIGluIHYy Ogo+IC0gSW5zdGVhZCBvZiBqdXN0IHJlbW92aW5nIHRoZSB1bnVzZWQgYXJnLCBtZXJnZSB0aGUg ZnVuY3Rpb25zCj4gCj4gRml4ZXM6IGUwMGZiODU2NGVlOSAoImRybTogU3RvcCB1cGRhdGluZyBw bGFuZS0+Y3J0Yy9mYi9vbGRfZmIgb24gYXRvbWljIGRyaXZlcnMiKQo+IENjOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYWFydGVuIExhbmto b3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBIYXJyeSBXZW50 bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPiBDYzogU2luY2xhaXIgWWVoIDxzeWVoQHZt d2FyZS5jb20+ICMgVGhpcyBlbWFpbCBib3VuY2VzIDooCj4gQ2M6IE1heGltZSBSaXBhcmQgPG1h eGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gQ2M6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVu Pgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKUmV2 aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDU5ICsrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25z KCspLCAzMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ IGluZGV4IGM1M2VjYmQ5YWJkZGQuLjdhNzIzMWQwMDc3OTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+IEBAIC0zMDMwLDkgKzMwMzAsMzEgQEAgaW50IF9fZHJtX2F0b21p Y19oZWxwZXJfc2V0X2NvbmZpZyhzdHJ1Y3QgZHJtX21vZGVfc2V0ICpzZXQsCj4gIAlyZXR1cm4g MDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBfX2RybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxs KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gLQkJCQkJICAgc3RydWN0IGRybV9tb2Rlc2V0X2Fj cXVpcmVfY3R4ICpjdHgsCj4gLQkJCQkJICAgYm9vbCBjbGVhbl9vbGRfZmJzKQo+ICsvKioKPiAr ICogZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwgLSBkaXNhYmxlIGFsbCBjdXJyZW50bHkg YWN0aXZlIG91dHB1dHMKPiArICogQGRldjogRFJNIGRldmljZQo+ICsgKiBAY3R4OiBsb2NrIGFj cXVpc2l0aW9uIGNvbnRleHQKPiArICoKPiArICogTG9vcHMgdGhyb3VnaCBhbGwgY29ubmVjdG9y cywgZmluZGluZyB0aG9zZSB0aGF0IGFyZW4ndCB0dXJuZWQgb2ZmIGFuZCB0aGVuCj4gKyAqIHR1 cm5zIHRoZW0gb2ZmIGJ5IHNldHRpbmcgdGhlaXIgRFBNUyBtb2RlIHRvIE9GRiBhbmQgZGVhY3Rp dmF0aW5nIHRoZSBDUlRDCj4gKyAqIHRoYXQgdGhleSBhcmUgY29ubmVjdGVkIHRvLgo+ICsgKgo+ ICsgKiBUaGlzIGlzIHVzZWQgZm9yIGV4YW1wbGUgaW4gc3VzcGVuZC9yZXN1bWUgdG8gZGlzYWJs ZSBhbGwgY3VycmVudGx5IGFjdGl2ZQo+ICsgKiBmdW5jdGlvbnMgd2hlbiBzdXNwZW5kaW5nLiBJ ZiB5b3UganVzdCB3YW50IHRvIHNodXQgZG93biBldmVyeXRoaW5nIGF0IGUuZy4KPiArICogZHJp dmVyIHVubG9hZCwgbG9vayBhdCBkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bigpLgo+ICsgKgo+ ICsgKiBOb3RlIHRoYXQgaWYgY2FsbGVycyBoYXZlbid0IGFscmVhZHkgYWNxdWlyZWQgYWxsIG1v ZGVzZXQgbG9ja3MgdGhpcyBtaWdodAo+ICsgKiByZXR1cm4gLUVERUFETEssIHdoaWNoIG11c3Qg YmUgaGFuZGxlZCBieSBjYWxsaW5nIGRybV9tb2Rlc2V0X2JhY2tvZmYoKS4KPiArICoKPiArICog UmV0dXJuczoKPiArICogMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgZXJyb3IgY29kZSBvbiBm YWlsdXJlLgo+ICsgKgo+ICsgKiBTZWUgYWxzbzoKPiArICogZHJtX2F0b21pY19oZWxwZXJfc3Vz cGVuZCgpLCBkcm1fYXRvbWljX2hlbHBlcl9yZXN1bWUoKSBhbmQKPiArICogZHJtX2F0b21pY19o ZWxwZXJfc2h1dGRvd24oKS4KPiArICovCj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxl X2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICsJCQkJICBzdHJ1Y3QgZHJtX21vZGVzZXRf YWNxdWlyZV9jdHggKmN0eCkKPiAgewo+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl Owo+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gQEAgLTMwOTAs MzUgKzMxMTIsNiBAQCBzdGF0aWMgaW50IF9fZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsK PiAgCXJldHVybiByZXQ7Cj4gIH0KPiAtCj4gLS8qKgo+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9k aXNhYmxlX2FsbCAtIGRpc2FibGUgYWxsIGN1cnJlbnRseSBhY3RpdmUgb3V0cHV0cwo+IC0gKiBA ZGV2OiBEUk0gZGV2aWNlCj4gLSAqIEBjdHg6IGxvY2sgYWNxdWlzaXRpb24gY29udGV4dAo+IC0g Kgo+IC0gKiBMb29wcyB0aHJvdWdoIGFsbCBjb25uZWN0b3JzLCBmaW5kaW5nIHRob3NlIHRoYXQg YXJlbid0IHR1cm5lZCBvZmYgYW5kIHRoZW4KPiAtICogdHVybnMgdGhlbSBvZmYgYnkgc2V0dGlu ZyB0aGVpciBEUE1TIG1vZGUgdG8gT0ZGIGFuZCBkZWFjdGl2YXRpbmcgdGhlIENSVEMKPiAtICog dGhhdCB0aGV5IGFyZSBjb25uZWN0ZWQgdG8uCj4gLSAqCj4gLSAqIFRoaXMgaXMgdXNlZCBmb3Ig ZXhhbXBsZSBpbiBzdXNwZW5kL3Jlc3VtZSB0byBkaXNhYmxlIGFsbCBjdXJyZW50bHkgYWN0aXZl Cj4gLSAqIGZ1bmN0aW9ucyB3aGVuIHN1c3BlbmRpbmcuIElmIHlvdSBqdXN0IHdhbnQgdG8gc2h1 dCBkb3duIGV2ZXJ5dGhpbmcgYXQgZS5nLgo+IC0gKiBkcml2ZXIgdW5sb2FkLCBsb29rIGF0IGRy bV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkuCj4gLSAqCj4gLSAqIE5vdGUgdGhhdCBpZiBjYWxs ZXJzIGhhdmVuJ3QgYWxyZWFkeSBhY3F1aXJlZCBhbGwgbW9kZXNldCBsb2NrcyB0aGlzIG1pZ2h0 Cj4gLSAqIHJldHVybiAtRURFQURMSywgd2hpY2ggbXVzdCBiZSBoYW5kbGVkIGJ5IGNhbGxpbmcg ZHJtX21vZGVzZXRfYmFja29mZigpLgo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+IC0gKiAwIG9uIHN1 Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gLSAqCj4gLSAqIFNl ZSBhbHNvOgo+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9zdXNwZW5kKCksIGRybV9hdG9taWNfaGVs cGVyX3Jlc3VtZSgpIGFuZAo+IC0gKiBkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bigpLgo+IC0g Ki8KPiAtaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gLQkJCQkgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+IC17 Cj4gLQlyZXR1cm4gX19kcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxlX2FsbChkZXYsIGN0eCwgZmFs c2UpOwo+IC19Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZGlzYWJsZV9hbGwp Owo+ICAKPiAgLyoqCj4gQEAgLTMxMzksNyArMzEzMiw3IEBAIHZvaWQgZHJtX2F0b21pY19oZWxw ZXJfc2h1dGRvd24oc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCj4gIAlEUk1fTU9ERVNFVF9M T0NLX0FMTF9CRUdJTihkZXYsIGN0eCwgMCwgcmV0KTsKPiAgCj4gLQlyZXQgPSBfX2RybV9hdG9t aWNfaGVscGVyX2Rpc2FibGVfYWxsKGRldiwgJmN0eCwgdHJ1ZSk7Cj4gKwlyZXQgPSBkcm1fYXRv bWljX2hlbHBlcl9kaXNhYmxlX2FsbChkZXYsICZjdHgpOwo+ICAJaWYgKHJldCkKPiAgCQlEUk1f RVJST1IoIkRpc2FibGluZyBhbGwgY3J0YydzIGR1cmluZyB1bmxvYWQgZmFpbGVkIHdpdGggJWlc biIsIHJldCk7Cj4gIAo+IC0tIAo+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2ds ZSAvIENocm9taXVtIE9TCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==