From: Tony Lindgren <tony@atomide.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Tero Kristo <t-kristo@ti.com>,
linux-clk@vger.kernel.org, linux-omap@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH] clk: clk-twl6040: Fix imprecise external abort for pdmclk
Date: Wed, 13 Feb 2019 09:59:10 -0800 [thread overview]
Message-ID: <20190213175910.GY5720@atomide.com> (raw)
In-Reply-To: <155008032870.115909.10773814001430389227@swboyd.mtv.corp.google.com>
* Stephen Boyd <sboyd@kernel.org> [190213 17:52]:
> Quoting Tony Lindgren (2019-02-11 14:59:07)
> > I noticed that modprobe clk-twl6040 can fail after a cold boot with:
> > abe_cm:clk:0010:0: failed to enable
> > ...
> > Unhandled fault: imprecise external abort (0x1406) at 0xbe896b20
> >
> > WARNING: CPU: 1 PID: 29 at drivers/clk/clk.c:828 clk_core_disable_lock+0x18/0x24
> > ...
> > (clk_core_disable_lock) from [<c0123534>] (_disable_clocks+0x18/0x90)
> > (_disable_clocks) from [<c0124040>] (_idle+0x17c/0x244)
> > (_idle) from [<c0125ad4>] (omap_hwmod_idle+0x24/0x44)
> > (omap_hwmod_idle) from [<c053a038>] (sysc_runtime_suspend+0x48/0x108)
> > (sysc_runtime_suspend) from [<c06084c4>] (__rpm_callback+0x144/0x1d8)
> > (__rpm_callback) from [<c0608578>] (rpm_callback+0x20/0x80)
> > (rpm_callback) from [<c0607034>] (rpm_suspend+0x120/0x694)
> > (rpm_suspend) from [<c0607a78>] (__pm_runtime_idle+0x60/0x84)
> > (__pm_runtime_idle) from [<c053aaf0>] (sysc_probe+0x874/0xf2c)
> > (sysc_probe) from [<c05fecd4>] (platform_drv_probe+0x48/0x98)
> >
> > After searching around for a similar issue, I came across an earlier fix
> > that never got merged upstream in the Android tree for glass-omap-xrr02.
> > There is patch "MFD: twl6040-codec: Implement PDMCLK cold temp errata"
> > by Misael Lopez Cruz <misael.lopez@ti.com>.
> >
> > Based on my observations, this fix is also needed when cold booting
> > devices, and not just for deeper idle modes. Since we now have a clock
> > driver for pdmclk, let's fix the issue in twl6040_pdmclk_prepare().
> >
> > Cc: Misael Lopez Cruz <misael.lopez@ti.com>
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Should this be backported to stable trees?
Yes please, I think that's a good idea.
Regards,
Tony
next prev parent reply other threads:[~2019-02-13 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 22:59 [PATCH] clk: clk-twl6040: Fix imprecise external abort for pdmclk Tony Lindgren
2019-02-12 11:07 ` Peter Ujfalusi
2019-02-13 17:52 ` Stephen Boyd
2019-02-13 17:59 ` Tony Lindgren [this message]
2019-02-21 22:11 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213175910.GY5720@atomide.com \
--to=tony@atomide.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@ti.com \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.