From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability Date: Wed, 13 Feb 2019 19:24:35 +0100 Message-ID: <20190213182435.GA19906@lst.de> References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Christoph Hellwig , Linux IOMMU , Greg Kroah-Hartman , Lee Jones , x86@kernel.org, arcml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mips@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, SH-Linux , linux-xtensa@linux-xtensa.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: iommu@lists.linux-foundation.org On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4234C282CE for ; Wed, 13 Feb 2019 18:24:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A214222D0 for ; Wed, 13 Feb 2019 18:24:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d0v5PHkQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A214222D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WtQSJkQI42jH4ThKMwJXLnak3y0UCwFSGjMjUAViwM8=; b=d0v5PHkQTclTY1 9KBr0UKkBQKk6G9vGrlmoY5T40bMpdtab2hTqGM5ypIasdg3E/AexSWuIHBkbCoy5bn5EEWmupVA1 /zr6qa8eZw98/VWWzunrvHtVPLmyAWp7ikE+mTiD/tZVcPbg0qQkXVJbmb6wCMqT6cq/5Y4rp6vNd baPRDjml7ahCrBr/qZVEo2UdyYEwkui9yukKRyyEpeAUXbaxbxkLoxgPKpYPpIGAPkrLG4EPSTx/3 kc84FGDZrjEYGfoRhKXWlN/CgcgEKbff+GuFQT5/hudU+hQBXszmITAWC+WFe5wh9uERSrQ7WNJTH EqQok+/n6+DigCzdRecQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtzDB-0004Mz-Ah; Wed, 13 Feb 2019 18:24:45 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtzD2-0004BP-S6; Wed, 13 Feb 2019 18:24:38 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id 76AFD68C8E; Wed, 13 Feb 2019 19:24:35 +0100 (CET) Date: Wed, 13 Feb 2019 19:24:35 +0100 From: Christoph Hellwig To: Rob Herring Subject: Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability Message-ID: <20190213182435.GA19906@lst.de> References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_102437_058650_AFD3CF34 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, linuxppc-dev , SH-Linux , devicetree@vger.kernel.org, Greg Kroah-Hartman , x86@kernel.org, linux-mips@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux IOMMU , linux-riscv@lists.infradead.org, arcml , Lee Jones , Christoph Hellwig , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 13 Feb 2019 19:24:35 +0100 Subject: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability In-Reply-To: References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> List-ID: Message-ID: <20190213182435.GA19906@lst.de> To: linux-snps-arc@lists.infradead.org On Tue, Feb 12, 2019@02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 13 Feb 2019 18:24:35 +0000 Subject: Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability Message-Id: <20190213182435.GA19906@lst.de> List-Id: References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rob Herring Cc: linux-xtensa@linux-xtensa.org, linuxppc-dev , SH-Linux , devicetree@vger.kernel.org, Greg Kroah-Hartman , x86@kernel.org, linux-mips@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux IOMMU , linux-riscv@lists.infradead.org, arcml , Lee Jones , Christoph Hellwig , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7C8C282C2 for ; Wed, 13 Feb 2019 18:26:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CE8E222D0 for ; Wed, 13 Feb 2019 18:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CE8E222D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4407JX71KNzDqSs for ; Thu, 14 Feb 2019 05:26:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=newverein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4407Gb0GnSzDqQr for ; Thu, 14 Feb 2019 05:24:39 +1100 (AEDT) Received: by newverein.lst.de (Postfix, from userid 2407) id 76AFD68C8E; Wed, 13 Feb 2019 19:24:35 +0100 (CET) Date: Wed, 13 Feb 2019 19:24:35 +0100 From: Christoph Hellwig To: Rob Herring Subject: Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability Message-ID: <20190213182435.GA19906@lst.de> References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, linuxppc-dev , SH-Linux , devicetree@vger.kernel.org, Greg Kroah-Hartman , x86@kernel.org, linux-mips@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux IOMMU , linux-riscv@lists.infradead.org, arcml , Lee Jones , Christoph Hellwig , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695A2C282C2 for ; Wed, 13 Feb 2019 18:24:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 404B6222D0 for ; Wed, 13 Feb 2019 18:24:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m9YsW0iT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 404B6222D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4U/3AmfYM2OcrLxQSy32ii2SJoua8/g0VMC29uabHe4=; b=m9YsW0iTaRLCfU OdcYTPULaeZvR9DP04/lmTJR6/Rao0OuccwtXnmeWbPZdP691zwRXrNU4QMbU1ou8wmctMPeBdxhG /CMippyV17H6ETXKE54vra9yz1wQeAy1qwgnaTeJ/fPCBL+YpwGNMOjP7itloxDBrfMGt69S3owaq Zil4ux4K4ZkuXIDR/NrSYu9kv0RI/CY6DK5SZtPgX279p3QoSQB1zpxRDFmn0ZbBzBbQR0AiNW790 YjPhn6ABLxrp873wbcPQMCPjS+RLtyc9jhM7wICJLVniW/LN7E/whTjk+fZQ6v4QUPNupf/YXKnZk 9PMd/8y8cAN//csWQJTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtzD5-0004FP-KW; Wed, 13 Feb 2019 18:24:39 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtzD2-0004BP-S6; Wed, 13 Feb 2019 18:24:38 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id 76AFD68C8E; Wed, 13 Feb 2019 19:24:35 +0100 (CET) Date: Wed, 13 Feb 2019 19:24:35 +0100 From: Christoph Hellwig To: Rob Herring Subject: Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability Message-ID: <20190213182435.GA19906@lst.de> References: <20190211133554.30055-1-hch@lst.de> <20190211133554.30055-7-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_102437_058650_AFD3CF34 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xtensa@linux-xtensa.org, linuxppc-dev , SH-Linux , devicetree@vger.kernel.org, Greg Kroah-Hartman , x86@kernel.org, linux-mips@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux IOMMU , linux-riscv@lists.infradead.org, arcml , Lee Jones , Christoph Hellwig , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > > bool > > + select DMA_DECLARE_COHERENT > > Is selecting DMA_DECLARE_COHERENT okay on UML? We run the unittests with UML. No, that will fail with undefined references to memunmap. I gues this needs to be select DMA_DECLARE_COHERENT if HAS_DMA > Maybe we should just get rid of OF_RESERVED_MEM. If we support booting > from DT, then it should always be enabled anyways. Fine with me. Do you want me to respin the series to just remove it? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel