From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare via amd-gfx Subject: Re: [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params Date: Wed, 13 Feb 2019 10:49:50 -0800 Message-ID: <20190213184950.GB11553@intel.com> References: <20190213144536.21661-1-David.Francis@amd.com> <20190213144536.21661-3-David.Francis@amd.com> Reply-To: Manasi Navare Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190213144536.21661-3-David.Francis-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: David Francis Cc: intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, harry.wentland-5C7GfCeVMHo@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nikola.cornij-5C7GfCeVMHo@public.gmane.org T24gV2VkLCBGZWIgMTMsIDIwMTkgYXQgMDk6NDU6MzVBTSAtMDUwMCwgRGF2aWQgRnJhbmNpcyB3 cm90ZToKPiBOYXRpdmUgNDIwIGFuZCA0MjIgdHJhbnNmZXIgbW9kZXMgYXJlIG5ldyBpbiBEU0Mx LjIKPiAKPiBJbiB0aGVzZSBtb2RlcywgZWFjaCB0d28gcGl4ZWxzIG9mIGEgc2xpY2UgYXJlIHRy ZWF0ZWQgYXMgb25lCj4gcGl4ZWwsIHNvIHRoZSBzbGljZSB3aWR0aCBpcyBoYWxmIGFzIGxhcmdl IChyb3VuZCBkb3duKSBmb3IKPiB0aGUgcHVycG9zZXMgb2YgY2FsdWNhdGluZyB0aGUgZ3JvdXBz IHBlciBsaW5lIGFuZCBjaHVuayBzaXplCj4gaW4gYnl0ZXMKPiAKPiBJbiBuYXRpdmUgNDIyIG1v ZGUsIGVhY2ggcGl4ZWwgaGFzIGZvdXIgY29tcG9uZW50cywgc28gdGhlCj4gbXV4IGNvbXBvbmVu dCBvZiBhIGdyb3VwIGlzIGxhcmdlciBieSBvbmUgYWRkaXRpb25hbCBtdXggd29yZAo+IGFuZCBv bmUgYWRkaXRpb25hbCBjb21wb25lbnQKPiAKPiBOb3cgdGhhdCB0aGVyZSBpcyBuYXRpdmUgNDIy IHN1cHBvcnQsIHRoZSBjb25maWd1cmF0aW9uIG9wdGlvbgo+IHByZXZpb3VzbHkgY2FsbGVkIGVu YWJsZTQyMiBpcyByZW5hbWVkIHRvIHNpbXBsZV80MjIgdG8gYXZvaWQKPiBjb25mdXNpb24KPiAK PiBTaWduZWQtb2ZmLWJ5OiBEYXZpZCBGcmFuY2lzIDxEYXZpZC5GcmFuY2lzQGFtZC5jb20+CgpU aGlzIGxvb2tzIGdvb2QgYW5kIHZlcmlmaWVkIHRoYXQgdGhlIERTQyAxLjIgc3BlYyBhY3R1YWxs eSByZW5hbWVzIGl0CmFzIHNpbXBsZV80MjIuCgpSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZSA8 bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KCk1hbmFzaQoKPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9kc2MuYyAgICAgICAgIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF92ZHNjLmMgfCAgNCArKy0tCj4gIGluY2x1 ZGUvZHJtL2RybV9kc2MuaCAgICAgICAgICAgICB8ICA0ICsrLS0KPiAgMyBmaWxlcyBjaGFuZ2Vk LCAyNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9kc2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHNjLmMKPiBpbmRl eCA0YjBlM2M5YzNmZjguLjllNjc1ZGQzOWE0NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2RzYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kc2MuYwo+IEBAIC03Nyw3 ICs3Nyw3IEBAIHZvaWQgZHJtX2RzY19wcHNfaW5mb2ZyYW1lX3BhY2soc3RydWN0IGRybV9kc2Nf cHBzX2luZm9mcmFtZSAqcHBzX3NkcCwKPiAgCQkoKGRzY19jZmctPmJpdHNfcGVyX3BpeGVsICYg RFNDX1BQU19CUFBfSElHSF9NQVNLKSA+Pgo+ICAJCSBEU0NfUFBTX01TQl9TSElGVCkgfAo+ICAJ CWRzY19jZmctPnZicl9lbmFibGUgPDwgRFNDX1BQU19WQlJfRU5fU0hJRlQgfAo+IC0JCWRzY19j ZmctPmVuYWJsZTQyMiA8PCBEU0NfUFBTX1NJTVBMRTQyMl9TSElGVCB8Cj4gKwkJZHNjX2NmZy0+ c2ltcGxlXzQyMiA8PCBEU0NfUFBTX1NJTVBMRTQyMl9TSElGVCB8Cj4gIAkJZHNjX2NmZy0+Y29u dmVydF9yZ2IgPDwgRFNDX1BQU19DT05WRVJUX1JHQl9TSElGVCB8Cj4gIAkJZHNjX2NmZy0+Ymxv Y2tfcHJlZF9lbmFibGUgPDwgRFNDX1BQU19CTE9DS19QUkVEX0VOX1NISUZUOwo+ICAKPiBAQCAt MjQ2LDE5ICsyNDYsMzQgQEAgaW50IGRybV9kc2NfY29tcHV0ZV9yY19wYXJhbWV0ZXJzKHN0cnVj dCBkcm1fZHNjX2NvbmZpZyAqdmRzY19jZmcpCj4gIAl1bnNpZ25lZCBsb25nIGZpbmFsX3NjYWxl ID0gMDsKPiAgCXVuc2lnbmVkIGxvbmcgcmJzX21pbiA9IDA7Cj4gIAo+IC0JLyogTnVtYmVyIG9m IGdyb3VwcyB1c2VkIHRvIGNvZGUgZWFjaCBsaW5lIG9mIGEgc2xpY2UgKi8KPiAtCWdyb3Vwc19w ZXJfbGluZSA9IERJVl9ST1VORF9VUCh2ZHNjX2NmZy0+c2xpY2Vfd2lkdGgsCj4gLQkJCQkgICAg ICAgRFNDX1JDX1BJWEVMU19QRVJfR1JPVVApOwo+ICsJaWYgKHZkc2NfY2ZnLT5uYXRpdmVfNDIw IHx8IHZkc2NfY2ZnLT5uYXRpdmVfNDIyKSB7Cj4gKwkJLyogTnVtYmVyIG9mIGdyb3VwcyB1c2Vk IHRvIGNvZGUgZWFjaCBsaW5lIG9mIGEgc2xpY2UgKi8KPiArCQlncm91cHNfcGVyX2xpbmUgPSBE SVZfUk9VTkRfVVAodmRzY19jZmctPnNsaWNlX3dpZHRoIC8gMiwKPiArCQkJCQkgICAgICAgRFND X1JDX1BJWEVMU19QRVJfR1JPVVApOwo+ICAKPiAtCS8qIGNodW5rc2l6ZSBpbiBCeXRlcyAqLwo+ IC0JdmRzY19jZmctPnNsaWNlX2NodW5rX3NpemUgPSBESVZfUk9VTkRfVVAodmRzY19jZmctPnNs aWNlX3dpZHRoICoKPiAtCQkJCQkJICB2ZHNjX2NmZy0+Yml0c19wZXJfcGl4ZWwsCj4gLQkJCQkJ CSAgKDggKiAxNikpOwo+ICsJCS8qIGNodW5rc2l6ZSBpbiBCeXRlcyAqLwo+ICsJCXZkc2NfY2Zn LT5zbGljZV9jaHVua19zaXplID0gRElWX1JPVU5EX1VQKHZkc2NfY2ZnLT5zbGljZV93aWR0aCAv IDIgKgo+ICsJCQkJCQkJICB2ZHNjX2NmZy0+Yml0c19wZXJfcGl4ZWwsCj4gKwkJCQkJCQkgICg4 ICogMTYpKTsKPiArCX0gZWxzZSB7Cj4gKwkJLyogTnVtYmVyIG9mIGdyb3VwcyB1c2VkIHRvIGNv ZGUgZWFjaCBsaW5lIG9mIGEgc2xpY2UgKi8KPiArCQlncm91cHNfcGVyX2xpbmUgPSBESVZfUk9V TkRfVVAodmRzY19jZmctPnNsaWNlX3dpZHRoLAo+ICsJCQkJCSAgICAgICBEU0NfUkNfUElYRUxT X1BFUl9HUk9VUCk7Cj4gKwo+ICsJCS8qIGNodW5rc2l6ZSBpbiBCeXRlcyAqLwo+ICsJCXZkc2Nf Y2ZnLT5zbGljZV9jaHVua19zaXplID0gRElWX1JPVU5EX1VQKHZkc2NfY2ZnLT5zbGljZV93aWR0 aCAqCj4gKwkJCQkJCQkgIHZkc2NfY2ZnLT5iaXRzX3Blcl9waXhlbCwKPiArCQkJCQkJCSAgKDgg KiAxNikpOwo+ICsJfQo+ICAKPiAgCWlmICh2ZHNjX2NmZy0+Y29udmVydF9yZ2IpCj4gIAkJbnVt X2V4dHJhX211eF9iaXRzID0gMyAqICh2ZHNjX2NmZy0+bXV4X3dvcmRfc2l6ZSArCj4gIAkJCQkJ ICAoNCAqIHZkc2NfY2ZnLT5iaXRzX3Blcl9jb21wb25lbnQgKyA0KQo+ICAJCQkJCSAgLSAyKTsK PiArCWVsc2UgaWYgKHZkc2NfY2ZnLT5uYXRpdmVfNDIyKQo+ICsJCW51bV9leHRyYV9tdXhfYml0 cyA9IDQgKiB2ZHNjX2NmZy0+bXV4X3dvcmRfc2l6ZSArCj4gKwkJCSg0ICogdmRzY19jZmctPmJp dHNfcGVyX2NvbXBvbmVudCArIDQpICsKPiArCQkJMyAqICg0ICogdmRzY19jZmctPmJpdHNfcGVy X2NvbXBvbmVudCkgLSAyOwo+ICAJZWxzZQo+ICAJCW51bV9leHRyYV9tdXhfYml0cyA9IDMgKiB2 ZHNjX2NmZy0+bXV4X3dvcmRfc2l6ZSArCj4gIAkJCSg0ICogdmRzY19jZmctPmJpdHNfcGVyX2Nv bXBvbmVudCArIDQpICsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf dmRzYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdmRzYy5jCj4gaW5kZXggYzc2Y2Vj OGJmYjc0Li43NzAyYzVjOGIzZjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdmRzYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdmRzYy5jCj4g QEAgLTM2OSw3ICszNjksNyBAQCBpbnQgaW50ZWxfZHBfY29tcHV0ZV9kc2NfcGFyYW1zKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJCURTQ18xXzFfTUFYX0xJTkVCVUZfREVQVEhfQklU UyA6IGxpbmVfYnVmX2RlcHRoOwo+ICAKPiAgCS8qIEdlbiAxMSBkb2VzIG5vdCBzdXBwb3J0IFlD YkNyICovCj4gLQl2ZHNjX2NmZy0+ZW5hYmxlNDIyID0gZmFsc2U7Cj4gKwl2ZHNjX2NmZy0+c2lt cGxlXzQyMiA9IGZhbHNlOwo+ICAJLyogR2VuIDExIGRvZXMgbm90IHN1cHBvcnQgVkJSICovCj4g IAl2ZHNjX2NmZy0+dmJyX2VuYWJsZSA9IGZhbHNlOwo+ICAJdmRzY19jZmctPmJsb2NrX3ByZWRf ZW5hYmxlID0KPiBAQCAtNDk2LDcgKzQ5Niw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2NvbmZpZ3Vy ZV9wcHNfZm9yX2RzY19lbmNvZGVyKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJ CXBwc192YWwgfD0gRFNDX0JMT0NLX1BSRURJQ1RJT047Cj4gIAlpZiAodmRzY19jZmctPmNvbnZl cnRfcmdiKQo+ICAJCXBwc192YWwgfD0gRFNDX0NPTE9SX1NQQUNFX0NPTlZFUlNJT047Cj4gLQlp ZiAodmRzY19jZmctPmVuYWJsZTQyMikKPiArCWlmICh2ZHNjX2NmZy0+c2ltcGxlXzQyMikKPiAg CQlwcHNfdmFsIHw9IERTQ180MjJfRU5BQkxFOwo+ICAJaWYgKHZkc2NfY2ZnLT52YnJfZW5hYmxl KQo+ICAJCXBwc192YWwgfD0gRFNDX1ZCUl9FTkFCTEU7Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv ZHJtL2RybV9kc2MuaCBiL2luY2x1ZGUvZHJtL2RybV9kc2MuaAo+IGluZGV4IGFkNDM0OTRmMWNj OC4uNGU1NWUzNzk0M2Q3IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9kc2MuaAo+ICsr KyBiL2luY2x1ZGUvZHJtL2RybV9kc2MuaAo+IEBAIC03MCwxMCArNzAsMTAgQEAgc3RydWN0IGRy bV9kc2NfY29uZmlnIHsKPiAgCS8qIFNsaWNlIEhlaWdodCAqLwo+ICAJdTE2IHNsaWNlX2hlaWdo dDsKPiAgCS8qCj4gLQkgKiA0OjI6MiBlbmFibGUgbW9kZSAoZnJvbSBQUFMsIDQ6MjoyIGNvbnZl cnNpb24gaGFwcGVucwo+ICsJICogU2ltcGxlIDQ6MjoyIG1vZGUgKGZyb20gUFBTLCA0OjI6MiBj b252ZXJzaW9uIGhhcHBlbnMKPiAgCSAqIG91dHNpZGUgb2YgRFNDIGVuY29kZS9kZWNvZGUgYWxn b3JpdGhtKQo+ICAJICovCj4gLQlib29sIGVuYWJsZTQyMjsKPiArCWJvb2wgc2ltcGxlXzQyMjsK PiAgCS8qIFBpY3R1cmUgV2lkdGggKi8KPiAgCXUxNiBwaWNfd2lkdGg7Cj4gIAkvKiBQaWN0dXJl IEhlaWdodCAqLwo+IC0tIAo+IDIuMTcuMQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZng=