From: Eran Matityahu <eran.m@variscite.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit
Date: Wed, 13 Feb 2019 20:56:17 +0200 [thread overview]
Message-ID: <20190213185617.GA8224@ubuntu> (raw)
Before printk.h was introduced and MTDDEBUG was removed,
pr_crit() was calling MTDDEBUG(), which was since then
replaced by the current pr_debug().
pr_debug is more appropriate here.
Signed-off-by: Eran Matityahu <eran.m@variscite.com>
---
drivers/mtd/ubi/debug.h | 2 +-
fs/ubifs/debug.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/ubi/debug.h b/drivers/mtd/ubi/debug.h
index d853520..2c2faaf 100644
--- a/drivers/mtd/ubi/debug.h
+++ b/drivers/mtd/ubi/debug.h
@@ -29,7 +29,7 @@ void ubi_dump_vid_hdr(const struct ubi_vid_hdr *vid_hdr);
#else
#define ubi_assert(expr) do { \
if (unlikely(!(expr))) { \
- pr_crit("UBI assert failed in %s at %u\n", \
+ pr_debug("UBI assert failed in %s at %u\n", \
__func__, __LINE__); \
dump_stack(); \
} \
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index bad0c67..5f6e127 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -167,7 +167,7 @@ struct ubifs_global_debug_info {
#else
#define ubifs_assert(expr) do { \
if (unlikely(!(expr))) { \
- pr_crit("UBIFS assert failed in %s at %u\n", \
+ pr_debug("UBIFS assert failed in %s at %u\n", \
__func__, __LINE__); \
dump_stack(); \
} \
@@ -176,7 +176,7 @@ struct ubifs_global_debug_info {
#define ubifs_assert_cmt_locked(c) do { \
if (unlikely(down_write_trylock(&(c)->commit_sem))) { \
up_write(&(c)->commit_sem); \
- pr_crit("commit lock is not locked!\n"); \
+ pr_debug("commit lock is not locked!\n"); \
ubifs_assert(0); \
} \
} while (0)
--
1.9.1
next reply other threads:[~2019-02-13 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 18:56 Eran Matityahu [this message]
2019-03-07 5:17 ` [U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit Heiko Schocher
2019-04-09 13:28 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213185617.GA8224@ubuntu \
--to=eran.m@variscite.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.